From: Herve Codina <herve.codina@bootlin.com> To: Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Herve Codina <herve.codina@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: [PATCH 4/4] mtd: rawnand: fsmc: Fix timing computation Date: Fri, 12 Nov 2021 15:38:55 +0100 [thread overview] Message-ID: <20211112143855.2678989-5-herve.codina@bootlin.com> (raw) In-Reply-To: <20211112143855.2678989-1-herve.codina@bootlin.com> The timing setting were incorrect on some nands leading to a fallback to mode 0 timing on some Micron nand or to incorrect data reads on some Winbond NAND. The timing computation did not take into account the following constraint given in SPEAr3xx reference manual: twait >= tCEA - tset*TCLK + TOUTDEL + TINDEL This patch adds this constraint and fixes the issues on both nands having the both nands working at mode 3 timing. The change has no impact on slower timing mode such as mode 0. Indeed, on mode 0 timing, computed values are the same with and without the patch. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/mtd/nand/raw/fsmc_nand.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/raw/fsmc_nand.c b/drivers/mtd/nand/raw/fsmc_nand.c index bff09219ce3a..a3aa66f30869 100644 --- a/drivers/mtd/nand/raw/fsmc_nand.c +++ b/drivers/mtd/nand/raw/fsmc_nand.c @@ -278,7 +278,7 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, { unsigned long hclk = clk_get_rate(host->clk); unsigned long hclkn = NSEC_PER_SEC / hclk; - u32 thiz, thold, twait, tset; + u32 thiz, thold, twait, tset, tmp; if (sdrt->tRC_min < 30000) return -EOPNOTSUPP; @@ -310,13 +310,6 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, else if (tims->thold > FSMC_THOLD_MASK) tims->thold = FSMC_THOLD_MASK; - twait = max(sdrt->tRP_min, sdrt->tWP_min); - tims->twait = DIV_ROUND_UP(twait / 1000, hclkn) - 1; - if (tims->twait == 0) - tims->twait = 1; - else if (tims->twait > FSMC_TWAIT_MASK) - tims->twait = FSMC_TWAIT_MASK; - tset = max(sdrt->tCS_min - sdrt->tWP_min, sdrt->tCEA_max - sdrt->tREA_max); tims->tset = DIV_ROUND_UP(tset / 1000, hclkn) - 1; @@ -325,6 +318,24 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, else if (tims->tset > FSMC_TSET_MASK) tims->tset = FSMC_TSET_MASK; + twait = max(sdrt->tRP_min, sdrt->tWP_min); + + /* According to SPEAr300 Reference Manual (RM0082) which gives more + * information related to FSMSC timings than the SPEAr600 one (RM0305), + * twait >= tCEA - tset*TCLK + TOUTDEL + TINDEL + * With TOUTDEL = 7ns (Output delay from the flip-flops to the board) + * and TINDEL = 5ns (Input delay from the board to the flipflop) + */ + tmp = sdrt->tCEA_max - (tims->tset + 1)*hclkn*1000 + 7000 + 5000; + if (twait < tmp) + twait = tmp; + + tims->twait = DIV_ROUND_UP(twait / 1000, hclkn) - 1; + if (tims->twait == 0) + tims->twait = 1; + else if (tims->twait > FSMC_TWAIT_MASK) + tims->twait = FSMC_TWAIT_MASK; + return 0; } -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com> To: Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Herve Codina <herve.codina@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: [PATCH 4/4] mtd: rawnand: fsmc: Fix timing computation Date: Fri, 12 Nov 2021 15:38:55 +0100 [thread overview] Message-ID: <20211112143855.2678989-5-herve.codina@bootlin.com> (raw) In-Reply-To: <20211112143855.2678989-1-herve.codina@bootlin.com> The timing setting were incorrect on some nands leading to a fallback to mode 0 timing on some Micron nand or to incorrect data reads on some Winbond NAND. The timing computation did not take into account the following constraint given in SPEAr3xx reference manual: twait >= tCEA - tset*TCLK + TOUTDEL + TINDEL This patch adds this constraint and fixes the issues on both nands having the both nands working at mode 3 timing. The change has no impact on slower timing mode such as mode 0. Indeed, on mode 0 timing, computed values are the same with and without the patch. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/mtd/nand/raw/fsmc_nand.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/raw/fsmc_nand.c b/drivers/mtd/nand/raw/fsmc_nand.c index bff09219ce3a..a3aa66f30869 100644 --- a/drivers/mtd/nand/raw/fsmc_nand.c +++ b/drivers/mtd/nand/raw/fsmc_nand.c @@ -278,7 +278,7 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, { unsigned long hclk = clk_get_rate(host->clk); unsigned long hclkn = NSEC_PER_SEC / hclk; - u32 thiz, thold, twait, tset; + u32 thiz, thold, twait, tset, tmp; if (sdrt->tRC_min < 30000) return -EOPNOTSUPP; @@ -310,13 +310,6 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, else if (tims->thold > FSMC_THOLD_MASK) tims->thold = FSMC_THOLD_MASK; - twait = max(sdrt->tRP_min, sdrt->tWP_min); - tims->twait = DIV_ROUND_UP(twait / 1000, hclkn) - 1; - if (tims->twait == 0) - tims->twait = 1; - else if (tims->twait > FSMC_TWAIT_MASK) - tims->twait = FSMC_TWAIT_MASK; - tset = max(sdrt->tCS_min - sdrt->tWP_min, sdrt->tCEA_max - sdrt->tREA_max); tims->tset = DIV_ROUND_UP(tset / 1000, hclkn) - 1; @@ -325,6 +318,24 @@ static int fsmc_calc_timings(struct fsmc_nand_data *host, else if (tims->tset > FSMC_TSET_MASK) tims->tset = FSMC_TSET_MASK; + twait = max(sdrt->tRP_min, sdrt->tWP_min); + + /* According to SPEAr300 Reference Manual (RM0082) which gives more + * information related to FSMSC timings than the SPEAr600 one (RM0305), + * twait >= tCEA - tset*TCLK + TOUTDEL + TINDEL + * With TOUTDEL = 7ns (Output delay from the flip-flops to the board) + * and TINDEL = 5ns (Input delay from the board to the flipflop) + */ + tmp = sdrt->tCEA_max - (tims->tset + 1)*hclkn*1000 + 7000 + 5000; + if (twait < tmp) + twait = tmp; + + tims->twait = DIV_ROUND_UP(twait / 1000, hclkn) - 1; + if (tims->twait == 0) + tims->twait = 1; + else if (tims->twait > FSMC_TWAIT_MASK) + tims->twait = FSMC_TWAIT_MASK; + return 0; } -- 2.31.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-11-12 14:39 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-12 14:38 [PATCH 0/4] mtd: rawnand: Fixes nand infra delay setting and FSMC nand controller Herve Codina 2021-11-12 14:38 ` Herve Codina 2021-11-12 14:38 ` [PATCH 1/4] mtd: rawnand: Fix nand_erase_op delay Herve Codina 2021-11-12 14:38 ` Herve Codina 2021-11-12 14:38 ` [PATCH 2/4] mtd: rawnand: fsmc: Force to use 8 bits access when expected Herve Codina 2021-11-12 14:38 ` Herve Codina 2021-11-12 15:38 ` Miquel Raynal 2021-11-12 15:38 ` Miquel Raynal 2021-11-17 13:47 ` Herve Codina 2021-11-17 13:47 ` Herve Codina 2021-11-12 14:38 ` [PATCH 3/4] mtd: rawnand: fsmc: Take instruction delay into account Herve Codina 2021-11-12 14:38 ` Herve Codina 2021-11-12 14:38 ` Herve Codina [this message] 2021-11-12 14:38 ` [PATCH 4/4] mtd: rawnand: fsmc: Fix timing computation Herve Codina 2021-11-12 15:52 ` Miquel Raynal 2021-11-12 15:52 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211112143855.2678989-5-herve.codina@bootlin.com \ --to=herve.codina@bootlin.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.