[Buildroot] [PATCH 1/1] package/firmware-utils: needs dynamic library

[Buildroot] [PATCH 1/1] package/firmware-utils: needs dynamic library

[Fabrice Fontaine]

As usual with cmake packages, static builds are not supported and result
in the following build failure:

/home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/9.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-1/output-1/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(c_zlib.o): in function `zlib_stateful_expand_block':
c_zlib.c:(.text+0x54): undefined reference to `inflate'

Instead of patching CMakeLists.txt to add a call to pkg-config, add a
dependency on dynamic library

Fixes:
 - http://autobuild.buildroot.org/results/16a89075e6a809a551e7155a64a4e6b6701428e1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/firmware-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/firmware-utils/Config.in b/package/firmware-utils/Config.in
index 501b89b453..7753360702 100644
--- a/package/firmware-utils/Config.in
+++ b/package/firmware-utils/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_FIRMWARE_UTILS
 	bool "firmware-utils"
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
 	select BR2_PACKAGE_ZLIB
@@ -14,3 +15,6 @@ config BR2_PACKAGE_FIRMWARE_UTILS
 	  extract a part of firmware image and flash it.
 
 	  https://git.openwrt.org/?p=project/firmware-utils.git;a=summary
+
+comment "firmware-utils needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/firmware-utils: needs dynamic library

[Thomas Petazzoni]

On Sat, 13 Nov 2021 17:04:44 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> As usual with cmake packages, static builds are not supported and result
> in the following build failure:
> 
> /home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/9.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-1/output-1/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(c_zlib.o): in function `zlib_stateful_expand_block':
> c_zlib.c:(.text+0x54): undefined reference to `inflate'
> 
> Instead of patching CMakeLists.txt to add a call to pkg-config, add a
> dependency on dynamic library
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/16a89075e6a809a551e7155a64a4e6b6701428e1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/firmware-utils/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot