All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/mtd/nand/raw/atmel/nand-controller.c:1532 atmel_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'
@ 2021-11-13 18:56 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-13 18:56 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3603 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Miquel Raynal <miquel.raynal@bootlin.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   66f4beaa6c1d28161f534471484b2daa2de1dce0
commit: ed2a491037116387f109e851a2b46adcb5feca3b mtd: rawnand: atmel: Check the proposed data interface is supported
date:   6 months ago
:::::: branch date: 22 hours ago
:::::: commit date: 6 months ago
config: h8300-randconfig-m031-20211013 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/nand/raw/atmel/nand-controller.c:1532 atmel_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +1532 drivers/mtd/nand/raw/atmel/nand-controller.c

f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1522  
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1523  static int atmel_nand_setup_interface(struct nand_chip *chip, int csline,
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1524  				      const struct nand_interface_config *conf)
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1525  {
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1526  	struct atmel_nand *nand = to_atmel_nand(chip);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1527  	const struct nand_sdr_timings *sdr;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1528  	struct atmel_nand_controller *nc;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1529  
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1530  	sdr = nand_get_sdr_timings(conf);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1531  	if (IS_ERR(sdr))
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05 @1532  		return PTR_ERR(sdr);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1533  
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1534  	nc = to_nand_controller(nand->base.controller);
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1535  
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1536  	if (csline >= nand->numcs ||
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1537  	    (csline < 0 && csline != NAND_DATA_IFACE_CHECK_ONLY))
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1538  		return -EINVAL;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1539  
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1540  	return nc->caps->ops->setup_interface(nand, csline, conf);
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1541  }
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1542  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28644 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* drivers/mtd/nand/raw/atmel/nand-controller.c:1532 atmel_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'
@ 2021-12-04  3:23 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-12-04  3:23 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3674 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Miquel Raynal <miquel.raynal@bootlin.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   12119cfa1052d512a92524e90ebee85029a918f8
commit: ed2a491037116387f109e851a2b46adcb5feca3b mtd: rawnand: atmel: Check the proposed data interface is supported
date:   6 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 6 months ago
config: nios2-randconfig-m031-20211202 (https://download.01.org/0day-ci/archive/20211204/202112041148.r2LYXA8f-lkp(a)intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/nand/raw/atmel/nand-controller.c:1532 atmel_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +1532 drivers/mtd/nand/raw/atmel/nand-controller.c

f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1522  
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1523  static int atmel_nand_setup_interface(struct nand_chip *chip, int csline,
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1524  				      const struct nand_interface_config *conf)
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1525  {
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1526  	struct atmel_nand *nand = to_atmel_nand(chip);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1527  	const struct nand_sdr_timings *sdr;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1528  	struct atmel_nand_controller *nc;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1529  
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1530  	sdr = nand_get_sdr_timings(conf);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1531  	if (IS_ERR(sdr))
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05 @1532  		return PTR_ERR(sdr);
ed2a4910371163 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2021-05-05  1533  
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1534  	nc = to_nand_controller(nand->base.controller);
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1535  
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1536  	if (csline >= nand->numcs ||
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1537  	    (csline < 0 && csline != NAND_DATA_IFACE_CHECK_ONLY))
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1538  		return -EINVAL;
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1539  
4c46667b3d6725 drivers/mtd/nand/raw/atmel/nand-controller.c Miquel Raynal   2020-05-29  1540  	return nc->caps->ops->setup_interface(nand, csline, conf);
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1541  }
f9ce2eddf1769a drivers/mtd/nand/atmel/nand-controller.c     Boris Brezillon 2017-03-16  1542  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-04  3:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 18:56 drivers/mtd/nand/raw/atmel/nand-controller.c:1532 atmel_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR' kernel test robot
2021-12-04  3:23 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.