All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipvs: remove unused variable for ip_vs_new_dest
@ 2021-11-05 11:39 ` GuoYong Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: GuoYong Zheng @ 2021-11-05 11:39 UTC (permalink / raw)
  To: lvs-devel, netfilter-devel
  Cc: horms, ja, pablo, kadlec, fw, davem, kuba, netdev, coreteam,
	linux-kernel, GuoYong Zheng

The dest variable is not used after ip_vs_new_dest anymore in
ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.

Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
---
 net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index e62b40b..494399d 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
  *	Create a destination for the given service
  */
 static int
-ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
-	       struct ip_vs_dest **dest_p)
+ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
 {
 	struct ip_vs_dest *dest;
 	unsigned int atype, i;
@@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
 	spin_lock_init(&dest->stats.lock);
 	__ip_vs_update_dest(svc, dest, udest, 1);
 
-	*dest_p = dest;
-
 	LeaveFunction(2);
 	return 0;
 
@@ -1095,7 +1092,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
 		/*
 		 * Allocate and initialize the dest structure
 		 */
-		ret = ip_vs_new_dest(svc, udest, &dest);
+		ret = ip_vs_new_dest(svc, udest);
 	}
 	LeaveFunction(2);
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] ipvs: remove unused variable for ip_vs_new_dest
@ 2021-11-05 11:39 ` GuoYong Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: GuoYong Zheng @ 2021-11-05 11:39 UTC (permalink / raw)
  To: lvs-devel, netfilter-devel
  Cc: horms, ja, pablo, kadlec, fw, davem, kuba, netdev, coreteam,
	linux-kernel, GuoYong Zheng

The dest variable is not used after ip_vs_new_dest anymore in
ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.

Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
---
 net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index e62b40b..494399d 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
  *	Create a destination for the given service
  */
 static int
-ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
-	       struct ip_vs_dest **dest_p)
+ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
 {
 	struct ip_vs_dest *dest;
 	unsigned int atype, i;
@@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
 	spin_lock_init(&dest->stats.lock);
 	__ip_vs_update_dest(svc, dest, udest, 1);
 
-	*dest_p = dest;

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] ipvs: remove unused variable for ip_vs_new_dest
  2021-11-05 11:39 ` GuoYong Zheng
  (?)
@ 2021-11-13  9:56 ` Julian Anastasov
  2021-11-14 18:02   ` Simon Horman
  -1 siblings, 1 reply; 7+ messages in thread
From: Julian Anastasov @ 2021-11-13  9:56 UTC (permalink / raw)
  To: GuoYong Zheng
  Cc: lvs-devel, netfilter-devel, Simon Horman, pablo, netdev,
	coreteam, linux-kernel


	Hello,

On Fri, 5 Nov 2021, GuoYong Zheng wrote:

> The dest variable is not used after ip_vs_new_dest anymore in
> ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.
> 
> Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>

	Looks good to me for -next, thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>

> ---
>  net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index e62b40b..494399d 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>   *	Create a destination for the given service
>   */
>  static int
> -ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
> -	       struct ip_vs_dest **dest_p)
> +ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
>  {
>  	struct ip_vs_dest *dest;
>  	unsigned int atype, i;
> @@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>  	spin_lock_init(&dest->stats.lock);
>  	__ip_vs_update_dest(svc, dest, udest, 1);
>  
> -	*dest_p = dest;
> -
>  	LeaveFunction(2);
>  	return 0;
>  
> @@ -1095,7 +1092,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>  		/*
>  		 * Allocate and initialize the dest structure
>  		 */
> -		ret = ip_vs_new_dest(svc, udest, &dest);
> +		ret = ip_vs_new_dest(svc, udest);
>  	}
>  	LeaveFunction(2);
>  
> -- 
> 1.8.3.1

Regards

--
Julian Anastasov <ja@ssi.bg>


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ipvs: remove unused variable for ip_vs_new_dest
  2021-11-13  9:56 ` Julian Anastasov
@ 2021-11-14 18:02   ` Simon Horman
  2021-11-18  1:09       ` zhenggy
  2021-11-30 21:46     ` Pablo Neira Ayuso
  0 siblings, 2 replies; 7+ messages in thread
From: Simon Horman @ 2021-11-14 18:02 UTC (permalink / raw)
  To: Julian Anastasov, pablo
  Cc: GuoYong Zheng, lvs-devel, netfilter-devel, netdev, coreteam,
	linux-kernel

On Sat, Nov 13, 2021 at 11:56:36AM +0200, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Fri, 5 Nov 2021, GuoYong Zheng wrote:
> 
> > The dest variable is not used after ip_vs_new_dest anymore in
> > ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.
> > 
> > Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
> 
> 	Looks good to me for -next, thanks!
> 
> Acked-by: Julian Anastasov <ja@ssi.bg>

Thanks GuoYong,

Acked-by: Simon Horman <horms@verge.net.au>

Pablo, please consider this for nf-next at your convenience.

> 
> > ---
> >  net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> > index e62b40b..494399d 100644
> > --- a/net/netfilter/ipvs/ip_vs_ctl.c
> > +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> > @@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
> >   *	Create a destination for the given service
> >   */
> >  static int
> > -ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
> > -	       struct ip_vs_dest **dest_p)
> > +ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
> >  {
> >  	struct ip_vs_dest *dest;
> >  	unsigned int atype, i;
> > @@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
> >  	spin_lock_init(&dest->stats.lock);
> >  	__ip_vs_update_dest(svc, dest, udest, 1);
> >  
> > -	*dest_p = dest;
> > -
> >  	LeaveFunction(2);
> >  	return 0;
> >  
> > @@ -1095,7 +1092,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
> >  		/*
> >  		 * Allocate and initialize the dest structure
> >  		 */
> > -		ret = ip_vs_new_dest(svc, udest, &dest);
> > +		ret = ip_vs_new_dest(svc, udest);
> >  	}
> >  	LeaveFunction(2);
> >  
> > -- 
> > 1.8.3.1
> 
> Regards
> 
> --
> Julian Anastasov <ja@ssi.bg>
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ipvs: remove unused variable for ip_vs_new_dest
  2021-11-14 18:02   ` Simon Horman
@ 2021-11-18  1:09       ` zhenggy
  2021-11-30 21:46     ` Pablo Neira Ayuso
  1 sibling, 0 replies; 7+ messages in thread
From: zhenggy @ 2021-11-18  1:09 UTC (permalink / raw)
  To: Simon Horman, Julian Anastasov, pablo
  Cc: lvs-devel, netfilter-devel, netdev, coreteam, linux-kernel

Thanks for review.

在 2021/11/15 2:02, Simon Horman 写道:
> On Sat, Nov 13, 2021 at 11:56:36AM +0200, Julian Anastasov wrote:
>>
>> 	Hello,
>>
>> On Fri, 5 Nov 2021, GuoYong Zheng wrote:
>>
>>> The dest variable is not used after ip_vs_new_dest anymore in
>>> ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.
>>>
>>> Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
>>
>> 	Looks good to me for -next, thanks!
>>
>> Acked-by: Julian Anastasov <ja@ssi.bg>
> 
> Thanks GuoYong,
> 
> Acked-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, please consider this for nf-next at your convenience.
> 
>>
>>> ---
>>>  net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
>>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
>>> index e62b40b..494399d 100644
>>> --- a/net/netfilter/ipvs/ip_vs_ctl.c
>>> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
>>> @@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>   *	Create a destination for the given service
>>>   */
>>>  static int
>>> -ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
>>> -	       struct ip_vs_dest **dest_p)
>>> +ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
>>>  {
>>>  	struct ip_vs_dest *dest;
>>>  	unsigned int atype, i;
>>> @@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>  	spin_lock_init(&dest->stats.lock);
>>>  	__ip_vs_update_dest(svc, dest, udest, 1);
>>>  
>>> -	*dest_p = dest;
>>> -
>>>  	LeaveFunction(2);
>>>  	return 0;
>>>  
>>> @@ -1095,7 +1092,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>  		/*
>>>  		 * Allocate and initialize the dest structure
>>>  		 */
>>> -		ret = ip_vs_new_dest(svc, udest, &dest);
>>> +		ret = ip_vs_new_dest(svc, udest);
>>>  	}
>>>  	LeaveFunction(2);
>>>  
>>> -- 
>>> 1.8.3.1
>>
>> Regards
>>
>> --
>> Julian Anastasov <ja@ssi.bg>
>>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ipvs: remove unused variable for ip_vs_new_dest
@ 2021-11-18  1:09       ` zhenggy
  0 siblings, 0 replies; 7+ messages in thread
From: zhenggy @ 2021-11-18  1:09 UTC (permalink / raw)
  To: Simon Horman, Julian Anastasov, pablo
  Cc: lvs-devel, netfilter-devel, netdev, coreteam, linux-kernel

Thanks for review.

ÔÚ 2021/11/15 2:02, Simon Horman дµÀ:
> On Sat, Nov 13, 2021 at 11:56:36AM +0200, Julian Anastasov wrote:
>>
>> 	Hello,
>>
>> On Fri, 5 Nov 2021, GuoYong Zheng wrote:
>>
>>> The dest variable is not used after ip_vs_new_dest anymore in
>>> ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.
>>>
>>> Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
>>
>> 	Looks good to me for -next, thanks!
>>
>> Acked-by: Julian Anastasov <ja@ssi.bg>
> 
> Thanks GuoYong,
> 
> Acked-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, please consider this for nf-next at your convenience.
> 
>>
>>> ---
>>>  net/netfilter/ipvs/ip_vs_ctl.c | 7 ++-----
>>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
>>> index e62b40b..494399d 100644
>>> --- a/net/netfilter/ipvs/ip_vs_ctl.c
>>> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
>>> @@ -959,8 +959,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>   *	Create a destination for the given service
>>>   */
>>>  static int
>>> -ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest,
>>> -	       struct ip_vs_dest **dest_p)
>>> +ip_vs_new_dest(struct ip_vs_service *svc, struct ip_vs_dest_user_kern *udest)
>>>  {
>>>  	struct ip_vs_dest *dest;
>>>  	unsigned int atype, i;
>>> @@ -1020,8 +1019,6 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>  	spin_lock_init(&dest->stats.lock);
>>>  	__ip_vs_update_dest(svc, dest, udest, 1);
>>>  
>>> -	*dest_p = dest;
>>> -
>>>  	LeaveFunction(2);
>>>  	return 0;
>>>  
>>> @@ -1095,7 +1092,7 @@ static void ip_vs_trash_cleanup(struct netns_ipvs *ipvs)
>>>  		/*
>>>  		 * Allocate and initialize the dest structure
>>>  		 */
>>> -		ret = ip_vs_new_dest(svc, udest, &dest);
>>> +		ret = ip_vs_new_dest(svc, udest);
>>>  	}
>>>  	LeaveFunction(2);
>>>  
>>> -- 
>>> 1.8.3.1
>>
>> Regards
>>
>> --
>> Julian Anastasov <ja@ssi.bg>
>>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ipvs: remove unused variable for ip_vs_new_dest
  2021-11-14 18:02   ` Simon Horman
  2021-11-18  1:09       ` zhenggy
@ 2021-11-30 21:46     ` Pablo Neira Ayuso
  1 sibling, 0 replies; 7+ messages in thread
From: Pablo Neira Ayuso @ 2021-11-30 21:46 UTC (permalink / raw)
  To: Simon Horman
  Cc: Julian Anastasov, GuoYong Zheng, lvs-devel, netfilter-devel,
	netdev, coreteam, linux-kernel

On Sun, Nov 14, 2021 at 07:02:06PM +0100, Simon Horman wrote:
> On Sat, Nov 13, 2021 at 11:56:36AM +0200, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Fri, 5 Nov 2021, GuoYong Zheng wrote:
> > 
> > > The dest variable is not used after ip_vs_new_dest anymore in
> > > ip_vs_add_dest, do not need pass it to ip_vs_new_dest, remove it.
> > > 
> > > Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
> > 
> > 	Looks good to me for -next, thanks!
> > 
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> 
> Thanks GuoYong,
> 
> Acked-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, please consider this for nf-next at your convenience.

Applied to nf-next, thanks

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-30 21:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 11:39 [PATCH] ipvs: remove unused variable for ip_vs_new_dest GuoYong Zheng
2021-11-05 11:39 ` GuoYong Zheng
2021-11-13  9:56 ` Julian Anastasov
2021-11-14 18:02   ` Simon Horman
2021-11-18  1:09     ` zhenggy
2021-11-18  1:09       ` zhenggy
2021-11-30 21:46     ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.