All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet
@ 2021-11-15  9:43 ` Janne Grunau
  0 siblings, 0 replies; 4+ messages in thread
From: Janne Grunau @ 2021-11-15  9:43 UTC (permalink / raw)
  To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Rob Herring
  Cc: Marc Zyngier, linux-arm-kernel, devicetree, linux-kernel

Fixes make dtbs_check errors for t8103-j274.dts due to missing pci
properties.

Signed-off-by: Janne Grunau <j@jannau.net>
---8<---

change based on the same pattern as in
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts

---
 arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
index 33a80f9501dc..02c36301e985 100644
--- a/arch/arm64/boot/dts/apple/t8103-j274.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
@@ -60,7 +60,7 @@ &port01 {
 
 &port02 {
 	bus-range = <3 3>;
-	ethernet0: pci@0,0 {
+	ethernet0: ethernet@0,0 {
 		reg = <0x30000 0x0 0x0 0x0 0x0>;
 		/* To be filled by the loader */
 		local-mac-address = [00 10 18 00 00 00];
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet
@ 2021-11-15  9:43 ` Janne Grunau
  0 siblings, 0 replies; 4+ messages in thread
From: Janne Grunau @ 2021-11-15  9:43 UTC (permalink / raw)
  To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Rob Herring
  Cc: Marc Zyngier, linux-arm-kernel, devicetree, linux-kernel

Fixes make dtbs_check errors for t8103-j274.dts due to missing pci
properties.

Signed-off-by: Janne Grunau <j@jannau.net>
---8<---

change based on the same pattern as in
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts

---
 arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
index 33a80f9501dc..02c36301e985 100644
--- a/arch/arm64/boot/dts/apple/t8103-j274.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
@@ -60,7 +60,7 @@ &port01 {
 
 &port02 {
 	bus-range = <3 3>;
-	ethernet0: pci@0,0 {
+	ethernet0: ethernet@0,0 {
 		reg = <0x30000 0x0 0x0 0x0 0x0>;
 		/* To be filled by the loader */
 		local-mac-address = [00 10 18 00 00 00];
-- 
2.33.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet
  2021-11-15  9:43 ` Janne Grunau
@ 2021-11-15 11:44   ` Mark Kettenis
  -1 siblings, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2021-11-15 11:44 UTC (permalink / raw)
  To: Janne Grunau
  Cc: marcan, sven, alyssa, robh+dt, maz, linux-arm-kernel, devicetree,
	linux-kernel

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 15 Nov 2021 10:43:32 +0100
> 
> Fixes make dtbs_check errors for t8103-j274.dts due to missing pci
> properties.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>

Yes, that is better.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---8<---
> 
> change based on the same pattern as in
> arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
> 
> ---
>  arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 33a80f9501dc..02c36301e985 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -60,7 +60,7 @@ &port01 {
>  
>  &port02 {
>  	bus-range = <3 3>;
> -	ethernet0: pci@0,0 {
> +	ethernet0: ethernet@0,0 {
>  		reg = <0x30000 0x0 0x0 0x0 0x0>;
>  		/* To be filled by the loader */
>  		local-mac-address = [00 10 18 00 00 00];
> -- 
> 2.33.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet
@ 2021-11-15 11:44   ` Mark Kettenis
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2021-11-15 11:44 UTC (permalink / raw)
  To: Janne Grunau
  Cc: marcan, sven, alyssa, robh+dt, maz, linux-arm-kernel, devicetree,
	linux-kernel

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 15 Nov 2021 10:43:32 +0100
> 
> Fixes make dtbs_check errors for t8103-j274.dts due to missing pci
> properties.
> 
> Signed-off-by: Janne Grunau <j@jannau.net>

Yes, that is better.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---8<---
> 
> change based on the same pattern as in
> arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
> 
> ---
>  arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 33a80f9501dc..02c36301e985 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -60,7 +60,7 @@ &port01 {
>  
>  &port02 {
>  	bus-range = <3 3>;
> -	ethernet0: pci@0,0 {
> +	ethernet0: ethernet@0,0 {
>  		reg = <0x30000 0x0 0x0 0x0 0x0>;
>  		/* To be filled by the loader */
>  		local-mac-address = [00 10 18 00 00 00];
> -- 
> 2.33.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-15 11:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15  9:43 [PATCH 1/1] arm64: dts: apple: change ethernet0 device type to ethernet Janne Grunau
2021-11-15  9:43 ` Janne Grunau
2021-11-15 11:44 ` Mark Kettenis
2021-11-15 11:44   ` Mark Kettenis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.