[Buildroot] [PATCH v2 1/2] package/psplash: bump to revision 44afb75

[Buildroot] [PATCH v2 1/2] package/psplash: bump to revision 44afb75

[Kory Maincent]

This includes the following changes:

44afb75 Add configure options to disable progress bar
fdbd111 Improve warnings from probing for double buffering
f5203fd Update mailing list details since the move to groups.io
0a902f7 Fix psplash-systemd failures
4cf1330 Remove generated psplash-poky-img.h
aea172a Makefile.am: Fix out of tree builds

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 package/psplash/psplash.hash | 2 +-
 package/psplash/psplash.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/psplash/psplash.hash b/package/psplash/psplash.hash
index 87fcdadd6d..77090d08f6 100644
--- a/package/psplash/psplash.hash
+++ b/package/psplash/psplash.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  2c1344dd8414415d80a01484b1cc29e78f99c31d5266189540e5966a7dc6e10e  psplash-fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c-br1.tar.gz
+sha256  c9f71754f4606e46212a4851d6c1145e4ae8752fd11a2b40e825f04bf79b22ec  psplash-44afb7506d43cca15582b4c5b90ba5580344d75d-br1.tar.gz
 sha256  f9c375a1be4a41f7b70301dd83c91cb89e41567478859b77eef375a52d782505  COPYING
diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
index 199509ecd6..5e61f2392f 100644
--- a/package/psplash/psplash.mk
+++ b/package/psplash/psplash.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PSPLASH_VERSION = fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c
+PSPLASH_VERSION = 44afb7506d43cca15582b4c5b90ba5580344d75d
 PSPLASH_SITE = git://git.yoctoproject.org/psplash
 PSPLASH_LICENSE = GPL-2.0+
 PSPLASH_LICENSE_FILES = COPYING
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/2] package/psplash: add support to missing configure options

[Kory Maincent]

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup
--disable-progress-bar: Disable progress bar
--enable-img-fullscreen: Enable the logo image in fullscreen mode

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change since v1:
Remove the crap .config.in.swp

 package/psplash/Config.in  | 15 +++++++++++++++
 package/psplash/psplash.mk | 12 ++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/package/psplash/Config.in b/package/psplash/Config.in
index da99b264e0..e79e9e85c4 100644
--- a/package/psplash/Config.in
+++ b/package/psplash/Config.in
@@ -35,6 +35,21 @@ config BR2_PACKAGE_PSPLASH_IMAGE
 	  Use a personalized png image as boot splash.
 	  Let it empty if you want to keep the psplash default image.
 
+config BR2_PACKAGE_PSPLASH_FULL_SCREEN
+	bool "use fullscreen mode"
+	help
+	  Enable the psplash image in fullscreen mode.
+
+config BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG
+	bool "disable startup message"
+	help
+	  Disable text banner output on startup.
+
+config BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR
+	bool "disable progress bar"
+	help
+	  Disable the management of the progress bar.
+
 endif
 
 comment "psplash needs a toolchain w/ wchar"
diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
index 5e61f2392f..a7d36697a6 100644
--- a/package/psplash/psplash.mk
+++ b/package/psplash/psplash.mk
@@ -18,6 +18,18 @@ else
 PSPLASH_CONF_OPTS += --without-systemd
 endif
 
+ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
+PSPLASH_CONF_OPTS += --enable-img-fullscreen
+endif
+
+ifeq ($(BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG),y)
+PSPLASH_CONF_OPTS += --disable-startup-msg
+endif
+
+ifeq ($(BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR),y)
+PSPLASH_CONF_OPTS += --disable-progress-bar
+endif
+
 PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE))
 
 ifneq ($(PSPLASH_IMAGE),)
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/2] package/psplash: bump to revision 44afb75

[Thomas Petazzoni]

On Mon, 15 Nov 2021 16:26:03 +0100
Kory Maincent <kory.maincent@bootlin.com> wrote:

> This includes the following changes:
> 
> 44afb75 Add configure options to disable progress bar
> fdbd111 Improve warnings from probing for double buffering
> f5203fd Update mailing list details since the move to groups.io
> 0a902f7 Fix psplash-systemd failures
> 4cf1330 Remove generated psplash-poky-img.h
> aea172a Makefile.am: Fix out of tree builds
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>  package/psplash/psplash.hash | 2 +-
>  package/psplash/psplash.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] package/psplash: add support to missing configure options

[Thomas Petazzoni]

Hello,

On Mon, 15 Nov 2021 16:26:04 +0100
Kory Maincent <kory.maincent@bootlin.com> wrote:

> Add support to three configure options:

Here and in the commit title: "Add support *for*" (not to)

> diff --git a/package/psplash/Config.in b/package/psplash/Config.in
> index da99b264e0..e79e9e85c4 100644
> --- a/package/psplash/Config.in
> +++ b/package/psplash/Config.in
> @@ -35,6 +35,21 @@ config BR2_PACKAGE_PSPLASH_IMAGE
>  	  Use a personalized png image as boot splash.
>  	  Let it empty if you want to keep the psplash default image.
>  
> +config BR2_PACKAGE_PSPLASH_FULL_SCREEN
> +	bool "use fullscreen mode"
> +	help
> +	  Enable the psplash image in fullscreen mode.
> +
> +config BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG
> +	bool "disable startup message"
> +	help
> +	  Disable text banner output on startup.

Please use positive logic in options, i.e options should "enable"
something, not "disable" something. If the previous default (when the
option didn't exist) was to have it enabled, add a "default y" in the
Config.in option so that it remains enabled by default.

> +
> +config BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR
> +	bool "disable progress bar"
> +	help
> +	  Disable the management of the progress bar.

Same.

> +ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
> +PSPLASH_CONF_OPTS += --enable-img-fullscreen
> +endif

We like to have both sides of the condition, i.e:

ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
PSPLASH_CONF_OPTS += --enable-img-fullscreen
else
PSPLASH_CONF_OPTS += --disable-img-fullscreen
endif

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot