All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
Date: Tue, 16 Nov 2021 01:49:57 +0800	[thread overview]
Message-ID: <202111160146.zYMlqRvT-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 8820 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8ab774587903771821b59471cc723bba6d893942
commit: 1bf658eefe38cc26801b5861bbb6dbf3259ba8c1 net: dsa: sja1105: allow the frame buffer size to be customized
date:   6 months ago
:::::: branch date: 15 hours ago
:::::: commit date: 6 months ago
config: i386-randconfig-m021-20211022 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0

Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:48 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:56 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:193 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:196 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:202 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:207 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:448 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:449 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:634 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:1232 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1350 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1352 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1360 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1446 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1454 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1459 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1509 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1593 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1645 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1647 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2309 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2310 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2312 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2331 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2332 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2334 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2384 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2385 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2386 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2387 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2392 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2394 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2410 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2411 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2551 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2552 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2560 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2561 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2586 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2587 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:3113 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:3431 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?

vim +493 drivers/net/dsa/sja1105/sja1105_main.c

8aa9ebccae87621 Vladimir Oltean 2019-05-02  469  
8aa9ebccae87621 Vladimir Oltean 2019-05-02  470  static int sja1105_init_l2_forwarding_params(struct sja1105_private *priv)
8aa9ebccae87621 Vladimir Oltean 2019-05-02  471  {
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  472  	struct sja1105_l2_forwarding_params_entry *l2fwd_params;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  473  	struct sja1105_table *table;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  474  
8aa9ebccae87621 Vladimir Oltean 2019-05-02  475  	table = &priv->static_config.tables[BLK_IDX_L2_FORWARDING_PARAMS];
8aa9ebccae87621 Vladimir Oltean 2019-05-02  476  
8aa9ebccae87621 Vladimir Oltean 2019-05-02  477  	if (table->entry_count) {
8aa9ebccae87621 Vladimir Oltean 2019-05-02  478  		kfree(table->entries);
8aa9ebccae87621 Vladimir Oltean 2019-05-02  479  		table->entry_count = 0;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  480  	}
8aa9ebccae87621 Vladimir Oltean 2019-05-02  481  
fd6f2c257b0bc0c Vladimir Oltean 2021-05-24  482  	table->entries = kcalloc(table->ops->max_entry_count,
8aa9ebccae87621 Vladimir Oltean 2019-05-02  483  				 table->ops->unpacked_entry_size, GFP_KERNEL);
8aa9ebccae87621 Vladimir Oltean 2019-05-02  484  	if (!table->entries)
8aa9ebccae87621 Vladimir Oltean 2019-05-02  485  		return -ENOMEM;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  486  
fd6f2c257b0bc0c Vladimir Oltean 2021-05-24  487  	table->entry_count = table->ops->max_entry_count;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  488  
8aa9ebccae87621 Vladimir Oltean 2019-05-02  489  	/* This table only has a single entry */
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  490  	l2fwd_params = table->entries;
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  491  
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  492  	/* Disallow dynamic reconfiguration of vlan_pmap */
1bf658eefe38cc2 Vladimir Oltean 2021-05-24 @493  	l2fwd_params->max_dynp = 0;
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  494  	/* Use a single memory partition for all ingress queues */
1bf658eefe38cc2 Vladimir Oltean 2021-05-24  495  	l2fwd_params->part_spc[0] = priv->info->max_frame_mem;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  496  
8aa9ebccae87621 Vladimir Oltean 2019-05-02  497  	return 0;
8aa9ebccae87621 Vladimir Oltean 2019-05-02  498  }
8aa9ebccae87621 Vladimir Oltean 2019-05-02  499  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35716 bytes --]

             reply	other threads:[~2021-11-15 17:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 17:49 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-12-03  6:32 drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0 kernel test robot
2023-11-08  1:16 kernel test robot
2022-04-28  2:00 kernel test robot
2022-04-25 23:51 kernel test robot
2022-04-05 21:15 kernel test robot
2022-02-05 13:07 kernel test robot
2021-12-11  1:01 kernel test robot
2021-11-08 16:24 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111160146.zYMlqRvT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.