From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
Date: Sun, 3 Dec 2023 14:32:05 +0800 [thread overview]
Message-ID: <202312031206.bbZUi0iq-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 968f35f4ab1c0966ceb39af3c89f2e24afedf878
commit: 1bf658eefe38cc26801b5861bbb6dbf3259ba8c1 net: dsa: sja1105: allow the frame buffer size to be customized
date: 2 years, 6 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 2 years, 6 months ago
config: i386-randconfig-141-20231030 (https://download.01.org/0day-ci/archive/20231203/202312031206.bbZUi0iq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231203/202312031206.bbZUi0iq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312031206.bbZUi0iq-lkp@intel.com/
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:193 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:196 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:202 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:207 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:634 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
vim +493 drivers/net/dsa/sja1105/sja1105_main.c
8aa9ebccae8762 Vladimir Oltean 2019-05-02 469
8aa9ebccae8762 Vladimir Oltean 2019-05-02 470 static int sja1105_init_l2_forwarding_params(struct sja1105_private *priv)
8aa9ebccae8762 Vladimir Oltean 2019-05-02 471 {
1bf658eefe38cc Vladimir Oltean 2021-05-24 472 struct sja1105_l2_forwarding_params_entry *l2fwd_params;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 473 struct sja1105_table *table;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 474
8aa9ebccae8762 Vladimir Oltean 2019-05-02 475 table = &priv->static_config.tables[BLK_IDX_L2_FORWARDING_PARAMS];
8aa9ebccae8762 Vladimir Oltean 2019-05-02 476
8aa9ebccae8762 Vladimir Oltean 2019-05-02 477 if (table->entry_count) {
8aa9ebccae8762 Vladimir Oltean 2019-05-02 478 kfree(table->entries);
8aa9ebccae8762 Vladimir Oltean 2019-05-02 479 table->entry_count = 0;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 480 }
8aa9ebccae8762 Vladimir Oltean 2019-05-02 481
fd6f2c257b0bc0 Vladimir Oltean 2021-05-24 482 table->entries = kcalloc(table->ops->max_entry_count,
8aa9ebccae8762 Vladimir Oltean 2019-05-02 483 table->ops->unpacked_entry_size, GFP_KERNEL);
8aa9ebccae8762 Vladimir Oltean 2019-05-02 484 if (!table->entries)
8aa9ebccae8762 Vladimir Oltean 2019-05-02 485 return -ENOMEM;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 486
fd6f2c257b0bc0 Vladimir Oltean 2021-05-24 487 table->entry_count = table->ops->max_entry_count;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 488
8aa9ebccae8762 Vladimir Oltean 2019-05-02 489 /* This table only has a single entry */
1bf658eefe38cc Vladimir Oltean 2021-05-24 490 l2fwd_params = table->entries;
1bf658eefe38cc Vladimir Oltean 2021-05-24 491
1bf658eefe38cc Vladimir Oltean 2021-05-24 492 /* Disallow dynamic reconfiguration of vlan_pmap */
1bf658eefe38cc Vladimir Oltean 2021-05-24 @493 l2fwd_params->max_dynp = 0;
1bf658eefe38cc Vladimir Oltean 2021-05-24 494 /* Use a single memory partition for all ingress queues */
1bf658eefe38cc Vladimir Oltean 2021-05-24 495 l2fwd_params->part_spc[0] = priv->info->max_frame_mem;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 496
8aa9ebccae8762 Vladimir Oltean 2019-05-02 497 return 0;
8aa9ebccae8762 Vladimir Oltean 2019-05-02 498 }
8aa9ebccae8762 Vladimir Oltean 2019-05-02 499
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-12-03 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 6:32 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-08 1:16 drivers/net/dsa/sja1105/sja1105_main.c:493 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0 kernel test robot
2022-04-28 2:00 kernel test robot
2022-04-25 23:51 kernel test robot
2022-04-05 21:15 kernel test robot
2022-02-05 13:07 kernel test robot
2021-12-11 1:01 kernel test robot
2021-11-15 17:49 kernel test robot
2021-11-08 16:24 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312031206.bbZUi0iq-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.