* [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors
@ 2021-11-16 6:46 Randy Dunlap
2021-11-16 8:42 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-11-16 6:46 UTC (permalink / raw)
To: linux-kernel, Jianqun Xu, Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, Randy Dunlap, kernel test robot
gpio-rockchip uses interfaces that are provided by the Kconfig
symbol GENERIC_IRQ_CHIP, so the driver should select that symbol
in order to prevent build errors.
Fixes these build errors (and more):
aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable':
gpio-rockchip.c:(.text+0x454): undefined reference to `irq_gc_mask_set_bit'
aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable':
gpio-rockchip.c:(.text+0x478): undefined reference to `irq_gc_mask_clr_bit'
aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_interrupts_register':
gpio-rockchip.c:(.text+0x518): undefined reference to `irq_generic_chip_ops'
aarch64-linux-ld: gpio-rockchip.c:(.text+0x594): undefined reference to `__irq_alloc_domain_generic_chips'
aarch64-linux-ld: gpio-rockchip.c:(.text+0x5cc): undefined reference to `irq_get_domain_generic_chip'
aarch64-linux-ld: gpio-rockchip.c:(.text+0x5e0): undefined reference to `irq_gc_ack_set_bit'
aarch64-linux-ld: gpio-rockchip.c:(.text+0x604): undefined reference to `irq_gc_set_wake'
Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211116.orig/drivers/gpio/Kconfig
+++ linux-next-20211116/drivers/gpio/Kconfig
@@ -523,6 +523,7 @@ config GPIO_REG
config GPIO_ROCKCHIP
tristate "Rockchip GPIO support"
depends on ARCH_ROCKCHIP || COMPILE_TEST
+ select GENERIC_IRQ_CHIP
select GPIOLIB_IRQCHIP
default ARCH_ROCKCHIP
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors
2021-11-16 6:46 [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors Randy Dunlap
@ 2021-11-16 8:42 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-11-16 8:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, Jianqun Xu, Linus Walleij,
open list:GPIO SUBSYSTEM, kernel test robot
On Tue, Nov 16, 2021 at 7:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> gpio-rockchip uses interfaces that are provided by the Kconfig
> symbol GENERIC_IRQ_CHIP, so the driver should select that symbol
> in order to prevent build errors.
>
> Fixes these build errors (and more):
>
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable':
> gpio-rockchip.c:(.text+0x454): undefined reference to `irq_gc_mask_set_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable':
> gpio-rockchip.c:(.text+0x478): undefined reference to `irq_gc_mask_clr_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_interrupts_register':
> gpio-rockchip.c:(.text+0x518): undefined reference to `irq_generic_chip_ops'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x594): undefined reference to `__irq_alloc_domain_generic_chips'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5cc): undefined reference to `irq_get_domain_generic_chip'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5e0): undefined reference to `irq_gc_ack_set_bit'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x604): undefined reference to `irq_gc_set_wake'
>
> Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211116.orig/drivers/gpio/Kconfig
> +++ linux-next-20211116/drivers/gpio/Kconfig
> @@ -523,6 +523,7 @@ config GPIO_REG
> config GPIO_ROCKCHIP
> tristate "Rockchip GPIO support"
> depends on ARCH_ROCKCHIP || COMPILE_TEST
> + select GENERIC_IRQ_CHIP
> select GPIOLIB_IRQCHIP
> default ARCH_ROCKCHIP
> help
Applied for fixes, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 6:46 [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors Randy Dunlap
2021-11-16 8:42 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.