* [PATCH 1/3] ALSA: jack: Add missing rwsem around snd_ctl_remove() calls
@ 2021-11-16 7:13 Takashi Iwai
2021-11-16 7:13 ` [PATCH 2/3] ALSA: PCM: " Takashi Iwai
2021-11-16 7:13 ` [PATCH 3/3] ALSA: hda: " Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Takashi Iwai @ 2021-11-16 7:13 UTC (permalink / raw)
To: alsa-devel
snd_ctl_remove() has to be called with card->controls_rwsem held (when
called after the card instantiation). This patch add the missing
rwsem calls around it.
Fixes: 9058cbe1eed2 ("ALSA: jack: implement kctl creating for jack devices")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/core/jack.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/core/jack.c b/sound/core/jack.c
index 32350c6aba84..f50a1e920e1d 100644
--- a/sound/core/jack.c
+++ b/sound/core/jack.c
@@ -62,10 +62,13 @@ static int snd_jack_dev_free(struct snd_device *device)
struct snd_card *card = device->card;
struct snd_jack_kctl *jack_kctl, *tmp_jack_kctl;
+ down_write(&card->controls_rwsem);
list_for_each_entry_safe(jack_kctl, tmp_jack_kctl, &jack->kctl_list, list) {
list_del_init(&jack_kctl->list);
snd_ctl_remove(card, jack_kctl->kctl);
}
+ up_write(&card->controls_rwsem);
+
if (jack->private_free)
jack->private_free(jack);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] ALSA: PCM: Add missing rwsem around snd_ctl_remove() calls
2021-11-16 7:13 [PATCH 1/3] ALSA: jack: Add missing rwsem around snd_ctl_remove() calls Takashi Iwai
@ 2021-11-16 7:13 ` Takashi Iwai
2021-11-16 7:13 ` [PATCH 3/3] ALSA: hda: " Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2021-11-16 7:13 UTC (permalink / raw)
To: alsa-devel
snd_ctl_remove() has to be called with card->controls_rwsem held (when
called after the card instantiation). This patch add the missing
rwsem calls around it.
Fixes: a8ff48cb7083 ("ALSA: pcm: Free chmap at PCM free callback, too")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/core/pcm.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 6fd3677685d7..ba4a987ed1c6 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -810,7 +810,11 @@ EXPORT_SYMBOL(snd_pcm_new_internal);
static void free_chmap(struct snd_pcm_str *pstr)
{
if (pstr->chmap_kctl) {
- snd_ctl_remove(pstr->pcm->card, pstr->chmap_kctl);
+ struct snd_card *card = pstr->pcm->card;
+
+ down_write(&card->controls_rwsem);
+ snd_ctl_remove(card, pstr->chmap_kctl);
+ up_write(&card->controls_rwsem);
pstr->chmap_kctl = NULL;
}
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] ALSA: hda: Add missing rwsem around snd_ctl_remove() calls
2021-11-16 7:13 [PATCH 1/3] ALSA: jack: Add missing rwsem around snd_ctl_remove() calls Takashi Iwai
2021-11-16 7:13 ` [PATCH 2/3] ALSA: PCM: " Takashi Iwai
@ 2021-11-16 7:13 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2021-11-16 7:13 UTC (permalink / raw)
To: alsa-devel
snd_ctl_remove() has to be called with card->controls_rwsem held (when
called after the card instantiation). This patch add the missing
rwsem calls around it.
Fixes: d13bd412dce2 ("ALSA: hda - Manage kcontrol lists")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/hda_codec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 0c4a337c9fc0..eda70814369b 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -1727,8 +1727,11 @@ void snd_hda_ctls_clear(struct hda_codec *codec)
{
int i;
struct hda_nid_item *items = codec->mixers.list;
+
+ down_write(&codec->card->controls_rwsem);
for (i = 0; i < codec->mixers.used; i++)
snd_ctl_remove(codec->card, items[i].kctl);
+ up_write(&codec->card->controls_rwsem);
snd_array_free(&codec->mixers);
snd_array_free(&codec->nids);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-16 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 7:13 [PATCH 1/3] ALSA: jack: Add missing rwsem around snd_ctl_remove() calls Takashi Iwai
2021-11-16 7:13 ` [PATCH 2/3] ALSA: PCM: " Takashi Iwai
2021-11-16 7:13 ` [PATCH 3/3] ALSA: hda: " Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.