From: Pingfan Liu <kernelfans@gmail.com> To: linux-arm-kernel@lists.infradead.org Cc: Pingfan Liu <kernelfans@gmail.com>, Mark Rutland <mark.rutland@arm.com>, "Paul E . McKenney" <paulmck@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Julien Thierry <julien.thierry@arm.com>, Yuichi Ito <ito-yuichi@fujitsu.com>, rcu@vger.kernel.org Subject: [PATCHv3 0/4] arm64: Fixes RCU deadlock due to a mistaken Date: Tue, 16 Nov 2021 16:24:46 +0800 [thread overview] Message-ID: <20211116082450.10357-1-kernelfans@gmail.com> (raw) It was [PATCHv2 1/5] arm64/entry-common: push the judgement of nmi ahead [1], but as discussion, I found it hit a deadlock, so change subject in v3. Linux kernel places strict semantics between NMI and maskable interrupt. So does the RCU component, else deadlock may happen. The current arm64 entry code can partially breach this rule through calling rcu_nmi_enter() in pNMI conext without calling __nmi_enter(). Finally, it calls __rcu_irq_enter_check_tick() trying to hold raw_spin_lock_rcu_node(rdp->mynode), but this spinlock can already been held by a task running note_gp_changes()->raw_spin_trylock_rcu_node(rnp). Then deadlock happens. The organization of this series: [1/4] aims to fix this bug [2-3/4] ease the implementation of [1/4] [4/4] is a cleanup To do: Does arm need to handle pNMI as arm64? v2 -> v3: drop handle_arch_nmi interface [1]: https://lore.kernel.org/linux-arm-kernel/20210924132837.45994-2-kernelfans@gmail.com/ Cc: Mark Rutland <mark.rutland@arm.com> Cc: Paul E. McKenney <paulmck@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Marc Zyngier <maz@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Joey Gouly <joey.gouly@arm.com> Cc: Sami Tolvanen <samitolvanen@google.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Yuichi Ito <ito-yuichi@fujitsu.com> Cc: rcu@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Pingfan Liu (4): arm64: entry: judge nmi ealier to avoid deadlock in RCU arm64: entry: distinguish pNMI earlier in el0 interrupt irqchip: GICv3: expose pNMI discriminator arm64: entry: remove pNMI judgement in __el1_interrupt() path arch/arm64/kernel/entry-common.c | 55 +++++++++++++++++++++----------- arch/arm64/kernel/irq.c | 15 +++++++++ drivers/irqchip/irq-gic-v3.c | 16 ++++++---- 3 files changed, 62 insertions(+), 24 deletions(-) -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Pingfan Liu <kernelfans@gmail.com> To: linux-arm-kernel@lists.infradead.org Cc: Pingfan Liu <kernelfans@gmail.com>, Mark Rutland <mark.rutland@arm.com>, "Paul E . McKenney" <paulmck@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Joey Gouly <joey.gouly@arm.com>, Sami Tolvanen <samitolvanen@google.com>, Julien Thierry <julien.thierry@arm.com>, Yuichi Ito <ito-yuichi@fujitsu.com>, rcu@vger.kernel.org Subject: [PATCHv3 0/4] arm64: Fixes RCU deadlock due to a mistaken Date: Tue, 16 Nov 2021 16:24:46 +0800 [thread overview] Message-ID: <20211116082450.10357-1-kernelfans@gmail.com> (raw) It was [PATCHv2 1/5] arm64/entry-common: push the judgement of nmi ahead [1], but as discussion, I found it hit a deadlock, so change subject in v3. Linux kernel places strict semantics between NMI and maskable interrupt. So does the RCU component, else deadlock may happen. The current arm64 entry code can partially breach this rule through calling rcu_nmi_enter() in pNMI conext without calling __nmi_enter(). Finally, it calls __rcu_irq_enter_check_tick() trying to hold raw_spin_lock_rcu_node(rdp->mynode), but this spinlock can already been held by a task running note_gp_changes()->raw_spin_trylock_rcu_node(rnp). Then deadlock happens. The organization of this series: [1/4] aims to fix this bug [2-3/4] ease the implementation of [1/4] [4/4] is a cleanup To do: Does arm need to handle pNMI as arm64? v2 -> v3: drop handle_arch_nmi interface [1]: https://lore.kernel.org/linux-arm-kernel/20210924132837.45994-2-kernelfans@gmail.com/ Cc: Mark Rutland <mark.rutland@arm.com> Cc: Paul E. McKenney <paulmck@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Marc Zyngier <maz@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Joey Gouly <joey.gouly@arm.com> Cc: Sami Tolvanen <samitolvanen@google.com> Cc: Julien Thierry <julien.thierry@arm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Yuichi Ito <ito-yuichi@fujitsu.com> Cc: rcu@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Pingfan Liu (4): arm64: entry: judge nmi ealier to avoid deadlock in RCU arm64: entry: distinguish pNMI earlier in el0 interrupt irqchip: GICv3: expose pNMI discriminator arm64: entry: remove pNMI judgement in __el1_interrupt() path arch/arm64/kernel/entry-common.c | 55 +++++++++++++++++++++----------- arch/arm64/kernel/irq.c | 15 +++++++++ drivers/irqchip/irq-gic-v3.c | 16 ++++++---- 3 files changed, 62 insertions(+), 24 deletions(-) -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-11-16 8:25 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-16 8:24 Pingfan Liu [this message] 2021-11-16 8:24 ` [PATCHv3 0/4] arm64: Fixes RCU deadlock due to a mistaken Pingfan Liu 2021-11-16 8:24 ` [PATCHv3 1/4] arm64: entry: judge nmi ealier to avoid deadlock in RCU Pingfan Liu 2021-11-16 8:24 ` Pingfan Liu 2021-11-17 11:38 ` Mark Rutland 2021-11-17 11:38 ` Mark Rutland 2021-11-19 2:01 ` Pingfan Liu 2021-11-19 2:01 ` Pingfan Liu 2021-11-19 14:04 ` Mark Rutland 2021-11-19 14:04 ` Mark Rutland 2021-11-16 8:24 ` [PATCHv3 2/4] arm64: entry: distinguish pNMI earlier in el0 interrupt Pingfan Liu 2021-11-16 8:24 ` Pingfan Liu 2021-11-16 8:24 ` [PATCHv3 3/4] irqchip: GICv3: expose pNMI discriminator Pingfan Liu 2021-11-16 8:24 ` Pingfan Liu 2021-11-16 9:53 ` Marc Zyngier 2021-11-16 9:53 ` Marc Zyngier 2021-11-17 10:16 ` Pingfan Liu 2021-11-17 10:16 ` Pingfan Liu 2021-11-17 11:01 ` Marc Zyngier 2021-11-17 11:01 ` Marc Zyngier 2021-11-19 2:38 ` Pingfan Liu 2021-11-19 2:38 ` Pingfan Liu 2021-11-16 8:24 ` [PATCHv3 4/4] arm64: entry: remove pNMI judgement in __el1_interrupt() path Pingfan Liu 2021-11-16 8:24 ` Pingfan Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211116082450.10357-1-kernelfans@gmail.com \ --to=kernelfans@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=ito-yuichi@fujitsu.com \ --cc=joey.gouly@arm.com \ --cc=julien.thierry@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=paulmck@kernel.org \ --cc=rcu@vger.kernel.org \ --cc=samitolvanen@google.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.