* [PATCH-for-7.0] target/i386/kvm: Replace use of __u32 type
@ 2021-11-16 19:39 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-16 19:39 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Marcelo Tosatti,
Philippe Mathieu-Daudé,
kvm
QEMU coding style mandates to not use Linux kernel internal
types for scalars types. Replace __u32 by uint32_t.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/i386/kvm/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 5a698bde19a..13f8e30c2a5 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
c->edx = cpu->hyperv_limits[2];
if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
- __u32 function;
+ uint32_t function;
/* Create zeroed 0x40000006..0x40000009 leaves */
for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH-for-7.0] target/i386/kvm: Replace use of __u32 type
2021-11-16 19:39 ` Philippe Mathieu-Daudé
(?)
@ 2021-11-16 20:19 ` Richard Henderson
-1 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2021-11-16 20:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Marcelo Tosatti, kvm
On 11/16/21 8:39 PM, Philippe Mathieu-Daudé wrote:
> QEMU coding style mandates to not use Linux kernel internal
> types for scalars types. Replace __u32 by uint32_t.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@redhat.com>
> ---
> target/i386/kvm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH-for-7.0] target/i386/kvm: Replace use of __u32 type
2021-11-16 19:39 ` Philippe Mathieu-Daudé
@ 2021-12-15 10:36 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-15 10:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Marcelo Tosatti, Paolo Bonzini, kvm, qemu-trivial
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/16/21 20:39, Philippe Mathieu-Daudé wrote:
> QEMU coding style mandates to not use Linux kernel internal
> types for scalars types. Replace __u32 by uint32_t.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/i386/kvm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index 5a698bde19a..13f8e30c2a5 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
> c->edx = cpu->hyperv_limits[2];
>
> if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
> - __u32 function;
> + uint32_t function;
>
> /* Create zeroed 0x40000006..0x40000009 leaves */
> for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH-for-7.0] target/i386/kvm: Replace use of __u32 type
@ 2021-12-15 10:36 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-15 10:36 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Marcelo Tosatti, kvm
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/16/21 20:39, Philippe Mathieu-Daudé wrote:
> QEMU coding style mandates to not use Linux kernel internal
> types for scalars types. Replace __u32 by uint32_t.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/i386/kvm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index 5a698bde19a..13f8e30c2a5 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
> c->edx = cpu->hyperv_limits[2];
>
> if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
> - __u32 function;
> + uint32_t function;
>
> /* Create zeroed 0x40000006..0x40000009 leaves */
> for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH-for-7.0] target/i386/kvm: Replace use of __u32 type
2021-11-16 19:39 ` Philippe Mathieu-Daudé
` (2 preceding siblings ...)
(?)
@ 2021-12-17 9:41 ` Laurent Vivier
-1 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2021-12-17 9:41 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Marcelo Tosatti, kvm
Le 16/11/2021 à 20:39, Philippe Mathieu-Daudé a écrit :
> QEMU coding style mandates to not use Linux kernel internal
> types for scalars types. Replace __u32 by uint32_t.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/i386/kvm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index 5a698bde19a..13f8e30c2a5 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1406,7 +1406,7 @@ static int hyperv_fill_cpuids(CPUState *cs,
> c->edx = cpu->hyperv_limits[2];
>
> if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) {
> - __u32 function;
> + uint32_t function;
>
> /* Create zeroed 0x40000006..0x40000009 leaves */
> for (function = HV_CPUID_IMPLEMENT_LIMITS + 1;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread