* [PATCH] ARM: dts: nuvoton: Fix FIU reg definition
@ 2021-11-17 1:25 ` William A. Kennington III
0 siblings, 0 replies; 2+ messages in thread
From: William A. Kennington III @ 2021-11-17 1:25 UTC (permalink / raw)
To: robh+dt, mark.rutland, avifishman70, tali.perry1
Cc: joel, openbmc, linux-kernel, devicetree, William A. Kennington III
The current definitions have a reg-name for "memory", but no
corresponding reg space defined. These values were taken from the
NPCM7xx documentation and tested on real hardware.
Without this definition, the FIU driver does not take advantage of
direct read support.
Signed-off-by: William A. Kennington III <wak@google.com>
---
arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
index aca0e0e390d8..c164ec9fc96f 100644
--- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
@@ -181,7 +181,7 @@ fiu0: spi@fb000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb000000 0x1000>;
+ reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI0>;
clock-names = "clk_spi0";
@@ -192,7 +192,7 @@ fiu3: spi@c0000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xc0000000 0x1000>;
+ reg = <0xc0000000 0x1000>, <0xa0000000 0x20000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI3>;
clock-names = "clk_spi3";
@@ -265,7 +265,7 @@ fiux: spi@fb001000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb001000 0x1000>;
+ reg = <0xfb001000 0x1000>, <0xf8000000 0x2000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPIX>;
clock-names = "clk_spix";
--
2.34.0.rc1.387.gb447b232ab-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: dts: nuvoton: Fix FIU reg definition
@ 2021-11-17 1:25 ` William A. Kennington III
0 siblings, 0 replies; 2+ messages in thread
From: William A. Kennington III @ 2021-11-17 1:25 UTC (permalink / raw)
To: robh+dt, mark.rutland, avifishman70, tali.perry1
Cc: devicetree, openbmc, William A. Kennington III, linux-kernel
The current definitions have a reg-name for "memory", but no
corresponding reg space defined. These values were taken from the
NPCM7xx documentation and tested on real hardware.
Without this definition, the FIU driver does not take advantage of
direct read support.
Signed-off-by: William A. Kennington III <wak@google.com>
---
arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
index aca0e0e390d8..c164ec9fc96f 100644
--- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
@@ -181,7 +181,7 @@ fiu0: spi@fb000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb000000 0x1000>;
+ reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI0>;
clock-names = "clk_spi0";
@@ -192,7 +192,7 @@ fiu3: spi@c0000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xc0000000 0x1000>;
+ reg = <0xc0000000 0x1000>, <0xa0000000 0x20000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI3>;
clock-names = "clk_spi3";
@@ -265,7 +265,7 @@ fiux: spi@fb001000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb001000 0x1000>;
+ reg = <0xfb001000 0x1000>, <0xf8000000 0x2000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPIX>;
clock-names = "clk_spix";
--
2.34.0.rc1.387.gb447b232ab-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 1:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 1:25 [PATCH] ARM: dts: nuvoton: Fix FIU reg definition William A. Kennington III
2021-11-17 1:25 ` William A. Kennington III
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.