* [RFC PATCH] plugins/meson.build: fix linker issue with weird paths
@ 2021-11-17 11:19 Alex Bennée
2021-11-17 19:39 ` [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (for v6.2?) Stefan Weil
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2021-11-17 11:19 UTC (permalink / raw)
To: qemu-devel; +Cc: sw, Mahmoud Mandour, Alex Bennée, Alexandre Iooss
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712
---
plugins/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/meson.build b/plugins/meson.build
index aeb386ebae..b3de57853b 100644
--- a/plugins/meson.build
+++ b/plugins/meson.build
@@ -2,9 +2,9 @@ plugin_ldflags = []
# Modules need more symbols than just those in plugins/qemu-plugins.symbols
if not enable_modules
if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host
- plugin_ldflags = ['-Wl,--dynamic-list=' + (meson.project_build_root() / 'qemu-plugins-ld.symbols')]
+ plugin_ldflags = ['-Wl,--dynamic-list=qemu-plugins-ld.symbols']
elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host
- plugin_ldflags = ['-Wl,-exported_symbols_list,' + (meson.project_build_root() / 'qemu-plugins-ld64.symbols')]
+ plugin_ldflags = ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symbols']
endif
endif
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (for v6.2?)
2021-11-17 11:19 [RFC PATCH] plugins/meson.build: fix linker issue with weird paths Alex Bennée
@ 2021-11-17 19:39 ` Stefan Weil
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2021-11-17 19:39 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Alexandre Iooss, Mahmoud Mandour
Am 17.11.21 um 12:19 schrieb Alex Bennée:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712
> ---
> plugins/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thank you. The fix works for me and looks fine.
meson.project_build_root() was only used there, so hopefully no other
code was affected.
I tested builds on Debian GNU Linux x86_64 bullseye and latest MacOS and
would appreciate if the fix could be applied for release 6.2.
Tested-by: Stefan Weil <sw@weilnetz.de>
>
> diff --git a/plugins/meson.build b/plugins/meson.build
> index aeb386ebae..b3de57853b 100644
> --- a/plugins/meson.build
> +++ b/plugins/meson.build
> @@ -2,9 +2,9 @@ plugin_ldflags = []
> # Modules need more symbols than just those in plugins/qemu-plugins.symbols
> if not enable_modules
> if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host
> - plugin_ldflags = ['-Wl,--dynamic-list=' + (meson.project_build_root() / 'qemu-plugins-ld.symbols')]
> + plugin_ldflags = ['-Wl,--dynamic-list=qemu-plugins-ld.symbols']
> elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host
> - plugin_ldflags = ['-Wl,-exported_symbols_list,' + (meson.project_build_root() / 'qemu-plugins-ld64.symbols')]
> + plugin_ldflags = ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symbols']
> endif
> endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 11:19 [RFC PATCH] plugins/meson.build: fix linker issue with weird paths Alex Bennée
2021-11-17 19:39 ` [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (for v6.2?) Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.