[PATCH] mpt3sas: Fix incorrect system timestamp showed in IOC FW

[PATCH] mpt3sas: Fix incorrect system timestamp showed in IOC FW

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

For updating the IOC Fimrware's timestamp with
system timestamp, driver issues the Mpi26IoUnitControlRequest
message. While framing the Mpi26IoUnitControlRequest
driver should copy the current timestamp value's lower 32 bits in
IOCParameterValue field and higher 32 bits in Reserved7 field.

Fixes: f98790c00375("mpt3sas: Sync time periodically between driver and firmware")
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 27eb652b564f..81dab9b82f79 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -639,8 +639,8 @@ static void _base_sync_drv_fw_timestamp(struct MPT3SAS_ADAPTER *ioc)
 	mpi_request->IOCParameter = MPI26_SET_IOC_PARAMETER_SYNC_TIMESTAMP;
 	current_time = ktime_get_real();
 	TimeStamp = ktime_to_ms(current_time);
-	mpi_request->Reserved7 = cpu_to_le32(TimeStamp & 0xFFFFFFFF);
-	mpi_request->IOCParameterValue = cpu_to_le32(TimeStamp >> 32);
+	mpi_request->Reserved7 = cpu_to_le32(TimeStamp >> 32);
+	mpi_request->IOCParameterValue = cpu_to_le32(TimeStamp & 0xFFFFFFFF);
 	init_completion(&ioc->scsih_cmds.done);
 	ioc->put_smid_default(ioc, smid);
 	dinitprintk(ioc, ioc_info(ioc,
-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH] mpt3sas: Fix incorrect system timestamp showed in IOC FW

[Martin K. Petersen]

On Wed, 17 Nov 2021 18:02:15 +0530, Sreekanth Reddy wrote:

> For updating the IOC Fimrware's timestamp with
> system timestamp, driver issues the Mpi26IoUnitControlRequest
> message. While framing the Mpi26IoUnitControlRequest
> driver should copy the current timestamp value's lower 32 bits in
> IOCParameterValue field and higher 32 bits in Reserved7 field.
> 
> 
> [...]

Applied to 5.16/scsi-fixes, thanks!

[1/1] mpt3sas: Fix incorrect system timestamp showed in IOC FW
      https://git.kernel.org/mkp/scsi/c/5ecae9f8c705

-- 
Martin K. Petersen	Oracle Linux Engineering