* [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()
@ 2021-11-17 17:43 Philippe Mathieu-Daudé
2021-11-18 10:46 ` Darren Kenny
2021-11-18 10:55 ` Sergio Lopez
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-17 17:43 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Sergio Lopez, Michael S. Tsirkin,
Richard Henderson, Gerd Hoffmann, Paolo Bonzini,
Philippe Mathieu-Daudé
Fixes: f5918a99283 ("microvm: add device tree support.")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/microvm-dt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
index 875ba919639..6ee6c42904d 100644
--- a/hw/i386/microvm-dt.c
+++ b/hw/i386/microvm-dt.c
@@ -327,7 +327,9 @@ void dt_setup_microvm(MicrovmMachineState *mms)
dt_setup_sys_bus(mms);
/* add to fw_cfg */
- fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
+ if (debug) {
+ fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
+ }
fw_cfg_add_file(x86ms->fw_cfg, "etc/fdt", mms->fdt, size);
if (debug) {
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()
2021-11-17 17:43 [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm() Philippe Mathieu-Daudé
@ 2021-11-18 10:46 ` Darren Kenny
2021-11-18 10:55 ` Sergio Lopez
1 sibling, 0 replies; 3+ messages in thread
From: Darren Kenny @ 2021-11-18 10:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Sergio Lopez, Michael S. Tsirkin,
Richard Henderson, Gerd Hoffmann, Paolo Bonzini,
Philippe Mathieu-Daudé
On Wednesday, 2021-11-17 at 18:43:31 +01, Philippe Mathieu-Daudé wrote:
> Fixes: f5918a99283 ("microvm: add device tree support.")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> ---
> hw/i386/microvm-dt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
> index 875ba919639..6ee6c42904d 100644
> --- a/hw/i386/microvm-dt.c
> +++ b/hw/i386/microvm-dt.c
> @@ -327,7 +327,9 @@ void dt_setup_microvm(MicrovmMachineState *mms)
> dt_setup_sys_bus(mms);
>
> /* add to fw_cfg */
> - fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
> + if (debug) {
> + fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
> + }
> fw_cfg_add_file(x86ms->fw_cfg, "etc/fdt", mms->fdt, size);
>
> if (debug) {
> --
> 2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()
2021-11-17 17:43 [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm() Philippe Mathieu-Daudé
2021-11-18 10:46 ` Darren Kenny
@ 2021-11-18 10:55 ` Sergio Lopez
1 sibling, 0 replies; 3+ messages in thread
From: Sergio Lopez @ 2021-11-18 10:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, Richard Henderson,
qemu-devel, Gerd Hoffmann, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Wed, Nov 17, 2021 at 06:43:31PM +0100, Philippe Mathieu-Daudé wrote:
> Fixes: f5918a99283 ("microvm: add device tree support.")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/microvm-dt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Sergio Lopez <slp@redhat.com>
> diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
> index 875ba919639..6ee6c42904d 100644
> --- a/hw/i386/microvm-dt.c
> +++ b/hw/i386/microvm-dt.c
> @@ -327,7 +327,9 @@ void dt_setup_microvm(MicrovmMachineState *mms)
> dt_setup_sys_bus(mms);
>
> /* add to fw_cfg */
> - fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
> + if (debug) {
> + fprintf(stderr, "%s: add etc/fdt to fw_cfg\n", __func__);
> + }
> fw_cfg_add_file(x86ms->fw_cfg, "etc/fdt", mms->fdt, size);
>
> if (debug) {
> --
> 2.31.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-18 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 17:43 [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm() Philippe Mathieu-Daudé
2021-11-18 10:46 ` Darren Kenny
2021-11-18 10:55 ` Sergio Lopez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.