All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH 1/4] freerdp: Upgrade 2.3.0 -> 2.4.1
@ 2021-11-18 17:51 Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 2/4] freerdp: Add missing libusb1 dependency Marek Vasut
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 17:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: raj.khem, Marek Vasut, Alexander Kanavin

Upgrade freerdp to latest stable 2.x version and drop
OpenSSL 3.x backports which are already upstream.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexander Kanavin <alex@linutronix.de>
Cc: Khem Raj <raj.khem@gmail.com>
---
 ...e-support-and-build-with-OpenSSL-3.0.patch | 43 -------------------
 ...d-calling-FIPS_mode-with-OpenSSL-3.0.patch | 28 ------------
 .../{freerdp_2.3.0.bb => freerdp_2.4.1.bb}    |  4 +-
 3 files changed, 1 insertion(+), 74 deletions(-)
 delete mode 100644 meta-oe/recipes-support/freerdp/freerdp/0001-Fix-FIPS-mode-support-and-build-with-OpenSSL-3.0.patch
 delete mode 100644 meta-oe/recipes-support/freerdp/freerdp/0002-winpr-avoid-calling-FIPS_mode-with-OpenSSL-3.0.patch
 rename meta-oe/recipes-support/freerdp/{freerdp_2.3.0.bb => freerdp_2.4.1.bb} (94%)

diff --git a/meta-oe/recipes-support/freerdp/freerdp/0001-Fix-FIPS-mode-support-and-build-with-OpenSSL-3.0.patch b/meta-oe/recipes-support/freerdp/freerdp/0001-Fix-FIPS-mode-support-and-build-with-OpenSSL-3.0.patch
deleted file mode 100644
index 04fe644d4..000000000
--- a/meta-oe/recipes-support/freerdp/freerdp/0001-Fix-FIPS-mode-support-and-build-with-OpenSSL-3.0.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From f703b1184229796d504a2e833f72ace4cc605d15 Mon Sep 17 00:00:00 2001
-From: Ondrej Holy <oholy@redhat.com>
-Date: Wed, 12 May 2021 12:48:15 +0200
-Subject: [PATCH 1/2] Fix FIPS mode support and build with OpenSSL 3.0
-
-FreeRDP fails to build with OpenSSL 3.0 because of usage of the `FIPS_mode`
-and `FIPS_mode_set` functions, which were removed there. Just a note that
-the FIPS mode is not supported by OpenSSL 1.1.* although the mentioned
-functions are still there (see https://wiki.openssl.org/index.php/FIPS_modules).
-Let's make FreeRDP build with OpenSSL 3.0 and fix the FIPS mode support.
-
-See: https://bugzilla.redhat.com/show_bug.cgi?id=1952937
-Upstream-Status: Backport
-Signed-off-by: Alexander Kanavin <alex@linutronix.de>
----
- winpr/libwinpr/utils/ssl.c | 8 ++++++++
- 1 file changed, 8 insertions(+)
-
-diff --git a/winpr/libwinpr/utils/ssl.c b/winpr/libwinpr/utils/ssl.c
-index 3a8590390..03b23af43 100644
---- a/winpr/libwinpr/utils/ssl.c
-+++ b/winpr/libwinpr/utils/ssl.c
-@@ -244,9 +244,17 @@ static BOOL winpr_enable_fips(DWORD flags)
- #else
- 		WLog_DBG(TAG, "Ensuring openssl fips mode is ENabled");
- 
-+#if defined(OPENSSL_VERSION_MAJOR) && (OPENSSL_VERSION_MAJOR >= 3)
-+		if (!EVP_default_properties_is_fips_enabled(NULL))
-+#else
- 		if (FIPS_mode() != 1)
-+#endif
- 		{
-+#if defined(OPENSSL_VERSION_MAJOR) && (OPENSSL_VERSION_MAJOR >= 3)
-+			if (EVP_set_default_properties(NULL, "fips=yes"))
-+#else
- 			if (FIPS_mode_set(1))
-+#endif
- 				WLog_INFO(TAG, "Openssl fips mode ENabled!");
- 			else
- 			{
--- 
-2.20.1
-
diff --git a/meta-oe/recipes-support/freerdp/freerdp/0002-winpr-avoid-calling-FIPS_mode-with-OpenSSL-3.0.patch b/meta-oe/recipes-support/freerdp/freerdp/0002-winpr-avoid-calling-FIPS_mode-with-OpenSSL-3.0.patch
deleted file mode 100644
index 728638e15..000000000
--- a/meta-oe/recipes-support/freerdp/freerdp/0002-winpr-avoid-calling-FIPS_mode-with-OpenSSL-3.0.patch
+++ /dev/null
@@ -1,28 +0,0 @@
-From 4dbf108c0ae5e997d5c432f3da4b4c5fd7b35373 Mon Sep 17 00:00:00 2001
-From: Mike Gilbert <floppym@gentoo.org>
-Date: Sun, 1 Aug 2021 12:14:43 -0400
-Subject: [PATCH 2/2] winpr: avoid calling FIPS_mode() with OpenSSL 3.0
-
-Fixes: 26bf2816c3e0daeaf524c47cf0fcda8ae13b65ad
-Upstream-Status: Backport
-Signed-off-by: Alexander Kanavin <alex@linutronix.de>
----
- winpr/libwinpr/utils/ssl.c | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/winpr/libwinpr/utils/ssl.c b/winpr/libwinpr/utils/ssl.c
-index 03b23af43..74ef156e7 100644
---- a/winpr/libwinpr/utils/ssl.c
-+++ b/winpr/libwinpr/utils/ssl.c
-@@ -364,6 +364,8 @@ BOOL winpr_FIPSMode(void)
- {
- #if (OPENSSL_VERSION_NUMBER < 0x10001000L) || defined(LIBRESSL_VERSION_NUMBER)
- 	return FALSE;
-+#elif defined(OPENSSL_VERSION_MAJOR) && (OPENSSL_VERSION_MAJOR >= 3)
-+	return (EVP_default_properties_is_fips_enabled(NULL) == 1);
- #else
- 	return (FIPS_mode() == 1);
- #endif
--- 
-2.20.1
-
diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.3.0.bb b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
similarity index 94%
rename from meta-oe/recipes-support/freerdp/freerdp_2.3.0.bb
rename to meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
index 6f9dc780b..6582b2e7d 100644
--- a/meta-oe/recipes-support/freerdp/freerdp_2.3.0.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
@@ -13,11 +13,9 @@ inherit pkgconfig cmake gitpkgv
 PE = "1"
 PKGV = "${GITPKGVTAG}"
 
-SRCREV = "14c7f7aed7dd4e2454ee0cd81028b9f790885021"
+SRCREV = "d39a7ba5c38e3ba3b99b1558dc2ab0970cbfb0c5"
 SRC_URI = "git://github.com/FreeRDP/FreeRDP.git;branch=stable-2.0;protocol=https \
     file://winpr-makecert-Build-with-install-RPATH.patch \
-    file://0001-Fix-FIPS-mode-support-and-build-with-OpenSSL-3.0.patch \
-    file://0002-winpr-avoid-calling-FIPS_mode-with-OpenSSL-3.0.patch \
 "
 
 S = "${WORKDIR}/git"
-- 
2.33.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [meta-oe][PATCH 2/4] freerdp: Add missing libusb1 dependency
  2021-11-18 17:51 [meta-oe][PATCH 1/4] freerdp: Upgrade 2.3.0 -> 2.4.1 Marek Vasut
@ 2021-11-18 17:51 ` Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 3/4] freerdp: Make PCSC dependency optional Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve Marek Vasut
  2 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 17:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: raj.khem, Marek Vasut, Alexander Kanavin

The freerdp does depend on libusb1 for rdpdr device forwarding.
This missing dependency is currently hidden, since it is pulled
in by pcsc-lite, but if the later is removed from DEPENDS, the
build fails. Add the missing dependency.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexander Kanavin <alex@linutronix.de>
Cc: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
index 6582b2e7d..d2851a602 100644
--- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
@@ -3,7 +3,7 @@
 
 DESCRIPTION = "FreeRDP RDP client & server library"
 HOMEPAGE = "http://www.freerdp.com"
-DEPENDS = "openssl alsa-lib pcsc-lite"
+DEPENDS = "openssl alsa-lib pcsc-lite libusb1"
 SECTION = "net"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
-- 
2.33.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [meta-oe][PATCH 3/4] freerdp: Make PCSC dependency optional
  2021-11-18 17:51 [meta-oe][PATCH 1/4] freerdp: Upgrade 2.3.0 -> 2.4.1 Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 2/4] freerdp: Add missing libusb1 dependency Marek Vasut
@ 2021-11-18 17:51 ` Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve Marek Vasut
  2 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 17:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: raj.khem, Marek Vasut, Alexander Kanavin

The PCSC is used for smartcard forwarding, make this optional as
not all users need this functionality and it pulls in considerable
amount of dependencies. Keep this enabled by default to retain
backward compatibility.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexander Kanavin <alex@linutronix.de>
Cc: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
index d2851a602..aba77e20f 100644
--- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
@@ -3,7 +3,7 @@
 
 DESCRIPTION = "FreeRDP RDP client & server library"
 HOMEPAGE = "http://www.freerdp.com"
-DEPENDS = "openssl alsa-lib pcsc-lite libusb1"
+DEPENDS = "openssl alsa-lib libusb1"
 SECTION = "net"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
@@ -22,7 +22,6 @@ S = "${WORKDIR}/git"
 
 EXTRA_OECMAKE += " \
     -DWITH_ALSA=ON \
-    -DWITH_PCSC=ON \
     -DWITH_FFMPEG=OFF \
     -DWITH_CUNIT=OFF \
     -DWITH_NEON=OFF \
@@ -33,7 +32,7 @@ EXTRA_OECMAKE += " \
 
 PACKAGECONFIG ??= " \
     ${@bb.utils.filter('DISTRO_FEATURES', 'directfb pam pulseaudio wayland x11', d)}\
-    gstreamer cups \
+    gstreamer cups pcsc \
 "
 
 X11_DEPS = "virtual/libx11 libxinerama libxext libxcursor libxv libxi libxrender libxfixes libxdamage libxrandr libxkbfile"
@@ -41,6 +40,7 @@ PACKAGECONFIG[x11] = "-DWITH_X11=ON -DWITH_XINERAMA=ON -DWITH_XEXT=ON -DWITH_XCU
 PACKAGECONFIG[wayland] = "-DWITH_WAYLAND=ON,-DWITH_WAYLAND=OFF,wayland wayland-native libxkbcommon"
 PACKAGECONFIG[directfb] = "-DWITH_DIRECTFB=ON,-DWITH_DIRECTFB=OFF,directfb"
 PACKAGECONFIG[pam] = "-DWITH_PAM=ON,-DWITH_PAM=OFF,libpam"
+PACKAGECONFIG[pcsc] = "-DWITH_PCSC=ON,-DWITH_PCSC=OFF,pcsc-lite"
 PACKAGECONFIG[pulseaudio] = "-DWITH_PULSEAUDIO=ON,-DWITH_PULSEAUDIO=OFF,pulseaudio"
 PACKAGECONFIG[gstreamer] = "-DWITH_GSTREAMER_1_0=ON,-DWITH_GSTREAMER_1_0=OFF,gstreamer1.0 gstreamer1.0-plugins-base"
 PACKAGECONFIG[cups] = "-DWITH_CUPS=ON,-DWITH_CUPS=OFF,cups"
-- 
2.33.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve
  2021-11-18 17:51 [meta-oe][PATCH 1/4] freerdp: Upgrade 2.3.0 -> 2.4.1 Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 2/4] freerdp: Add missing libusb1 dependency Marek Vasut
  2021-11-18 17:51 ` [meta-oe][PATCH 3/4] freerdp: Make PCSC dependency optional Marek Vasut
@ 2021-11-18 17:51 ` Marek Vasut
  2021-11-18 19:03   ` Khem Raj
  2 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 17:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: raj.khem, Marek Vasut, Alexander Kanavin

Enable NEON SIMD on armv7a and armv7ve, this does improve performance
on these systems. Aarch64 NEON SIMD is available only in FreeRDP 3.x,
so do not enable NEON on aarch64 just yet.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexander Kanavin <alex@linutronix.de>
Cc: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
index aba77e20f..571ba5fcb 100644
--- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
@@ -30,6 +30,10 @@ EXTRA_OECMAKE += " \
     -DWITH_MANPAGES=OFF \
 "
 
+EXTRA_OECMAKE:append:armv7a = " -DWITH_NEON=ON"
+EXTRA_OECMAKE:append:armv7ve = " -DWITH_NEON=ON"
+# ARMv8a NEON support is available only in FreeRDP 3.x
+
 PACKAGECONFIG ??= " \
     ${@bb.utils.filter('DISTRO_FEATURES', 'directfb pam pulseaudio wayland x11', d)}\
     gstreamer cups pcsc \
-- 
2.33.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve
  2021-11-18 17:51 ` [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve Marek Vasut
@ 2021-11-18 19:03   ` Khem Raj
  2021-11-18 19:11     ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2021-11-18 19:03 UTC (permalink / raw)
  To: Marek Vasut, openembedded-devel; +Cc: Alexander Kanavin



On 11/18/21 9:51 AM, Marek Vasut wrote:
> Enable NEON SIMD on armv7a and armv7ve, this does improve performance
> on these systems. Aarch64 NEON SIMD is available only in FreeRDP 3.x,
> so do not enable NEON on aarch64 just yet.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexander Kanavin <alex@linutronix.de>
> Cc: Khem Raj <raj.khem@gmail.com>
> ---
>   meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
> index aba77e20f..571ba5fcb 100644
> --- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
> +++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
> @@ -30,6 +30,10 @@ EXTRA_OECMAKE += " \
>       -DWITH_MANPAGES=OFF \
>   "
>   
> +EXTRA_OECMAKE:append:armv7a = " -DWITH_NEON=ON"
> +EXTRA_OECMAKE:append:armv7ve = " -DWITH_NEON=ON"


its better to check for neon feature

EXTRA_OECMAKE:append = ${@bb.utils.contains('TUNE_FEATURES', 'neon', ' 
-DWITH_NEON=ON', '', d)}

> +# ARMv8a NEON support is available only in FreeRDP 3.x
> +
>   PACKAGECONFIG ??= " \
>       ${@bb.utils.filter('DISTRO_FEATURES', 'directfb pam pulseaudio wayland x11', d)}\
>       gstreamer cups pcsc \
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve
  2021-11-18 19:03   ` Khem Raj
@ 2021-11-18 19:11     ` Marek Vasut
       [not found]       ` <13bb7bbe-c9d3-d6b8-82e1-b45a9c181938@gmail.com>
  0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 19:11 UTC (permalink / raw)
  To: Khem Raj, openembedded-devel; +Cc: Alexander Kanavin

On 11/18/21 8:03 PM, Khem Raj wrote:

[...]

>> diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb 
>> b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>> index aba77e20f..571ba5fcb 100644
>> --- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>> +++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>> @@ -30,6 +30,10 @@ EXTRA_OECMAKE += " \
>>       -DWITH_MANPAGES=OFF \
>>   "
>> +EXTRA_OECMAKE:append:armv7a = " -DWITH_NEON=ON"
>> +EXTRA_OECMAKE:append:armv7ve = " -DWITH_NEON=ON"
> 
> 
> its better to check for neon feature
> 
> EXTRA_OECMAKE:append = ${@bb.utils.contains('TUNE_FEATURES', 'neon', ' 
> -DWITH_NEON=ON', '', d)}

Doesn't that enable it for ARMv8a too ?

Feel free to pick the first three of these patches if they are OK and 
I'll respin this one a bit later.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve
       [not found]       ` <13bb7bbe-c9d3-d6b8-82e1-b45a9c181938@gmail.com>
@ 2021-11-18 19:47         ` Marek Vasut
  0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2021-11-18 19:47 UTC (permalink / raw)
  To: Khem Raj, openembedded-devel; +Cc: Alexander Kanavin

On 11/18/21 8:15 PM, Khem Raj wrote:
> 
> 
> On 11/18/21 11:11 AM, Marek Vasut wrote:
>> On 11/18/21 8:03 PM, Khem Raj wrote:
>>
>> [...]
>>
>>>> diff --git a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb 
>>>> b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>>>> index aba77e20f..571ba5fcb 100644
>>>> --- a/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>>>> +++ b/meta-oe/recipes-support/freerdp/freerdp_2.4.1.bb
>>>> @@ -30,6 +30,10 @@ EXTRA_OECMAKE += " \
>>>>       -DWITH_MANPAGES=OFF \
>>>>   "
>>>> +EXTRA_OECMAKE:append:armv7a = " -DWITH_NEON=ON"
>>>> +EXTRA_OECMAKE:append:armv7ve = " -DWITH_NEON=ON"
>>>
>>>
>>> its better to check for neon feature
>>>
>>> EXTRA_OECMAKE:append = ${@bb.utils.contains('TUNE_FEATURES', 'neon', 
>>> ' -DWITH_NEON=ON', '', d)}
>>
>> Doesn't that enable it for ARMv8a too ?
>>
> 
> for cortexa32 only.

The neon build is broken on armv8a until freerdp 3.0.0 is out, then we 
can enable it for armv8a too.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-11-18 19:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 17:51 [meta-oe][PATCH 1/4] freerdp: Upgrade 2.3.0 -> 2.4.1 Marek Vasut
2021-11-18 17:51 ` [meta-oe][PATCH 2/4] freerdp: Add missing libusb1 dependency Marek Vasut
2021-11-18 17:51 ` [meta-oe][PATCH 3/4] freerdp: Make PCSC dependency optional Marek Vasut
2021-11-18 17:51 ` [meta-oe][PATCH 4/4] freerdp: Enable NEON SIMD on armv7a and armv7ve Marek Vasut
2021-11-18 19:03   ` Khem Raj
2021-11-18 19:11     ` Marek Vasut
     [not found]       ` <13bb7bbe-c9d3-d6b8-82e1-b45a9c181938@gmail.com>
2021-11-18 19:47         ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.