* [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" @ 2021-11-19 16:54 Fabrice Fontaine 2021-11-19 16:54 ` [Buildroot] [PATCH 2/2] package/boost: threads needs date-time Fabrice Fontaine 2021-11-19 17:10 ` [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Yann E. MORIN 0 siblings, 2 replies; 6+ messages in thread From: Fabrice Fontaine @ 2021-11-19 16:54 UTC (permalink / raw) To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move these selects on boost side as the build failure was raised with gcc >= 7. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/log4cxx/Config.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in index 27a5f06988..6f1956f829 100644 --- a/package/log4cxx/Config.in +++ b/package/log4cxx/Config.in @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX select BR2_PACKAGE_APR_UTIL select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 help Apache log4cxx is a logging framework for C++ patterned -- 2.33.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/boost: threads needs date-time 2021-11-19 16:54 [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine @ 2021-11-19 16:54 ` Fabrice Fontaine 2021-11-19 17:10 ` [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Yann E. MORIN 1 sibling, 0 replies; 6+ messages in thread From: Fabrice Fontaine @ 2021-11-19 16:54 UTC (permalink / raw) To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni Fix the following build failure with gcc >= 7 raised since commit 4e267a7d3d5d350710a81ada188a1629348e4b4a because cmake assumes that boost threads needs boost date-time: -- Found Boost: /home/buildroot/autobuild/instance-3/output-1/host/sh4-buildroot-linux-uclibc/sysroot/usr/include (found version "1.77.0") found components: thread chrono atomic missing components: date_time Fixes: - http://autobuild.buildroot.org/results/e7443e3bc955e7eddd7bed63e2728880dabb31a7 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/boost/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/boost/Config.in b/package/boost/Config.in index 1c405a36c3..8310294ffd 100644 --- a/package/boost/Config.in +++ b/package/boost/Config.in @@ -348,6 +348,7 @@ config BR2_PACKAGE_BOOST_THREAD depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::current_exception select BR2_PACKAGE_BOOST_CHRONO + select BR2_PACKAGE_BOOST_DATE_TIME select BR2_PACKAGE_BOOST_SYSTEM help Portable C++ multi-threading. C++11, C++14. -- 2.33.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" 2021-11-19 16:54 [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine 2021-11-19 16:54 ` [Buildroot] [PATCH 2/2] package/boost: threads needs date-time Fabrice Fontaine @ 2021-11-19 17:10 ` Yann E. MORIN 2021-11-19 17:31 ` Fabrice Fontaine 1 sibling, 1 reply; 6+ messages in thread From: Yann E. MORIN @ 2021-11-19 17:10 UTC (permalink / raw) To: Fabrice Fontaine; +Cc: Thomas Petazzoni, buildroot Fabrice, All, On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly: > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > these selects on boost side as the build failure was raised with gcc >= > 7. So, if I understand correctly, if we just apply this revert, but not the following patch, we break the build again, right? If so, then it makes the history not bi-sectable. Instead, the boost patch must be applied first, and once that is done, then we can apply this revert. If the above is correct, just say so, we can re-order the patches when applying... Regards, Yann E. MORIN. > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/log4cxx/Config.in | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in > index 27a5f06988..6f1956f829 100644 > --- a/package/log4cxx/Config.in > +++ b/package/log4cxx/Config.in > @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX > select BR2_PACKAGE_APR_UTIL > select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > help > Apache log4cxx is a logging framework for C++ patterned > -- > 2.33.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" 2021-11-19 17:10 ` [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Yann E. MORIN @ 2021-11-19 17:31 ` Fabrice Fontaine 2021-11-19 17:43 ` Fabrice Fontaine 0 siblings, 1 reply; 6+ messages in thread From: Fabrice Fontaine @ 2021-11-19 17:31 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Thomas Petazzoni, Buildroot Mailing List Hi Yann, Le ven. 19 nov. 2021 à 18:10, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > Fabrice, All, > > On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly: > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > these selects on boost side as the build failure was raised with gcc >= > > 7. > > So, if I understand correctly, if we just apply this revert, but not the > following patch, we break the build again, right? If so, then it makes > the history not bi-sectable. No, basically the patch that I'm reverting is a "no-op". It does not fix anything as the build failure is raised with gcc >=7, not gcc < 7. I made this mistake, because the build failure is only raised since cmake >= 3.21.3 and https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. cmake has the following behavior: - if it "recognizes" the boost version, it will set the boost thread dependencies to chrono date_time atomic. - However, if it does not recognize it (i.e. with cmake < 3.21.3 and boost 1.77.0), it will set the boost thread dependencies to chrono atomic. > > Instead, the boost patch must be applied first, and once that is done, > then we can apply this revert. > > If the above is correct, just say so, we can re-order the patches when > applying... > > Regards, > Yann E. MORIN. > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/log4cxx/Config.in | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in > > index 27a5f06988..6f1956f829 100644 > > --- a/package/log4cxx/Config.in > > +++ b/package/log4cxx/Config.in > > @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX > > select BR2_PACKAGE_APR_UTIL > > select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > help > > Apache log4cxx is a logging framework for C++ patterned > > -- > > 2.33.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' Best Regards, Fabrice _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" 2021-11-19 17:31 ` Fabrice Fontaine @ 2021-11-19 17:43 ` Fabrice Fontaine 2021-11-19 17:50 ` Yann E. MORIN 0 siblings, 1 reply; 6+ messages in thread From: Fabrice Fontaine @ 2021-11-19 17:43 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Thomas Petazzoni, Buildroot Mailing List Le ven. 19 nov. 2021 à 18:31, Fabrice Fontaine <fontaine.fabrice@gmail.com> a écrit : > > Hi Yann, > > Le ven. 19 nov. 2021 à 18:10, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > > > Fabrice, All, > > > > On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly: > > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > > these selects on boost side as the build failure was raised with gcc >= > > > 7. > > > > So, if I understand correctly, if we just apply this revert, but not the > > following patch, we break the build again, right? If so, then it makes > > the history not bi-sectable. > No, basically the patch that I'm reverting is a "no-op". > It does not fix anything as the build failure is raised with gcc >=7, > not gcc < 7. > I made this mistake, because the build failure is only raised since > cmake >= 3.21.3 and In fact, I made another mistake, the build failure is raised with cmake < 3.21.3. I really hate cmake ;-). I'll send a v2 with an updated commit log. > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. > > cmake has the following behavior: > - if it "recognizes" the boost version, it will set the boost thread > dependencies to chrono date_time atomic. > - However, if it does not recognize it (i.e. with cmake < 3.21.3 and > boost 1.77.0), it will set the boost thread dependencies to chrono > atomic. > > > > Instead, the boost patch must be applied first, and once that is done, > > then we can apply this revert. > > > > If the above is correct, just say so, we can re-order the patches when > > applying... > > > > Regards, > > Yann E. MORIN. > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > --- > > > package/log4cxx/Config.in | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in > > > index 27a5f06988..6f1956f829 100644 > > > --- a/package/log4cxx/Config.in > > > +++ b/package/log4cxx/Config.in > > > @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX > > > select BR2_PACKAGE_APR_UTIL > > > select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > help > > > Apache log4cxx is a logging framework for C++ patterned > > > -- > > > 2.33.0 > > > > > > _______________________________________________ > > > buildroot mailing list > > > buildroot@buildroot.org > > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > > -- > > .-----------------.--------------------.------------------.--------------------. > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > '------------------------------^-------^------------------^--------------------' > Best Regards, > > Fabrice _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" 2021-11-19 17:43 ` Fabrice Fontaine @ 2021-11-19 17:50 ` Yann E. MORIN 0 siblings, 0 replies; 6+ messages in thread From: Yann E. MORIN @ 2021-11-19 17:50 UTC (permalink / raw) To: Fabrice Fontaine; +Cc: Thomas Petazzoni, Buildroot Mailing List Fabrice, All, (typing this without light, I accidentally broke the bulb... Hopefully, there will be less typoes than in my usual mails, as I am extra careful what key I am typing. Hey, that's not even guaranteed! ;-] ) On 2021-11-19 18:43 +0100, Fabrice Fontaine spake thusly: > Le ven. 19 nov. 2021 à 18:31, Fabrice Fontaine > <fontaine.fabrice@gmail.com> a écrit : > > Le ven. 19 nov. 2021 à 18:10, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > > On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly: > > > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > > > these selects on boost side as the build failure was raised with gcc >= > > > > 7. > > > So, if I understand correctly, if we just apply this revert, but not the > > > following patch, we break the build again, right? If so, then it makes > > > the history not bi-sectable. > > No, basically the patch that I'm reverting is a "no-op". Aj, OK, so the order indeed does not matter much. But semantically, it does matter, and that the revert comes first is then correct, with your explanations. > > It does not fix anything as the build failure is raised with gcc >=7, > > not gcc < 7. > > I made this mistake, because the build failure is only raised since > > cmake >= 3.21.3 and > In fact, I made another mistake, the build failure is raised with > cmake < 3.21.3. > I really hate cmake ;-). I'll send a v2 with an updated commit log. Hihihi! :-) Thanks! Regards, Yann E. MORIN. > > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. > > > > cmake has the following behavior: > > - if it "recognizes" the boost version, it will set the boost thread > > dependencies to chrono date_time atomic. > > - However, if it does not recognize it (i.e. with cmake < 3.21.3 and > > boost 1.77.0), it will set the boost thread dependencies to chrono > > atomic. > > > > > > Instead, the boost patch must be applied first, and once that is done, > > > then we can apply this revert. > > > > > > If the above is correct, just say so, we can re-order the patches when > > > applying... > > > > > > Regards, > > > Yann E. MORIN. > > > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > > --- > > > > package/log4cxx/Config.in | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in > > > > index 27a5f06988..6f1956f829 100644 > > > > --- a/package/log4cxx/Config.in > > > > +++ b/package/log4cxx/Config.in > > > > @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX > > > > select BR2_PACKAGE_APR_UTIL > > > > select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > help > > > > Apache log4cxx is a logging framework for C++ patterned > > > > -- > > > > 2.33.0 > > > > > > > > _______________________________________________ > > > > buildroot mailing list > > > > buildroot@buildroot.org > > > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > > > > -- > > > .-----------------.--------------------.------------------.--------------------. > > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > > '------------------------------^-------^------------------^--------------------' > > Best Regards, > > > > Fabrice -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-19 17:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-11-19 16:54 [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine 2021-11-19 16:54 ` [Buildroot] [PATCH 2/2] package/boost: threads needs date-time Fabrice Fontaine 2021-11-19 17:10 ` [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Yann E. MORIN 2021-11-19 17:31 ` Fabrice Fontaine 2021-11-19 17:43 ` Fabrice Fontaine 2021-11-19 17:50 ` Yann E. MORIN
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.