All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Michał Winiarski" <michal.winiarski@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>,
	"Andi Shyti" <andi.shyti@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0
Date: Fri, 19 Nov 2021 09:32:13 -0800	[thread overview]
Message-ID: <20211119173213.4gupm2m7tcmfur5g@ldmartin-desk2> (raw)
In-Reply-To: <163715857341.11567.6516227738264680366@build.alporthouse.com>

On Wed, Nov 17, 2021 at 02:16:13PM +0000, Chris Wilson wrote:
>Quoting Andi Shyti (2021-11-17 13:34:56)
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index a9727447c0379..4bfedc04f5c70 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -936,7 +936,7 @@ hsw_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
>>  static void
>>  gen9_wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
>>  {
>> -       const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
>> +       const struct sseu_dev_info *sseu = &i915->gt0.info.sseu;
>
>This feels like it should be pulling from uncore->gt, since the MCR is
>across an uncore.
>
>Overall though, rather than introduce bare &i915->gt0, how about pulling in
>the patch for to_gt(i915)?

agreed, why are we going a different route rather than using the to_gt()
patches Michal prepared? If the to_gt() is not what we want, then please
sync with Michal on the proper direction

Lucas De Marchi

WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Michał Winiarski" <michal.winiarski@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0
Date: Fri, 19 Nov 2021 09:32:13 -0800	[thread overview]
Message-ID: <20211119173213.4gupm2m7tcmfur5g@ldmartin-desk2> (raw)
In-Reply-To: <163715857341.11567.6516227738264680366@build.alporthouse.com>

On Wed, Nov 17, 2021 at 02:16:13PM +0000, Chris Wilson wrote:
>Quoting Andi Shyti (2021-11-17 13:34:56)
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index a9727447c0379..4bfedc04f5c70 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -936,7 +936,7 @@ hsw_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
>>  static void
>>  gen9_wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
>>  {
>> -       const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
>> +       const struct sseu_dev_info *sseu = &i915->gt0.info.sseu;
>
>This feels like it should be pulling from uncore->gt, since the MCR is
>across an uncore.
>
>Overall though, rather than introduce bare &i915->gt0, how about pulling in
>the patch for to_gt(i915)?

agreed, why are we going a different route rather than using the to_gt()
patches Michal prepared? If the to_gt() is not what we want, then please
sync with Michal on the proper direction

Lucas De Marchi

  reply	other threads:[~2021-11-19 17:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 13:34 [PATCH 0/2] More preparation for multi gt patches Andi Shyti
2021-11-17 13:34 ` [Intel-gfx] " Andi Shyti
2021-11-17 13:34 ` [PATCH 1/2] drm/i915: Store backpointer to GT in uncore Andi Shyti
2021-11-17 13:34   ` [Intel-gfx] " Andi Shyti
2021-11-17 13:34 ` [PATCH 2/2] drm/i915: Rename gt to gt0 Andi Shyti
2021-11-17 13:34   ` [Intel-gfx] " Andi Shyti
2021-11-17 14:16   ` Chris Wilson
2021-11-19 17:32     ` Lucas De Marchi [this message]
2021-11-19 17:32       ` Lucas De Marchi
2021-11-21 12:35     ` Andi Shyti
2021-11-21 12:35       ` Andi Shyti
2021-11-17 18:39 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for More preparation for multi gt patches Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119173213.4gupm2m7tcmfur5g@ldmartin-desk2 \
    --to=lucas.demarchi@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.winiarski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.