* [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
@ 2021-11-23 8:36 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2021-11-23 8:36 UTC (permalink / raw)
To: weiyongjun1, Etienne Carriere, Sudeep Holla
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Hulk Robot
The driver allocates the mutex but not initialize it.
Use mutex_init() on it to initialize it correctly.
Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/firmware/arm_scmi/optee.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
index d9819b0197ec..901737c9f5f8 100644
--- a/drivers/firmware/arm_scmi/optee.c
+++ b/drivers/firmware/arm_scmi/optee.c
@@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
agent->dev = dev;
agent->tee_ctx = tee_ctx;
INIT_LIST_HEAD(&agent->channel_list);
+ mutex_init(&agent->mu);
ret = get_capabilities(agent);
if (ret)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
@ 2021-11-23 8:36 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2021-11-23 8:36 UTC (permalink / raw)
To: weiyongjun1, Etienne Carriere, Sudeep Holla
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Hulk Robot
The driver allocates the mutex but not initialize it.
Use mutex_init() on it to initialize it correctly.
Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/firmware/arm_scmi/optee.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
index d9819b0197ec..901737c9f5f8 100644
--- a/drivers/firmware/arm_scmi/optee.c
+++ b/drivers/firmware/arm_scmi/optee.c
@@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
agent->dev = dev;
agent->tee_ctx = tee_ctx;
INIT_LIST_HEAD(&agent->channel_list);
+ mutex_init(&agent->mu);
ret = get_capabilities(agent);
if (ret)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
2021-11-23 8:36 ` Wei Yongjun
@ 2021-11-23 13:17 ` Etienne Carriere
-1 siblings, 0 replies; 6+ messages in thread
From: Etienne Carriere @ 2021-11-23 13:17 UTC (permalink / raw)
To: Wei Yongjun
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors,
Hulk Robot
On Tue, 23 Nov 2021 at 09:23, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
> Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/firmware/arm_scmi/optee.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
> index d9819b0197ec..901737c9f5f8 100644
> --- a/drivers/firmware/arm_scmi/optee.c
> +++ b/drivers/firmware/arm_scmi/optee.c
> @@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
> agent->dev = dev;
> agent->tee_ctx = tee_ctx;
> INIT_LIST_HEAD(&agent->channel_list);
> + mutex_init(&agent->mu);
>
> ret = get_capabilities(agent);
> if (ret)
>
`Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>`
Indeed. Thanks for the fix.
Etienne
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
@ 2021-11-23 13:17 ` Etienne Carriere
0 siblings, 0 replies; 6+ messages in thread
From: Etienne Carriere @ 2021-11-23 13:17 UTC (permalink / raw)
To: Wei Yongjun
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors,
Hulk Robot
On Tue, 23 Nov 2021 at 09:23, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
> Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/firmware/arm_scmi/optee.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
> index d9819b0197ec..901737c9f5f8 100644
> --- a/drivers/firmware/arm_scmi/optee.c
> +++ b/drivers/firmware/arm_scmi/optee.c
> @@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
> agent->dev = dev;
> agent->tee_ctx = tee_ctx;
> INIT_LIST_HEAD(&agent->channel_list);
> + mutex_init(&agent->mu);
>
> ret = get_capabilities(agent);
> if (ret)
>
`Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>`
Indeed. Thanks for the fix.
Etienne
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
2021-11-23 8:36 ` Wei Yongjun
@ 2021-11-25 12:36 ` Sudeep Holla
-1 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2021-11-25 12:36 UTC (permalink / raw)
To: Wei Yongjun, Etienne Carriere
Cc: Sudeep Holla, linux-kernel, kernel-janitors, Hulk Robot,
linux-arm-kernel
On Tue, 23 Nov 2021 08:36:20 +0000, Wei Yongjun wrote:
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
>
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: optee: Fix missing mutex_init()
https://git.kernel.org/sudeep.holla/c/61bc76be36
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
@ 2021-11-25 12:36 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2021-11-25 12:36 UTC (permalink / raw)
To: Wei Yongjun, Etienne Carriere
Cc: Sudeep Holla, linux-kernel, kernel-janitors, Hulk Robot,
linux-arm-kernel
On Tue, 23 Nov 2021 08:36:20 +0000, Wei Yongjun wrote:
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
>
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: optee: Fix missing mutex_init()
https://git.kernel.org/sudeep.holla/c/61bc76be36
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-25 12:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 8:36 [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init() Wei Yongjun
2021-11-23 8:36 ` Wei Yongjun
2021-11-23 13:17 ` Etienne Carriere
2021-11-23 13:17 ` Etienne Carriere
2021-11-25 12:36 ` Sudeep Holla
2021-11-25 12:36 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.