From: Shawn Guo <shawnguo@kernel.org> To: Martin Kepplinger <martink@posteo.de> Cc: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node Date: Tue, 23 Nov 2021 17:24:31 +0800 [thread overview] Message-ID: <20211123092430.GY31998@dragon> (raw) In-Reply-To: <9b9fe3a5b04179870d6ca0ece754fee9abb306b4.camel@posteo.de> On Tue, Nov 23, 2021 at 09:15:57AM +0000, Martin Kepplinger wrote: > Am Dienstag, dem 23.11.2021 um 16:58 +0800 schrieb Shawn Guo: > > On Thu, Nov 11, 2021 at 01:16:09PM +0200, Abel Vesa wrote: > > > Adding interconnect properties to the consumer nodes creates > > > a dependency on noc device. The imx-bus devfreq driver is not > > > usable > > > without the full interconnect support. The interconnect is not yet > > > working on i.MX platforms. The devlink created on device_add makes > > > the lcdif and other nodes that have the interconnect properties > > > wait for the noc (imx-bus driver) to probe first. > > > > > > To make sure the interconnect consumers (nodes that have > > > interconnect > > > properties already added) will still probe, lets disable the noc > > > node > > > for now. Once the interconnect on i.MX platforms is fully > > > functional, > > > the status of the noc node can be changed. > > > > > > Fixes: ad1abc8a03fdbc05b ("arm64: dts: imx8mq: Add interconnect for > > > lcdif") > > > > Martin, > > > > Do you have any comment? So your commit added something untested? > > > > Shawn > > hi Shawn, > > well, for imx8mq the only missing piece is the mxsfb icc bandwidth > request. I posted a first version a year ago but that didn't make it > in: > https://lore.kernel.org/linux-arm-kernel/20201201103757.32165-1-martin.kepplinger@puri.sm/ > > So this should create a working state until the real fix in mxsfb is > there (although I'd revert commit ad1abc8a03fd ("arm64: dts: imx8mq: > Add interconnect for lcdif") instead). Besides lcdif, the mipi-csi devices have interconnects property too. Are they already working? If so, it makes more sense to revert ad1abc8a03fd instead. Shawn > I am indeed to blame for this > and I'm sorry I haven't yet taken the time to work on mxsfb again. > > I can say I plan to do so soon, but without promise that I quickly find > a solution that'll be merged... > > If you merge this (or revert ad1abc8a03fd), I'll remember to revert > with said update.
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Martin Kepplinger <martink@posteo.de> Cc: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node Date: Tue, 23 Nov 2021 17:24:31 +0800 [thread overview] Message-ID: <20211123092430.GY31998@dragon> (raw) In-Reply-To: <9b9fe3a5b04179870d6ca0ece754fee9abb306b4.camel@posteo.de> On Tue, Nov 23, 2021 at 09:15:57AM +0000, Martin Kepplinger wrote: > Am Dienstag, dem 23.11.2021 um 16:58 +0800 schrieb Shawn Guo: > > On Thu, Nov 11, 2021 at 01:16:09PM +0200, Abel Vesa wrote: > > > Adding interconnect properties to the consumer nodes creates > > > a dependency on noc device. The imx-bus devfreq driver is not > > > usable > > > without the full interconnect support. The interconnect is not yet > > > working on i.MX platforms. The devlink created on device_add makes > > > the lcdif and other nodes that have the interconnect properties > > > wait for the noc (imx-bus driver) to probe first. > > > > > > To make sure the interconnect consumers (nodes that have > > > interconnect > > > properties already added) will still probe, lets disable the noc > > > node > > > for now. Once the interconnect on i.MX platforms is fully > > > functional, > > > the status of the noc node can be changed. > > > > > > Fixes: ad1abc8a03fdbc05b ("arm64: dts: imx8mq: Add interconnect for > > > lcdif") > > > > Martin, > > > > Do you have any comment? So your commit added something untested? > > > > Shawn > > hi Shawn, > > well, for imx8mq the only missing piece is the mxsfb icc bandwidth > request. I posted a first version a year ago but that didn't make it > in: > https://lore.kernel.org/linux-arm-kernel/20201201103757.32165-1-martin.kepplinger@puri.sm/ > > So this should create a working state until the real fix in mxsfb is > there (although I'd revert commit ad1abc8a03fd ("arm64: dts: imx8mq: > Add interconnect for lcdif") instead). Besides lcdif, the mipi-csi devices have interconnects property too. Are they already working? If so, it makes more sense to revert ad1abc8a03fd instead. Shawn > I am indeed to blame for this > and I'm sorry I haven't yet taken the time to work on mxsfb again. > > I can say I plan to do so soon, but without promise that I quickly find > a solution that'll be merged... > > If you merge this (or revert ad1abc8a03fd), I'll remember to revert > with said update. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-23 9:24 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-11 11:16 [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node Abel Vesa 2021-11-11 11:16 ` Abel Vesa 2021-11-23 8:58 ` Shawn Guo 2021-11-23 8:58 ` Shawn Guo 2021-11-23 9:15 ` Martin Kepplinger 2021-11-23 9:15 ` Martin Kepplinger 2021-11-23 9:24 ` Shawn Guo [this message] 2021-11-23 9:24 ` Shawn Guo 2021-11-23 9:30 ` Martin Kepplinger 2021-11-23 9:30 ` Martin Kepplinger 2021-11-23 11:07 ` Shawn Guo 2021-11-23 11:07 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211123092430.GY31998@dragon \ --to=shawnguo@kernel.org \ --cc=abel.vesa@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=martink@posteo.de \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.