Re: [PATCH v2 1/6] iommu: Export iommu_{get,put}_resv_regions()

From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: gregkh@linuxfoundation.org, helgaas@kernel.org,
	alexander.shishkin@linux.intel.com, lorenzo.pieralisi@arm.com,
	will@kernel.org, mark.rutland@arm.com, suzuki.poulose@arm.com,
	mike.leach@linaro.org, leo.yan@linaro.org,
	jonathan.cameron@huawei.com, daniel.thompson@linaro.org,
	joro@8bytes.org, john.garry@huawei.com,
	shameerali.kolothum.thodi@huawei.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org,
	iommu@lists.linux-foundation.org, prime.zeng@huawei.com,
	liuqi115@huawei.com, zhangshaokun@hisilicon.com,
	linuxarm@huawei.com, song.bao.hua@hisilicon.com
Subject: Re: [PATCH v2 1/6] iommu: Export iommu_{get,put}_resv_regions()
Date: Wed, 24 Nov 2021 10:51:11 -0700	[thread overview]
Message-ID: <20211124175111.GA35341@p14s> (raw)
In-Reply-To: <20211116090625.53702-2-yangyicong@hisilicon.com>

On Tue, Nov 16, 2021 at 05:06:20PM +0800, Yicong Yang wrote:
> Export iommu_{get,put}_resv_regions() to the modules so that the driver
> can retrieve and use the reserved regions of the device.
> 
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
>  drivers/iommu/iommu.c | 2 ++
>  include/linux/iommu.h | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index dd7863e453a5..e96711eee965 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -2792,6 +2792,7 @@ void iommu_get_resv_regions(struct device *dev, struct list_head *list)
>  	if (ops && ops->get_resv_regions)
>  		ops->get_resv_regions(dev, list);
>  }
> +EXPORT_SYMBOL_GPL(iommu_get_resv_regions);
>  
>  void iommu_put_resv_regions(struct device *dev, struct list_head *list)
>  {
> @@ -2800,6 +2801,7 @@ void iommu_put_resv_regions(struct device *dev, struct list_head *list)
>  	if (ops && ops->put_resv_regions)
>  		ops->put_resv_regions(dev, list);
>  }
> +EXPORT_SYMBOL_GPL(iommu_put_resv_regions);
>  
>  /**
>   * generic_iommu_put_resv_regions - Reserved region driver helper
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index d2f3435e7d17..1b7b0f370e28 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -450,8 +450,8 @@ extern phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain, dma_addr_t io
>  extern void iommu_set_fault_handler(struct iommu_domain *domain,
>  			iommu_fault_handler_t handler, void *token);
>  
> -extern void iommu_get_resv_regions(struct device *dev, struct list_head *list);
> -extern void iommu_put_resv_regions(struct device *dev, struct list_head *list);
> +void iommu_get_resv_regions(struct device *dev, struct list_head *list);
> +void iommu_put_resv_regions(struct device *dev, struct list_head *list);

Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  extern void generic_iommu_put_resv_regions(struct device *dev,
>  					   struct list_head *list);
>  extern void iommu_set_default_passthrough(bool cmd_line);
> -- 
> 2.33.0
>