All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Fix OLED brightness control on eDP
@ 2021-11-24 18:01 Alex Deucher
  2021-11-28 12:03 ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Alex Deucher @ 2021-11-24 18:01 UTC (permalink / raw)
  To: stable; +Cc: Roman Li, Samuel Čavoj, Alex Deucher, Jasdeep Dhillon

From: Roman Li <Roman.Li@amd.com>

[Why]
After commit ("drm/amdgpu/display: add support for multiple backlights")
number of eDPs is defined while registering backlight device.
However the panel's extended caps get updated once before register call.
That leads to regression with extended caps like oled brightness control.

[How]
Update connector ext caps after register_backlight_device

Fixes: 7fd13baeb7a3a4 ("drm/amdgpu/display: add support for multiple backlights")
Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/

Signed-off-by: Roman Li <Roman.Li@amd.com>
Tested-by: Samuel Čavoj <samuel@cavoj.net>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Jasdeep Dhillon <Jasdeep.Dhillon@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
(cherry picked from commit dab60582685aabdae2d4ff7ce716456bd0dc7a0f)
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1ea31dcc7a8b..a70c57e73cce 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3839,6 +3839,9 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
 		} else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
 			amdgpu_dm_update_connector_after_detect(aconnector);
 			register_backlight_device(dm, link);
+
+			if (dm->num_of_edps)
+				update_connector_ext_caps(aconnector);
 			if (amdgpu_dc_feature_mask & DC_PSR_MASK)
 				amdgpu_dm_set_psr_caps(link);
 		}
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Fix OLED brightness control on eDP
  2021-11-24 18:01 [PATCH] drm/amd/display: Fix OLED brightness control on eDP Alex Deucher
@ 2021-11-28 12:03 ` Greg KH
  2021-11-28 12:04   ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-11-28 12:03 UTC (permalink / raw)
  To: Alex Deucher; +Cc: stable, Roman Li, Samuel Čavoj, Jasdeep Dhillon

On Wed, Nov 24, 2021 at 01:01:22PM -0500, Alex Deucher wrote:
> From: Roman Li <Roman.Li@amd.com>
> 
> [Why]
> After commit ("drm/amdgpu/display: add support for multiple backlights")
> number of eDPs is defined while registering backlight device.
> However the panel's extended caps get updated once before register call.
> That leads to regression with extended caps like oled brightness control.
> 
> [How]
> Update connector ext caps after register_backlight_device
> 
> Fixes: 7fd13baeb7a3a4 ("drm/amdgpu/display: add support for multiple backlights")
> Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/
> 
> Signed-off-by: Roman Li <Roman.Li@amd.com>
> Tested-by: Samuel Čavoj <samuel@cavoj.net>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Reviewed-by: Jasdeep Dhillon <Jasdeep.Dhillon@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> (cherry picked from commit dab60582685aabdae2d4ff7ce716456bd0dc7a0f)

Now queued up for 5.10 and 5.15, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Fix OLED brightness control on eDP
  2021-11-28 12:03 ` Greg KH
@ 2021-11-28 12:04   ` Greg KH
  0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2021-11-28 12:04 UTC (permalink / raw)
  To: Alex Deucher; +Cc: stable, Roman Li, Samuel Čavoj, Jasdeep Dhillon

On Sun, Nov 28, 2021 at 01:03:59PM +0100, Greg KH wrote:
> On Wed, Nov 24, 2021 at 01:01:22PM -0500, Alex Deucher wrote:
> > From: Roman Li <Roman.Li@amd.com>
> > 
> > [Why]
> > After commit ("drm/amdgpu/display: add support for multiple backlights")
> > number of eDPs is defined while registering backlight device.
> > However the panel's extended caps get updated once before register call.
> > That leads to regression with extended caps like oled brightness control.
> > 
> > [How]
> > Update connector ext caps after register_backlight_device
> > 
> > Fixes: 7fd13baeb7a3a4 ("drm/amdgpu/display: add support for multiple backlights")
> > Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/
> > 
> > Signed-off-by: Roman Li <Roman.Li@amd.com>
> > Tested-by: Samuel Čavoj <samuel@cavoj.net>
> > Acked-by: Alex Deucher <alexander.deucher@amd.com>
> > Reviewed-by: Jasdeep Dhillon <Jasdeep.Dhillon@amd.com>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > Cc: stable@vger.kernel.org
> > (cherry picked from commit dab60582685aabdae2d4ff7ce716456bd0dc7a0f)
> 
> Now queued up for 5.10 and 5.15, thanks.

Oops, only for 5.15, not for 5.10, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] drm/amd/display: Fix OLED brightness control on eDP
@ 2021-11-24 16:05 Alex Deucher
  0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2021-11-24 16:05 UTC (permalink / raw)
  To: linux-stable
  Cc: Roman Li, Samuel Čavoj, Alex Deucher, Jasdeep Dhillon, stable

From: Roman Li <Roman.Li@amd.com>

[Why]
After commit ("drm/amdgpu/display: add support for multiple backlights")
number of eDPs is defined while registering backlight device.
However the panel's extended caps get updated once before register call.
That leads to regression with extended caps like oled brightness control.

[How]
Update connector ext caps after register_backlight_device

Fixes: 7fd13baeb7a3a4 ("drm/amdgpu/display: add support for multiple backlights")
Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/

Signed-off-by: Roman Li <Roman.Li@amd.com>
Tested-by: Samuel Čavoj <samuel@cavoj.net>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Jasdeep Dhillon <Jasdeep.Dhillon@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
(cherry picked from commit dab60582685aabdae2d4ff7ce716456bd0dc7a0f)
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1ea31dcc7a8b..a70c57e73cce 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3839,6 +3839,9 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
 		} else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
 			amdgpu_dm_update_connector_after_detect(aconnector);
 			register_backlight_device(dm, link);
+
+			if (dm->num_of_edps)
+				update_connector_ext_caps(aconnector);
 			if (amdgpu_dc_feature_mask & DC_PSR_MASK)
 				amdgpu_dm_set_psr_caps(link);
 		}
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Fix OLED brightness control on eDP
  2021-11-17 15:22 Roman.Li
  2021-11-17 16:12 ` Alex Deucher
@ 2021-11-17 16:37 ` Samuel Čavoj
  1 sibling, 0 replies; 7+ messages in thread
From: Samuel Čavoj @ 2021-11-17 16:37 UTC (permalink / raw)
  To: Roman.Li; +Cc: Alexander.Deucher, Sunpeng.Li, amd-gfx

On 17.11.2021 10:22, Roman.Li@amd.com wrote:
> From: Roman Li <Roman.Li@amd.com>
> 
> [Why]
> After commit ("drm/amd/display: add support for multiple backlights")
> number of eDPs is defined while registering backlight device.
> However the panel's extended caps get updated once before register call.
> That leads to regression with extended caps like oled brightness control.
> 
> [How]
> Update connector ext caps after register_backlight_device
> 
> Fixes: b1c61212d8dc ("drm/amd/display: add support for multiple backlights")
> Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/

Tested-By: Samuel Čavoj <samuel@cavoj.net>

> 
> Signed-off-by: Roman Li <Roman.Li@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 26fcc89..44c9994 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4243,7 +4243,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>  		} else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
>  			amdgpu_dm_update_connector_after_detect(aconnector);
>  			register_backlight_device(dm, link);
> -
> +			if (dm->num_of_edps)
> +				update_connector_ext_caps(aconnector);
>  			if (psr_feature_enabled)
>  				amdgpu_dm_set_psr_caps(link);
>  		}
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Fix OLED brightness control on eDP
  2021-11-17 15:22 Roman.Li
@ 2021-11-17 16:12 ` Alex Deucher
  2021-11-17 16:37 ` Samuel Čavoj
  1 sibling, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2021-11-17 16:12 UTC (permalink / raw)
  To: Roman Li
  Cc: Deucher, Alexander, Leo (Sunpeng) Li, Samuel Čavoj, amd-gfx list

On Wed, Nov 17, 2021 at 10:22 AM <Roman.Li@amd.com> wrote:
>
> From: Roman Li <Roman.Li@amd.com>
>
> [Why]
> After commit ("drm/amd/display: add support for multiple backlights")
> number of eDPs is defined while registering backlight device.
> However the panel's extended caps get updated once before register call.
> That leads to regression with extended caps like oled brightness control.
>
> [How]
> Update connector ext caps after register_backlight_device
>
> Fixes: b1c61212d8dc ("drm/amd/display: add support for multiple backlights")
> Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/

Acked-by: Alex Deucher <alexander.deucher@amd.com>

>
> Signed-off-by: Roman Li <Roman.Li@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 26fcc89..44c9994 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4243,7 +4243,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>                 } else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
>                         amdgpu_dm_update_connector_after_detect(aconnector);
>                         register_backlight_device(dm, link);
> -
> +                       if (dm->num_of_edps)
> +                               update_connector_ext_caps(aconnector);
>                         if (psr_feature_enabled)
>                                 amdgpu_dm_set_psr_caps(link);
>                 }
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] drm/amd/display: Fix OLED brightness control on eDP
@ 2021-11-17 15:22 Roman.Li
  2021-11-17 16:12 ` Alex Deucher
  2021-11-17 16:37 ` Samuel Čavoj
  0 siblings, 2 replies; 7+ messages in thread
From: Roman.Li @ 2021-11-17 15:22 UTC (permalink / raw)
  To: amd-gfx, Alexander.Deucher, Sunpeng.Li, samuel; +Cc: Roman Li

From: Roman Li <Roman.Li@amd.com>

[Why]
After commit ("drm/amd/display: add support for multiple backlights")
number of eDPs is defined while registering backlight device.
However the panel's extended caps get updated once before register call.
That leads to regression with extended caps like oled brightness control.

[How]
Update connector ext caps after register_backlight_device

Fixes: b1c61212d8dc ("drm/amd/display: add support for multiple backlights")
Link: https://www.reddit.com/r/AMDLaptops/comments/qst0fm/after_updating_to_linux_515_my_brightness/

Signed-off-by: Roman Li <Roman.Li@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 26fcc89..44c9994 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4243,7 +4243,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
 		} else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
 			amdgpu_dm_update_connector_after_detect(aconnector);
 			register_backlight_device(dm, link);
-
+			if (dm->num_of_edps)
+				update_connector_ext_caps(aconnector);
 			if (psr_feature_enabled)
 				amdgpu_dm_set_psr_caps(link);
 		}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-28 12:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 18:01 [PATCH] drm/amd/display: Fix OLED brightness control on eDP Alex Deucher
2021-11-28 12:03 ` Greg KH
2021-11-28 12:04   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2021-11-24 16:05 Alex Deucher
2021-11-17 15:22 Roman.Li
2021-11-17 16:12 ` Alex Deucher
2021-11-17 16:37 ` Samuel Čavoj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.