* [PATCH] ima: Fix trivial typos in the comments
@ 2021-11-24 21:44 Austin Kim
2022-01-12 8:46 ` Austin Kim
0 siblings, 1 reply; 7+ messages in thread
From: Austin Kim @ 2021-11-24 21:44 UTC (permalink / raw)
To: zohar, dmitry.kasatkin
Cc: linux-integrity, linux-security-module, linux-kernel
There are a few minor typos in the comments. Fix these.
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
security/integrity/ima/ima_api.c | 2 +-
security/integrity/ima/ima_main.c | 2 +-
security/integrity/ima/ima_policy.c | 2 +-
security/integrity/ima/ima_template_lib.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
index a64fb0130b01..5b220a2fe573 100644
--- a/security/integrity/ima/ima_api.c
+++ b/security/integrity/ima/ima_api.c
@@ -238,7 +238,7 @@ int ima_collect_measurement(struct integrity_iint_cache *iint,
goto out;
/*
- * Dectecting file change is based on i_version. On filesystems
+ * Detecting file change is based on i_version. On filesystems
* which do not support i_version, support is limited to an initial
* measurement/appraisal/audit.
*/
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 8c6e4514d494..8ed6da428328 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -764,7 +764,7 @@ int ima_post_read_file(struct file *file, void *buf, loff_t size,
* call to ima_post_load_data().
*
* Callers of this LSM hook can not measure, appraise, or audit the
- * data provided by userspace. Enforce policy rules requring a file
+ * data provided by userspace. Enforce policy rules requiring a file
* signature (eg. kexec'ed kernel image).
*
* For permission return 0, otherwise return -EACCES.
diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
index 320ca80aacab..ad7e19208a69 100644
--- a/security/integrity/ima/ima_policy.c
+++ b/security/integrity/ima/ima_policy.c
@@ -429,7 +429,7 @@ static int ima_lsm_update_rule(struct ima_rule_entry *entry)
/*
* ima_lsm_copy_rule() shallow copied all references, except for the
* LSM references, from entry to nentry so we only want to free the LSM
- * references and the entry itself. All other memory refrences will now
+ * references and the entry itself. All other memory references will now
* be owned by nentry.
*/
ima_lsm_free_rule(entry);
diff --git a/security/integrity/ima/ima_template_lib.c b/security/integrity/ima/ima_template_lib.c
index ca017cae73eb..5a5d462ab36d 100644
--- a/security/integrity/ima/ima_template_lib.c
+++ b/security/integrity/ima/ima_template_lib.c
@@ -272,7 +272,7 @@ static int ima_eventdigest_init_common(const u8 *digest, u32 digestsize,
* digest formats:
* - DATA_FMT_DIGEST: digest
* - DATA_FMT_DIGEST_WITH_ALGO: [<hash algo>] + ':' + '\0' + digest,
- * where <hash algo> is provided if the hash algoritm is not
+ * where <hash algo> is provided if the hash algorithm is not
* SHA1 or MD5
*/
u8 buffer[CRYPTO_MAX_ALG_NAME + 2 + IMA_MAX_DIGEST_SIZE] = { 0 };
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ima: Fix trivial typos in the comments
2021-11-24 21:44 [PATCH] ima: Fix trivial typos in the comments Austin Kim
@ 2022-01-12 8:46 ` Austin Kim
2022-01-14 1:51 ` Mimi Zohar
0 siblings, 1 reply; 7+ messages in thread
From: Austin Kim @ 2022-01-12 8:46 UTC (permalink / raw)
To: Austin Kim
Cc: zohar, dmitry.kasatkin, linux-integrity, linux-security-module,
linux-kernel
Hi,
Would you take a look at this patch?
It won't take long.
BR,
Austin Kim
2021년 11월 26일 (금) 오전 11:34, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> There are a few minor typos in the comments. Fix these.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
> security/integrity/ima/ima_api.c | 2 +-
> security/integrity/ima/ima_main.c | 2 +-
> security/integrity/ima/ima_policy.c | 2 +-
> security/integrity/ima/ima_template_lib.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
> index a64fb0130b01..5b220a2fe573 100644
> --- a/security/integrity/ima/ima_api.c
> +++ b/security/integrity/ima/ima_api.c
> @@ -238,7 +238,7 @@ int ima_collect_measurement(struct integrity_iint_cache *iint,
> goto out;
>
> /*
> - * Dectecting file change is based on i_version. On filesystems
> + * Detecting file change is based on i_version. On filesystems
> * which do not support i_version, support is limited to an initial
> * measurement/appraisal/audit.
> */
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 8c6e4514d494..8ed6da428328 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -764,7 +764,7 @@ int ima_post_read_file(struct file *file, void *buf, loff_t size,
> * call to ima_post_load_data().
> *
> * Callers of this LSM hook can not measure, appraise, or audit the
> - * data provided by userspace. Enforce policy rules requring a file
> + * data provided by userspace. Enforce policy rules requiring a file
> * signature (eg. kexec'ed kernel image).
> *
> * For permission return 0, otherwise return -EACCES.
> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index 320ca80aacab..ad7e19208a69 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -429,7 +429,7 @@ static int ima_lsm_update_rule(struct ima_rule_entry *entry)
> /*
> * ima_lsm_copy_rule() shallow copied all references, except for the
> * LSM references, from entry to nentry so we only want to free the LSM
> - * references and the entry itself. All other memory refrences will now
> + * references and the entry itself. All other memory references will now
> * be owned by nentry.
> */
> ima_lsm_free_rule(entry);
> diff --git a/security/integrity/ima/ima_template_lib.c b/security/integrity/ima/ima_template_lib.c
> index ca017cae73eb..5a5d462ab36d 100644
> --- a/security/integrity/ima/ima_template_lib.c
> +++ b/security/integrity/ima/ima_template_lib.c
> @@ -272,7 +272,7 @@ static int ima_eventdigest_init_common(const u8 *digest, u32 digestsize,
> * digest formats:
> * - DATA_FMT_DIGEST: digest
> * - DATA_FMT_DIGEST_WITH_ALGO: [<hash algo>] + ':' + '\0' + digest,
> - * where <hash algo> is provided if the hash algoritm is not
> + * where <hash algo> is provided if the hash algorithm is not
> * SHA1 or MD5
> */
> u8 buffer[CRYPTO_MAX_ALG_NAME + 2 + IMA_MAX_DIGEST_SIZE] = { 0 };
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ima: Fix trivial typos in the comments
2022-01-12 8:46 ` Austin Kim
@ 2022-01-14 1:51 ` Mimi Zohar
2022-01-14 2:05 ` Joe Perches
2022-01-14 4:31 ` Austin Kim
0 siblings, 2 replies; 7+ messages in thread
From: Mimi Zohar @ 2022-01-14 1:51 UTC (permalink / raw)
To: Austin Kim, Austin Kim
Cc: dmitry.kasatkin, linux-integrity, linux-security-module, linux-kernel
Hi Austin,
On Wed, 2022-01-12 at 17:46 +0900, Austin Kim wrote:
> >
> > There are a few minor typos in the comments. Fix these.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
It would be really nice if checkpatch.pl would catch spelling mistakes
before the patch was upstreamed.
thanks,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ima: Fix trivial typos in the comments
2022-01-14 1:51 ` Mimi Zohar
@ 2022-01-14 2:05 ` Joe Perches
2022-01-14 13:27 ` Mimi Zohar
2022-01-14 4:31 ` Austin Kim
1 sibling, 1 reply; 7+ messages in thread
From: Joe Perches @ 2022-01-14 2:05 UTC (permalink / raw)
To: Mimi Zohar, Austin Kim, Austin Kim
Cc: dmitry.kasatkin, linux-integrity, linux-security-module, linux-kernel
On Thu, 2022-01-13 at 20:51 -0500, Mimi Zohar wrote:
> On Wed, 2022-01-12 at 17:46 +0900, Austin Kim wrote:
> > > There are a few minor typos in the comments. Fix these.
> It would be really nice if checkpatch.pl would catch spelling mistakes
> before the patch was upstreamed.
Try ./scripts/checkpatch.pl --strict
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ima: Fix trivial typos in the comments
2022-01-14 2:05 ` Joe Perches
@ 2022-01-14 13:27 ` Mimi Zohar
2022-01-15 2:10 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Mimi Zohar @ 2022-01-14 13:27 UTC (permalink / raw)
To: Joe Perches, Austin Kim, Austin Kim
Cc: dmitry.kasatkin, linux-integrity, linux-security-module, linux-kernel
Hi Joe,
On Thu, 2022-01-13 at 18:05 -0800, Joe Perches wrote:
> On Thu, 2022-01-13 at 20:51 -0500, Mimi Zohar wrote:
> > On Wed, 2022-01-12 at 17:46 +0900, Austin Kim wrote:
> > > > There are a few minor typos in the comments. Fix these.
> > It would be really nice if checkpatch.pl would catch spelling mistakes
> > before the patch was upstreamed.
>
> Try ./scripts/checkpatch.pl --strict
"--strict" didn't find the typos in comments, but "--codespell" did.
Nice!
thanks,
Mimi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ima: Fix trivial typos in the comments
2022-01-14 13:27 ` Mimi Zohar
@ 2022-01-15 2:10 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2022-01-15 2:10 UTC (permalink / raw)
To: Mimi Zohar, Austin Kim, Austin Kim
Cc: dmitry.kasatkin, linux-integrity, linux-security-module, linux-kernel
On Fri, 2022-01-14 at 08:27 -0500, Mimi Zohar wrote:
> Hi Joe,
>
> On Thu, 2022-01-13 at 18:05 -0800, Joe Perches wrote:
> > On Thu, 2022-01-13 at 20:51 -0500, Mimi Zohar wrote:
> > > On Wed, 2022-01-12 at 17:46 +0900, Austin Kim wrote:
> > > > > There are a few minor typos in the comments. Fix these.
> > > It would be really nice if checkpatch.pl would catch spelling mistakes
> > > before the patch was upstreamed.
> >
> > Try ./scripts/checkpatch.pl --strict
>
> "--strict" didn't find the typos in comments, but "--codespell" did.
> Nice!
Right, but it does depend on the particular typo.
checkpatch always uses the scripts/spelling.txt dictionary.
codespell isn't always installed on machines and has to be
enabled with that --codespell option.
Anyway, glad it works for you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ima: Fix trivial typos in the comments
2022-01-14 1:51 ` Mimi Zohar
2022-01-14 2:05 ` Joe Perches
@ 2022-01-14 4:31 ` Austin Kim
1 sibling, 0 replies; 7+ messages in thread
From: Austin Kim @ 2022-01-14 4:31 UTC (permalink / raw)
To: Mimi Zohar
Cc: Austin Kim, dmitry.kasatkin, linux-integrity,
linux-security-module, linux-kernel
2022년 1월 14일 (금) 오전 10:51, Mimi Zohar <zohar@linux.ibm.com>님이 작성:
>
> Hi Austin,
>
> On Wed, 2022-01-12 at 17:46 +0900, Austin Kim wrote:
>
> > >
> > > There are a few minor typos in the comments. Fix these.
> > >
> > > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
>
> It would be really nice if checkpatch.pl would catch spelling mistakes
> before the patch was upstreamed.
Thanks for feedback.
Let me make sure to upstream patch after executing
'./scripts/checkpatch.pl --strict' command.
BR,
Austin Kim
>
> thanks,
>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-15 2:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 21:44 [PATCH] ima: Fix trivial typos in the comments Austin Kim
2022-01-12 8:46 ` Austin Kim
2022-01-14 1:51 ` Mimi Zohar
2022-01-14 2:05 ` Joe Perches
2022-01-14 13:27 ` Mimi Zohar
2022-01-15 2:10 ` Joe Perches
2022-01-14 4:31 ` Austin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.