From: Daniel Kiper <dkiper@net-space.pl>
To: Nikita Ermakov <arei@altlinux.org>
Cc: GRUB development mailing list <grub-devel@gnu.org>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Leif Lindholm <leif.lindholm@linaro.org>,
Fu Wei <tekkamanninja@gmail.com>
Subject: Re: [PATCH v3 1/7] loader: drop argv[] argument in grub_initrd_load()
Date: Thu, 25 Nov 2021 14:23:50 +0100 [thread overview]
Message-ID: <20211125132350.jyi6745p2m2xshf4@tomti.i.net-space.pl> (raw)
In-Reply-To: <20211028203118.7908-2-arei@altlinux.org>
On Thu, Oct 28, 2021 at 11:31:13PM +0300, Nikita Ermakov wrote:
> In the case of an error grub_initrd_load() uses argv[] to print the
> filename that caused the error. It is also possible to obtain the
> filename from the file handles and there is no need to duplicate that
> information in argv[], so let's drop it.
>
> Signed-off-by: Nikita Ermakov <arei@altlinux.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
next prev parent reply other threads:[~2021-11-25 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 20:31 [PATCH v3 0/7] Add LoadFile2 and riscv Linux loader Nikita Ermakov
2021-10-28 20:31 ` [PATCH v3 1/7] loader: drop argv[] argument in grub_initrd_load() Nikita Ermakov
2021-11-25 13:23 ` Daniel Kiper [this message]
2021-10-28 20:31 ` [PATCH v3 2/7] efi: add definition of LoadFile2 protocol Nikita Ermakov
2021-11-25 13:30 ` Daniel Kiper
2021-10-28 20:31 ` [PATCH v3 3/7] efi: implemented LoadFile2 initrd loading protocol for Linux Nikita Ermakov
2021-11-25 15:52 ` Daniel Kiper
2022-04-15 20:00 ` dann frazier
2021-10-28 20:31 ` [PATCH v3 4/7] linux: ignore FDT unless we need to modify it Nikita Ermakov
2021-11-25 16:16 ` Daniel Kiper
2021-10-28 20:31 ` [PATCH v3 5/7] loader: Move arm64 linux loader to common code Nikita Ermakov
2021-11-25 16:20 ` Daniel Kiper
2021-10-28 20:31 ` [PATCH v3 6/7] RISC-V: Update image header Nikita Ermakov
2021-11-25 16:29 ` Daniel Kiper
2021-10-28 20:31 ` [PATCH v3 7/7] RISC-V: Use common linux loader Nikita Ermakov
2021-11-25 16:32 ` Daniel Kiper
2021-10-29 1:38 ` [PATCH v3 0/7] Add LoadFile2 and riscv Linux loader Heinrich Schuchardt
2021-11-24 14:50 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125132350.jyi6745p2m2xshf4@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=ard.biesheuvel@arm.com \
--cc=arei@altlinux.org \
--cc=grub-devel@gnu.org \
--cc=leif.lindholm@linaro.org \
--cc=tekkamanninja@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.