All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{, _pmd, pud}()
Date: Fri, 26 Nov 2021 02:02:22 +0800	[thread overview]
Message-ID: <202111260142.vX4mNkxP-lkp@intel.com> (raw)
In-Reply-To: <20211124191005.20783-10-joao.m.martins@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 5608 bytes --]

Hi Joao,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hnaz-mm/master]

url:    https://github.com/0day-ci/linux/commits/Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211125-031335
base:   https://github.com/hnaz/linux-mm master
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211126/202111260142.vX4mNkxP-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/44ce2eab00a4dc12253e01dd01be15b7e4d7d1ea
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joao-Martins/mm-device-dax-Introduce-compound-pages-in-devmap/20211125-031335
        git checkout 44ce2eab00a4dc12253e01dd01be15b7e4d7d1ea
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/dax/device.c: In function 'dev_dax_huge_fault':
>> drivers/dax/device.c:226:23: warning: variable 'fault_size' set but not used [-Wunused-but-set-variable]
     226 |         unsigned long fault_size;
         |                       ^~~~~~~~~~
   drivers/dax/device.c: At top level:
   drivers/dax/device.c:396:5: warning: no previous prototype for 'dev_dax_probe' [-Wmissing-prototypes]
     396 | int dev_dax_probe(struct dev_dax *dev_dax)
         |     ^~~~~~~~~~~~~


vim +/fault_size +226 drivers/dax/device.c

9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  221  
226ab561075f6f8 drivers/dax/device.c Dan Williams       2018-07-13  222  static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf,
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  223  		enum page_entry_size pe_size)
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  224  {
f42003917b4569a drivers/dax/dax.c    Dave Jiang         2017-02-22  225  	struct file *filp = vmf->vma->vm_file;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13 @226  	unsigned long fault_size;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  227  	vm_fault_t rc = VM_FAULT_SIGBUS;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  228  	int id;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  229  	pfn_t pfn;
5f0694b300b9fb8 drivers/dax/dax.c    Dan Williams       2017-01-30  230  	struct dev_dax *dev_dax = filp->private_data;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  231  
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  232  	dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm,
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  233  			(vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read",
762026203c0b87b drivers/dax/dax.c    Oliver O'Halloran  2017-04-12  234  			vmf->vma->vm_start, vmf->vma->vm_end, pe_size);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  235  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  236  	id = dax_read_lock();
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  237  	switch (pe_size) {
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  238  	case PE_SIZE_PTE:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  239  		fault_size = PAGE_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  240  		rc = __dev_dax_pte_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  241  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  242  	case PE_SIZE_PMD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  243  		fault_size = PMD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  244  		rc = __dev_dax_pmd_fault(dev_dax, vmf, &pfn);
9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  245  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  246  	case PE_SIZE_PUD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  247  		fault_size = PUD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  248  		rc = __dev_dax_pud_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  249  		break;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  250  	default:
54eafcc9e339aff drivers/dax/dax.c    Pushkar Jambhlekar 2017-04-11  251  		rc = VM_FAULT_SIGBUS;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  252  	}
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  253  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  254  	dax_read_unlock(id);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  255  
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  256  	return rc;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  257  }
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  258  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  parent reply	other threads:[~2021-11-25 18:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 19:09 [PATCH v6 00/10] mm, device-dax: Introduce compound pages in devmap Joao Martins
2021-11-24 19:09 ` [PATCH v6 01/10] memory-failure: fetch compound_head after pgmap_pfn_valid() Joao Martins
2021-11-24 19:09 ` [PATCH v6 02/10] mm/page_alloc: split prep_compound_page into head and tail subparts Joao Martins
2021-11-24 19:09 ` [PATCH v6 03/10] mm/page_alloc: refactor memmap_init_zone_device() page init Joao Martins
2021-11-24 19:09 ` [PATCH v6 04/10] mm/memremap: add ZONE_DEVICE support for compound pages Joao Martins
2021-11-25  6:11   ` Christoph Hellwig
2021-11-25 11:35     ` Joao Martins
2021-11-24 19:10 ` [PATCH v6 05/10] device-dax: use ALIGN() for determining pgoff Joao Martins
2021-11-24 19:10 ` [PATCH v6 06/10] device-dax: use struct_size() Joao Martins
2021-11-24 19:10 ` [PATCH v6 07/10] device-dax: ensure dev_dax->pgmap is valid for dynamic devices Joao Martins
2021-11-24 19:10 ` [PATCH v6 08/10] device-dax: factor out page mapping initialization Joao Martins
2021-11-24 19:10 ` [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}() Joao Martins
2021-11-25 11:42   ` Joao Martins
2021-11-26 18:39     ` Joao Martins
2021-11-29  7:32       ` Christoph Hellwig
2021-11-29 15:49         ` Joao Martins
2021-11-29 16:48           ` Christoph Hellwig
2021-11-29 17:20           ` Joao Martins
2021-11-25 18:02   ` kernel test robot [this message]
2021-11-24 19:10 ` [PATCH v6 10/10] device-dax: compound devmap support Joao Martins
2021-11-24 22:30 ` [PATCH v6 00/10] mm, device-dax: Introduce compound pages in devmap Dan Williams
2021-11-24 22:41   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111260142.vX4mNkxP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.