All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] max96712: Depend on VIDEO_V4L2
@ 2021-11-26  8:06 Sakari Ailus
  2021-11-26  8:25 ` Kieran Bingham
  2021-11-26 11:21 ` Niklas Söderlund
  0 siblings, 2 replies; 3+ messages in thread
From: Sakari Ailus @ 2021-11-26  8:06 UTC (permalink / raw)
  To: linux-media; +Cc: niklas.soderlund

Depend on VIDEO_V4L2 for the driver actually depends on it, failing to
compile otherwise.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
index 258d47644cbd..acde14fd5c4d 100644
--- a/drivers/staging/media/max96712/Kconfig
+++ b/drivers/staging/media/max96712/Kconfig
@@ -3,6 +3,7 @@ config VIDEO_MAX96712
 	tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
 	depends on I2C
 	depends on OF_GPIO
+	depends on VIDEO_V4L2
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] max96712: Depend on VIDEO_V4L2
  2021-11-26  8:06 [PATCH 1/1] max96712: Depend on VIDEO_V4L2 Sakari Ailus
@ 2021-11-26  8:25 ` Kieran Bingham
  2021-11-26 11:21 ` Niklas Söderlund
  1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-11-26  8:25 UTC (permalink / raw)
  To: Sakari Ailus, linux-media; +Cc: niklas.soderlund

Hi Sakari,

Quoting Sakari Ailus (2021-11-26 08:06:23)
> Depend on VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.

Given that this matches how I added the same for max9286, I think this
way is better than select.

Thanks,

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/staging/media/max96712/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..acde14fd5c4d 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -3,6 +3,7 @@ config VIDEO_MAX96712
>         tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
>         depends on I2C
>         depends on OF_GPIO
> +       depends on VIDEO_V4L2
>         select V4L2_FWNODE
>         select VIDEO_V4L2_SUBDEV_API
>         select MEDIA_CONTROLLER
> -- 
> 2.30.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] max96712: Depend on VIDEO_V4L2
  2021-11-26  8:06 [PATCH 1/1] max96712: Depend on VIDEO_V4L2 Sakari Ailus
  2021-11-26  8:25 ` Kieran Bingham
@ 2021-11-26 11:21 ` Niklas Söderlund
  1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2021-11-26 11:21 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: linux-media

Hi Sakari,

Thanks for your work.

On 2021-11-26 10:06:23 +0200, Sakari Ailus wrote:
> Depend on VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/staging/media/max96712/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..acde14fd5c4d 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -3,6 +3,7 @@ config VIDEO_MAX96712
>  	tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
>  	depends on I2C
>  	depends on OF_GPIO
> +	depends on VIDEO_V4L2
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
>  	select MEDIA_CONTROLLER
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-26 11:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26  8:06 [PATCH 1/1] max96712: Depend on VIDEO_V4L2 Sakari Ailus
2021-11-26  8:25 ` Kieran Bingham
2021-11-26 11:21 ` Niklas Söderlund

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.