All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleh Kravchenko <oleg@kaa.org.ua>
To: linux-mmc@vger.kernel.org, chrisball@gmail.com,
	ulf.hansson@linaro.org, patchwork-bot@kernel.org
Cc: Oleh Kravchenko <oleg@kaa.org.ua>
Subject: [PATCH v2] Replace strncpy() usage by printf()
Date: Fri, 26 Nov 2021 16:47:51 +0200	[thread overview]
Message-ID: <20211126144750.11537-1-oleg@kaa.org.ua> (raw)
In-Reply-To: <20211116105109.3830-1-oleg@kaa.org.ua>

Manpage of strncpy() says:
If there is no null byte among the first n bytes of src,
the string placed in dest will not be null-terminated.

Put \0 to the end of the buffer to ensure that
the destination string is NULL-terminated.

This patch also fixes a compile error with a newer version of GCC.

Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
---
 mmc_cmds.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/mmc_cmds.c b/mmc_cmds.c
index 73bd32a..753fcd9 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1392,7 +1392,6 @@ int do_read_extcsd(int nargs, char **argv)
 	__u32 regl;
 	int fd, ret;
 	char *device;
-	char lbuf[10];
 	const char *str;
 
 	if (nargs != 2) {
@@ -1834,9 +1833,7 @@ int do_read_extcsd(int nargs, char **argv)
 	}
 
 	if (ext_csd_rev >= 7) {
-                memset(lbuf, 0, sizeof(lbuf));
-		strncpy(lbuf, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION], 8);
-		printf("eMMC Firmware Version: %s\n", lbuf);
+		printf("eMMC Firmware Version: %.*s\n", 8, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]);
 		printf("eMMC Life Time Estimation A [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]: 0x%02x\n",
 			ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]);
 		printf("eMMC Life Time Estimation B [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]: 0x%02x\n",
-- 
2.32.0


  parent reply	other threads:[~2021-11-26 14:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 10:51 [PATCH] Fix strncpy() usage Oleh Kravchenko
2021-11-25 13:30 ` Ulf Hansson
2021-11-26 14:47 ` Oleh Kravchenko [this message]
2021-11-29 12:03   ` [PATCH v2] Replace strncpy() usage by printf() Ulf Hansson
2021-11-29 12:41 ` [PATCH v3] Use printf() to extract and print fw version Oleh Kravchenko
2021-11-29 15:05   ` [EXT] " Bean Huo (beanhuo)
2021-11-29 15:43     ` Oleh Kravchenko
2021-11-29 15:44 ` [PATCH v3] mmc-utils: " Oleh Kravchenko
2021-11-29 15:48 ` [PATCH v4] " Oleh Kravchenko
2021-11-30  7:42   ` Avri Altman
2021-11-30 12:07     ` Oleh Kravchenko
2021-11-30 12:14       ` Ulf Hansson
2021-11-30 14:25         ` Oleh Kravchenko
2021-11-30 14:27 ` [PATCH v5] " Oleh Kravchenko
2021-12-02 14:26   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126144750.11537-1-oleg@kaa.org.ua \
    --to=oleg@kaa.org.ua \
    --cc=chrisball@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=patchwork-bot@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.