All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
	Chris Ball <chrisball@gmail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v4] mmc-utils: Use printf() to extract and print fw version
Date: Tue, 30 Nov 2021 13:14:28 +0100	[thread overview]
Message-ID: <CAPDyKFqrTvV5BSerNwXT4tQNWwFdSZferccdMWGOe_RCC8hkCg@mail.gmail.com> (raw)
In-Reply-To: <42135dd8-c326-7607-acc9-3d55e9b98dad@kaa.org.ua>

On Tue, 30 Nov 2021 at 13:07, Oleh Kravchenko <oleg@kaa.org.ua> wrote:
>
> Hello Avri!
>
> 30.11.21 09:42, Avri Altman пише:
> > Hi,
> >> This patch also fixes a compile error with a newer version of GCC:
> >> error: '__builtin_strncpy' output may be truncated copying 8 bytes from a
> >> string of length 511 [-Werror=stringop-truncation]
> > You are reverting commit 0eea71e4f2 (mmc-utils: Fix for Firmware Version string printing).
> > Please use git revert and add an explanation in your commit log.
>
> I'm not reverting this commit.
> It's similar but not.

Right, this time we limit the print to 8 chars, which avoids garbage
from a non-NULL terminated string.

Perhaps we should add (similar to what we do for kernel commits):
Fixes: 0eea71e4f22a ("mmc-utils: Fix for Firmware Version string printing")

[...]

Kind regards
Uffe

  reply	other threads:[~2021-11-30 12:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 10:51 [PATCH] Fix strncpy() usage Oleh Kravchenko
2021-11-25 13:30 ` Ulf Hansson
2021-11-26 14:47 ` [PATCH v2] Replace strncpy() usage by printf() Oleh Kravchenko
2021-11-29 12:03   ` Ulf Hansson
2021-11-29 12:41 ` [PATCH v3] Use printf() to extract and print fw version Oleh Kravchenko
2021-11-29 15:05   ` [EXT] " Bean Huo (beanhuo)
2021-11-29 15:43     ` Oleh Kravchenko
2021-11-29 15:44 ` [PATCH v3] mmc-utils: " Oleh Kravchenko
2021-11-29 15:48 ` [PATCH v4] " Oleh Kravchenko
2021-11-30  7:42   ` Avri Altman
2021-11-30 12:07     ` Oleh Kravchenko
2021-11-30 12:14       ` Ulf Hansson [this message]
2021-11-30 14:25         ` Oleh Kravchenko
2021-11-30 14:27 ` [PATCH v5] " Oleh Kravchenko
2021-12-02 14:26   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFqrTvV5BSerNwXT4tQNWwFdSZferccdMWGOe_RCC8hkCg@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=chrisball@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=oleg@kaa.org.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.