* [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available @ 2021-11-26 15:20 Sven Schuchmann [not found] ` <YaED/p7O0iYQF6bW@lunn.ch> 0 siblings, 1 reply; 3+ messages in thread From: Sven Schuchmann @ 2021-11-26 15:20 UTC (permalink / raw) Cc: Sven Schuchmann, Woojung Huh, UNGLinuxDriver, David S. Miller, Jakub Kicinski, netdev, linux-usb, linux-kernel On most systems request for IRQ 0 will fail, phylib will print an error message and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ is available. Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de> --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 2bfb59ae0eaf..185e08c1af31 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2398,7 +2398,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) if (dev->domain_data.phyirq > 0) phydev->irq = dev->domain_data.phyirq; else - phydev->irq = 0; + phydev->irq = PHY_POLL; netdev_dbg(dev->net, "phydev->irq = %d\n", phydev->irq); /* set to AUTOMDIX */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <YaED/p7O0iYQF6bW@lunn.ch>]
* Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available [not found] ` <YaED/p7O0iYQF6bW@lunn.ch> @ 2021-11-26 19:34 ` Jakub Kicinski 2021-11-27 10:36 ` AW: " Sven Schuchmann 0 siblings, 1 reply; 3+ messages in thread From: Jakub Kicinski @ 2021-11-26 19:34 UTC (permalink / raw) To: Andrew Lunn, Sven Schuchmann Cc: Woojung Huh, UNGLinuxDriver, David S. Miller, netdev, linux-usb, linux-kernel On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote: > On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote: > > On most systems request for IRQ 0 will fail, phylib will print an error message > > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ > > is available. > > > > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP") right? ^ permalink raw reply [flat|nested] 3+ messages in thread
* AW: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available 2021-11-26 19:34 ` Jakub Kicinski @ 2021-11-27 10:36 ` Sven Schuchmann 0 siblings, 0 replies; 3+ messages in thread From: Sven Schuchmann @ 2021-11-27 10:36 UTC (permalink / raw) To: Jakub Kicinski, Andrew Lunn Cc: Woojung Huh, UNGLinuxDriver, David S. Miller, netdev, linux-usb, linux-kernel Hello Jakub, > Von: Jakub Kicinski <kuba@kernel.org> > Gesendet: Freitag, 26. November 2021 20:35 > An: Andrew Lunn <andrew@lunn.ch>; Sven Schuchmann <schuchmann@schleissheimer.de> > Cc: Woojung Huh <woojung.huh@microchip.com>; UNGLinuxDriver@microchip.com; David S. Miller > <davem@davemloft.net>; netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux- > kernel@vger.kernel.org > Betreff: Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if > no IRQ is available > > On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote: > > On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote: > > > On most systems request for IRQ 0 will fail, phylib will print an error message > > > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ > > > is available. > > > > > > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de> > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP") > > right? Seems right, will send a v2 Sven ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-27 10:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-11-26 15:20 [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available Sven Schuchmann [not found] ` <YaED/p7O0iYQF6bW@lunn.ch> 2021-11-26 19:34 ` Jakub Kicinski 2021-11-27 10:36 ` AW: " Sven Schuchmann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.