From: kernel test robot <lkp@intel.com>
To: Zoeb Mithaiwala <zoebm@google.com>, trivial@kernel.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, Zoeb Mithaiwala <zoebm@google.com>
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue
Date: Fri, 26 Nov 2021 16:54:14 +0800 [thread overview]
Message-ID: <202111261635.wXZz1PMT-lkp@intel.com> (raw)
In-Reply-To: <20211120080658.1070907-1-zoebm@google.com>
Hi Zoeb,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Zoeb-Mithaiwala/Staging-rtl8712-rtl871x_security-fixed-a-camel-case-variable-name-coding-style-issue/20211120-160918
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1189d2fb15a4b09b2e8dd01d60a0817d985d933d
config: m68k-randconfig-r026-20211121 (https://download.01.org/0day-ci/archive/20211126/202111261635.wXZz1PMT-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8c1ab61206da180488d1d32547a73288052736cd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zoeb-Mithaiwala/Staging-rtl8712-rtl871x_security-fixed-a-camel-case-variable-name-coding-style-issue/20211120-160918
git checkout 8c1ab61206da180488d1d32547a73288052736cd
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/rtl8712/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/rtl8712/rtl871x_security.c: In function 'secmicappendbyte':
>> drivers/staging/rtl8712/rtl871x_security.c:288:51: error: 'struct mic_data' has no member named 'n_bytes_in_m'; did you mean 'nbytes_in_m'?
288 | pmicdata->M |= ((u32)b) << (8 * pmicdata->n_bytes_in_m);
| ^~~~~~~~~~~~
| nbytes_in_m
vim +288 drivers/staging/rtl8712/rtl871x_security.c
284
285 static void secmicappendbyte(struct mic_data *pmicdata, u8 b)
286 {
287 /* Append the byte to our word-sized buffer */
> 288 pmicdata->M |= ((u32)b) << (8 * pmicdata->n_bytes_in_m);
289 pmicdata->nbytes_in_m++;
290 /* Process the word if it is full. */
291 if (pmicdata->nbytes_in_m >= 4) {
292 pmicdata->L ^= pmicdata->M;
293 pmicdata->R ^= ROL32(pmicdata->L, 17);
294 pmicdata->L += pmicdata->R;
295 pmicdata->R ^= ((pmicdata->L & 0xff00ff00) >> 8) |
296 ((pmicdata->L & 0x00ff00ff) << 8);
297 pmicdata->L += pmicdata->R;
298 pmicdata->R ^= ROL32(pmicdata->L, 3);
299 pmicdata->L += pmicdata->R;
300 pmicdata->R ^= ROR32(pmicdata->L, 2);
301 pmicdata->L += pmicdata->R;
302 /* Clear the buffer */
303 pmicdata->M = 0;
304 pmicdata->nbytes_in_m = 0;
305 }
306 }
307
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue
Date: Fri, 26 Nov 2021 16:54:14 +0800 [thread overview]
Message-ID: <202111261635.wXZz1PMT-lkp@intel.com> (raw)
In-Reply-To: <20211120080658.1070907-1-zoebm@google.com>
[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]
Hi Zoeb,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Zoeb-Mithaiwala/Staging-rtl8712-rtl871x_security-fixed-a-camel-case-variable-name-coding-style-issue/20211120-160918
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1189d2fb15a4b09b2e8dd01d60a0817d985d933d
config: m68k-randconfig-r026-20211121 (https://download.01.org/0day-ci/archive/20211126/202111261635.wXZz1PMT-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8c1ab61206da180488d1d32547a73288052736cd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zoeb-Mithaiwala/Staging-rtl8712-rtl871x_security-fixed-a-camel-case-variable-name-coding-style-issue/20211120-160918
git checkout 8c1ab61206da180488d1d32547a73288052736cd
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/rtl8712/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/rtl8712/rtl871x_security.c: In function 'secmicappendbyte':
>> drivers/staging/rtl8712/rtl871x_security.c:288:51: error: 'struct mic_data' has no member named 'n_bytes_in_m'; did you mean 'nbytes_in_m'?
288 | pmicdata->M |= ((u32)b) << (8 * pmicdata->n_bytes_in_m);
| ^~~~~~~~~~~~
| nbytes_in_m
vim +288 drivers/staging/rtl8712/rtl871x_security.c
284
285 static void secmicappendbyte(struct mic_data *pmicdata, u8 b)
286 {
287 /* Append the byte to our word-sized buffer */
> 288 pmicdata->M |= ((u32)b) << (8 * pmicdata->n_bytes_in_m);
289 pmicdata->nbytes_in_m++;
290 /* Process the word if it is full. */
291 if (pmicdata->nbytes_in_m >= 4) {
292 pmicdata->L ^= pmicdata->M;
293 pmicdata->R ^= ROL32(pmicdata->L, 17);
294 pmicdata->L += pmicdata->R;
295 pmicdata->R ^= ((pmicdata->L & 0xff00ff00) >> 8) |
296 ((pmicdata->L & 0x00ff00ff) << 8);
297 pmicdata->L += pmicdata->R;
298 pmicdata->R ^= ROL32(pmicdata->L, 3);
299 pmicdata->L += pmicdata->R;
300 pmicdata->R ^= ROR32(pmicdata->L, 2);
301 pmicdata->L += pmicdata->R;
302 /* Clear the buffer */
303 pmicdata->M = 0;
304 pmicdata->nbytes_in_m = 0;
305 }
306 }
307
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-11-26 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 8:06 [PATCH] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue Zoeb Mithaiwala
2021-11-20 8:26 ` Greg KH
2021-11-20 11:11 ` [PATCH 2/2] " Zoeb Mithaiwala
2021-11-22 10:39 ` Dan Carpenter
2021-11-22 17:03 ` [PATCH v3 3/3] Staging: rtl8712: Fixes a camel case variable name " Zoeb Mithaiwala
2021-11-24 10:01 ` Greg KH
2021-11-25 17:07 ` Zoeb Mithaiwala
2021-11-25 17:14 ` Greg KH
2021-11-24 10:00 ` [PATCH 2/2] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding " Greg KH
2021-11-22 15:22 ` [PATCH] " kernel test robot
2021-11-22 15:22 ` kernel test robot
2021-11-26 8:54 ` kernel test robot [this message]
2021-11-26 8:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111261635.wXZz1PMT-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=trivial@kernel.org \
--cc=zoebm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.