All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 3430/3897] drivers/dax/device.c:226:16: warning: variable 'fault_size' set but not used
@ 2021-11-26 14:38 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-26 14:38 UTC (permalink / raw)
  To: Joao Martins
  Cc: llvm, kbuild-all, Linux Memory Management List, Andrew Morton

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f30a24ed97b401416118756fa35fbe5d28f999e3
commit: c9deaee814e738981ed06a444ccbe50b4ff1526a [3430/3897] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()
config: x86_64-randconfig-a013-20211123 (https://download.01.org/0day-ci/archive/20211126/202111262232.JAaX7CBA-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9deaee814e738981ed06a444ccbe50b4ff1526a
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout c9deaee814e738981ed06a444ccbe50b4ff1526a
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/dax/device.c:226:16: warning: variable 'fault_size' set but not used [-Wunused-but-set-variable]
           unsigned long fault_size;
                         ^
   drivers/dax/device.c:396:5: warning: no previous prototype for function 'dev_dax_probe' [-Wmissing-prototypes]
   int dev_dax_probe(struct dev_dax *dev_dax)
       ^
   drivers/dax/device.c:396:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dev_dax_probe(struct dev_dax *dev_dax)
   ^
   static 
   2 warnings generated.


vim +/fault_size +226 drivers/dax/device.c

9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  221  
226ab561075f6f8 drivers/dax/device.c Dan Williams       2018-07-13  222  static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf,
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  223  		enum page_entry_size pe_size)
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  224  {
f42003917b4569a drivers/dax/dax.c    Dave Jiang         2017-02-22  225  	struct file *filp = vmf->vma->vm_file;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13 @226  	unsigned long fault_size;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  227  	vm_fault_t rc = VM_FAULT_SIGBUS;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  228  	int id;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  229  	pfn_t pfn;
5f0694b300b9fb8 drivers/dax/dax.c    Dan Williams       2017-01-30  230  	struct dev_dax *dev_dax = filp->private_data;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  231  
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  232  	dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm,
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  233  			(vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read",
762026203c0b87b drivers/dax/dax.c    Oliver O'Halloran  2017-04-12  234  			vmf->vma->vm_start, vmf->vma->vm_end, pe_size);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  235  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  236  	id = dax_read_lock();
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  237  	switch (pe_size) {
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  238  	case PE_SIZE_PTE:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  239  		fault_size = PAGE_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  240  		rc = __dev_dax_pte_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  241  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  242  	case PE_SIZE_PMD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  243  		fault_size = PMD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  244  		rc = __dev_dax_pmd_fault(dev_dax, vmf, &pfn);
9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  245  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  246  	case PE_SIZE_PUD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  247  		fault_size = PUD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  248  		rc = __dev_dax_pud_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  249  		break;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  250  	default:
54eafcc9e339aff drivers/dax/dax.c    Pushkar Jambhlekar 2017-04-11  251  		rc = VM_FAULT_SIGBUS;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  252  	}
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  253  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  254  	dax_read_unlock(id);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  255  
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  256  	return rc;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  257  }
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  258  

:::::: The code at line 226 was first introduced by commit
:::::: 2232c6382a453db73d2e723df1b52030066e135e device-dax: Enable page_mapping()

:::::: TO: Dan Williams <dan.j.williams@intel.com>
:::::: CC: Dave Jiang <dave.jiang@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [linux-next:master 3430/3897] drivers/dax/device.c:226:16: warning: variable 'fault_size' set but not used
@ 2021-11-26 14:38 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-11-26 14:38 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5984 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f30a24ed97b401416118756fa35fbe5d28f999e3
commit: c9deaee814e738981ed06a444ccbe50b4ff1526a [3430/3897] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()
config: x86_64-randconfig-a013-20211123 (https://download.01.org/0day-ci/archive/20211126/202111262232.JAaX7CBA-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9deaee814e738981ed06a444ccbe50b4ff1526a
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout c9deaee814e738981ed06a444ccbe50b4ff1526a
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/dax/device.c:226:16: warning: variable 'fault_size' set but not used [-Wunused-but-set-variable]
           unsigned long fault_size;
                         ^
   drivers/dax/device.c:396:5: warning: no previous prototype for function 'dev_dax_probe' [-Wmissing-prototypes]
   int dev_dax_probe(struct dev_dax *dev_dax)
       ^
   drivers/dax/device.c:396:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int dev_dax_probe(struct dev_dax *dev_dax)
   ^
   static 
   2 warnings generated.


vim +/fault_size +226 drivers/dax/device.c

9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  221  
226ab561075f6f8 drivers/dax/device.c Dan Williams       2018-07-13  222  static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf,
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  223  		enum page_entry_size pe_size)
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  224  {
f42003917b4569a drivers/dax/dax.c    Dave Jiang         2017-02-22  225  	struct file *filp = vmf->vma->vm_file;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13 @226  	unsigned long fault_size;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  227  	vm_fault_t rc = VM_FAULT_SIGBUS;
36bdac1e674debd drivers/dax/device.c Souptick Joarder   2018-09-04  228  	int id;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  229  	pfn_t pfn;
5f0694b300b9fb8 drivers/dax/dax.c    Dan Williams       2017-01-30  230  	struct dev_dax *dev_dax = filp->private_data;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  231  
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  232  	dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm,
6daaca522ab464d drivers/dax/device.c Dan Williams       2018-03-05  233  			(vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read",
762026203c0b87b drivers/dax/dax.c    Oliver O'Halloran  2017-04-12  234  			vmf->vma->vm_start, vmf->vma->vm_end, pe_size);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  235  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  236  	id = dax_read_lock();
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  237  	switch (pe_size) {
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  238  	case PE_SIZE_PTE:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  239  		fault_size = PAGE_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  240  		rc = __dev_dax_pte_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  241  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  242  	case PE_SIZE_PMD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  243  		fault_size = PMD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  244  		rc = __dev_dax_pmd_fault(dev_dax, vmf, &pfn);
9557feee39b75ce drivers/dax/dax.c    Dave Jiang         2017-02-24  245  		break;
c791ace1e747371 drivers/dax/dax.c    Dave Jiang         2017-02-24  246  	case PE_SIZE_PUD:
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  247  		fault_size = PUD_SIZE;
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  248  		rc = __dev_dax_pud_fault(dev_dax, vmf, &pfn);
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  249  		break;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  250  	default:
54eafcc9e339aff drivers/dax/dax.c    Pushkar Jambhlekar 2017-04-11  251  		rc = VM_FAULT_SIGBUS;
a2d581675d485eb drivers/dax/dax.c    Dave Jiang         2017-02-24  252  	}
2232c6382a453db drivers/dax/device.c Dan Williams       2018-07-13  253  
7b6be8444e0f0dd drivers/dax/device.c Dan Williams       2017-04-11  254  	dax_read_unlock(id);
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  255  
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  256  	return rc;
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  257  }
dee410792419aaa drivers/dax/dax.c    Dan Williams       2016-05-14  258  

:::::: The code at line 226 was first introduced by commit
:::::: 2232c6382a453db73d2e723df1b52030066e135e device-dax: Enable page_mapping()

:::::: TO: Dan Williams <dan.j.williams@intel.com>
:::::: CC: Dave Jiang <dave.jiang@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-26 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 14:38 [linux-next:master 3430/3897] drivers/dax/device.c:226:16: warning: variable 'fault_size' set but not used kernel test robot
2021-11-26 14:38 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.