* [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
@ 2021-11-27 1:17 ` Andi Shyti
0 siblings, 0 replies; 8+ messages in thread
From: Andi Shyti @ 2021-11-27 1:17 UTC (permalink / raw)
To: Intel GFX, DRI Devel; +Cc: Andi Shyti, Andi Shyti, Maciej Patelczyk
Change functions that always return '0' to be void type.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
5 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
index f103664b71d4..53b90b4f73d7 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
@@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
}
}
-int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
+void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
{
/* Flush any previous reset before applying for a new one */
wait_event(gt->reset.queue,
@@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
"Manually reset engine mask to %llx", val);
- return 0;
}
/*
@@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
static int __intel_gt_debugfs_reset_store(void *data, u64 val)
{
- return intel_gt_debugfs_reset_store(data, val);
+ intel_gt_debugfs_reset_store(data, val);
+
+ return 0;
}
DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
index e307ceb99031..a4baf8e7f068 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
@@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
/* functions that need to be accessed by the upper level non-gt interfaces */
int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
-int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
+void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
#endif /* INTEL_GT_DEBUGFS_H */
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 404dfa7673c6..7a30157aa9d3 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -20,38 +20,38 @@
#include "intel_uncore.h"
#include "vlv_sideband.h"
-int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
+void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
{
atomic_inc(>->user_wakeref);
intel_gt_pm_get(gt);
if (GRAPHICS_VER(gt->i915) >= 6)
intel_uncore_forcewake_user_get(gt->uncore);
-
- return 0;
}
-int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
+void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
{
if (GRAPHICS_VER(gt->i915) >= 6)
intel_uncore_forcewake_user_put(gt->uncore);
intel_gt_pm_put(gt);
atomic_dec(>->user_wakeref);
-
- return 0;
}
static int forcewake_user_open(struct inode *inode, struct file *file)
{
struct intel_gt *gt = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_open(gt);
+ intel_gt_pm_debugfs_forcewake_user_open(gt);
+
+ return 0;
}
static int forcewake_user_release(struct inode *inode, struct file *file)
{
struct intel_gt *gt = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_release(gt);
+ intel_gt_pm_debugfs_forcewake_user_release(gt);
+
+ return 0;
}
static const struct file_operations forcewake_user_fops = {
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
index a8457887ec65..0ace8c2da0ac 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
@@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
/* functions that need to be accessed by the upper level non-gt interfaces */
-int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
-int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
+void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
+void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
#endif /* INTEL_GT_PM_DEBUGFS_H */
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index fe638b5da7c0..88ef63f05ead 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
- return intel_gt_debugfs_reset_store(&i915->gt, val);
+ intel_gt_debugfs_reset_store(&i915->gt, val);
+
+ return 0;
}
DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
@@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
+ intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
+
+ return 0;
}
static int i915_forcewake_release(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
+ intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
+
+ return 0;
}
static const struct file_operations i915_forcewake_fops = {
--
2.34.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
@ 2021-11-27 1:17 ` Andi Shyti
0 siblings, 0 replies; 8+ messages in thread
From: Andi Shyti @ 2021-11-27 1:17 UTC (permalink / raw)
To: Intel GFX, DRI Devel; +Cc: Maciej Patelczyk
Change functions that always return '0' to be void type.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
5 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
index f103664b71d4..53b90b4f73d7 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
@@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
}
}
-int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
+void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
{
/* Flush any previous reset before applying for a new one */
wait_event(gt->reset.queue,
@@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
"Manually reset engine mask to %llx", val);
- return 0;
}
/*
@@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
static int __intel_gt_debugfs_reset_store(void *data, u64 val)
{
- return intel_gt_debugfs_reset_store(data, val);
+ intel_gt_debugfs_reset_store(data, val);
+
+ return 0;
}
DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
index e307ceb99031..a4baf8e7f068 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
@@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
/* functions that need to be accessed by the upper level non-gt interfaces */
int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
-int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
+void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
#endif /* INTEL_GT_DEBUGFS_H */
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 404dfa7673c6..7a30157aa9d3 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -20,38 +20,38 @@
#include "intel_uncore.h"
#include "vlv_sideband.h"
-int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
+void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
{
atomic_inc(>->user_wakeref);
intel_gt_pm_get(gt);
if (GRAPHICS_VER(gt->i915) >= 6)
intel_uncore_forcewake_user_get(gt->uncore);
-
- return 0;
}
-int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
+void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
{
if (GRAPHICS_VER(gt->i915) >= 6)
intel_uncore_forcewake_user_put(gt->uncore);
intel_gt_pm_put(gt);
atomic_dec(>->user_wakeref);
-
- return 0;
}
static int forcewake_user_open(struct inode *inode, struct file *file)
{
struct intel_gt *gt = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_open(gt);
+ intel_gt_pm_debugfs_forcewake_user_open(gt);
+
+ return 0;
}
static int forcewake_user_release(struct inode *inode, struct file *file)
{
struct intel_gt *gt = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_release(gt);
+ intel_gt_pm_debugfs_forcewake_user_release(gt);
+
+ return 0;
}
static const struct file_operations forcewake_user_fops = {
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
index a8457887ec65..0ace8c2da0ac 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
@@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
/* functions that need to be accessed by the upper level non-gt interfaces */
-int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
-int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
+void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
+void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
#endif /* INTEL_GT_PM_DEBUGFS_H */
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index fe638b5da7c0..88ef63f05ead 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
- return intel_gt_debugfs_reset_store(&i915->gt, val);
+ intel_gt_debugfs_reset_store(&i915->gt, val);
+
+ return 0;
}
DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
@@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
+ intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
+
+ return 0;
}
static int i915_forcewake_release(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
+ intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
+
+ return 0;
}
static const struct file_operations i915_forcewake_fops = {
--
2.34.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: Do not return '0' if there is nothing to return
2021-11-27 1:17 ` [Intel-gfx] " Andi Shyti
(?)
@ 2021-11-27 2:16 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-11-27 2:16 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6409 bytes --]
== Series Details ==
Series: drm/i915/debugfs: Do not return '0' if there is nothing to return
URL : https://patchwork.freedesktop.org/series/97340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10932 -> Patchwork_21689
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/index.html
Participating hosts (35 -> 34)
------------------------------
Missing (1): bat-adlp-6
Known issues
------------
Here are the changes found in Patchwork_21689 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][1] ([fdo#109271]) +21 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html
* igt@i915_selftest@live@gt_pm:
- fi-tgl-1115g4: [PASS][4] -> [DMESG-FAIL][5] ([i915#3987])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][6] -> [INCOMPLETE][7] ([i915#3921])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#533])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-bxt-dsi: NOTRUN -> [FAIL][10] ([i915#2426] / [i915#3363])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-bxt-dsi/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [FAIL][11] ([i915#4547]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
* igt@i915_selftest@live@perf:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#2867]) -> [PASS][14] +17 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-tgl-dsi/igt@i915_selftest@live@perf.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-tgl-dsi/igt@i915_selftest@live@perf.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-cfl-8109u: [DMESG-WARN][15] ([i915#165]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-cfl-8109u/igt@kms_force_connector_basic@force-connector-state.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-cfl-8109u/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][17] ([i915#165] / [i915#295]) -> [PASS][18] +13 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-cml-u2: [FAIL][19] ([fdo#103375]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/fi-cml-u2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/fi-cml-u2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10932 -> Patchwork_21689
CI-20190529: 20190529
CI_DRM_10932: 21f03b399057eded9c07745caef2d101d723118a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6293: bf11f87c27ad1cec3e60bd31c23080d19aa093f3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21689: 68a714f3db5da5b5b21324c17aa155ae2c574eaf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
68a714f3db5d drm/i915/debugfs: Do not return '0' if there is nothing to return
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/index.html
[-- Attachment #2: Type: text/html, Size: 7672 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/debugfs: Do not return '0' if there is nothing to return
2021-11-27 1:17 ` [Intel-gfx] " Andi Shyti
(?)
(?)
@ 2021-11-27 4:32 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-11-27 4:32 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30288 bytes --]
== Series Details ==
Series: drm/i915/debugfs: Do not return '0' if there is nothing to return
URL : https://patchwork.freedesktop.org/series/97340/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10932_full -> Patchwork_21689_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21689_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21689_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21689_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_selftest@all@check_plane_state:
- shard-tglb: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_selftest@all@check_plane_state.html
- shard-kbl: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl2/igt@kms_selftest@all@check_plane_state.html
- shard-apl: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl6/igt@kms_selftest@all@check_plane_state.html
Known issues
------------
Here are the changes found in Patchwork_21689_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [FAIL][27], [PASS][28]) ([i915#4392]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk9/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk8/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk1/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk2/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk9/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk9/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][54] ([i915#3002])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl9/igt@gem_create@create-massive.html
- shard-apl: NOTRUN -> [DMESG-WARN][55] ([i915#3002])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl4/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][58] ([i915#4547])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#2846])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][61] -> [FAIL][62] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][63] -> [FAIL][64] ([i915#2842])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#4613])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl3/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@gem_lmem_swapping@heavy-verify-random.html
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#4613])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#4613])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@gem_lmem_swapping@random-engines.html
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#284])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@gem_media_vme.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#4270])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#1937])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271]) +80 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl3/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][76] -> [INCOMPLETE][77] ([i915#3921])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-snb4/igt@i915_selftest@live@hangcheck.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][78] ([i915#3743]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3777])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#111615]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl4/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3886]) +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl10/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3689])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#3886]) +4 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111615] / [i915#3689])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [fdo#111827]) +9 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_chamelium@dp-hpd-for-each-pipe.html
* igt@kms_chamelium@hdmi-crc-single:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_chamelium@hdmi-crc-single.html
* igt@kms_chamelium@vga-frame-dump:
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [fdo#111827]) +9 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109284] / [fdo#111827]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [PASS][91] -> [DMESG-WARN][92] ([i915#1982])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-c-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [fdo#111827]) +4 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl6/igt@kms_color_chamelium@pipe-c-ctm-0-5.html
* igt@kms_content_protection@atomic-dpms:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111828]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][95] ([i915#1319])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl2/igt@kms_content_protection@legacy.html
- shard-apl: NOTRUN -> [TIMEOUT][96] ([i915#1319])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl6/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#3319])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271]) +82 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][99] -> [FAIL][100] ([i915#72])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_flip@2x-plain-flip-interruptible:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#111825]) +6 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@kms_flip@2x-plain-flip-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][102] -> [FAIL][103] ([i915#79])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [PASS][104] -> [INCOMPLETE][105] ([i915#456])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-tglb5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [PASS][106] -> [DMESG-WARN][107] ([i915#180]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-apl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl2/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [INCOMPLETE][108] ([i915#3699])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl10/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-skl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2672])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
- shard-glk: [PASS][110] -> [FAIL][111] ([i915#1888] / [i915#2546])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][112] ([fdo#109271]) +149 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl1/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#533])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][115] ([fdo#108145] / [i915#265]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
- shard-glk: NOTRUN -> [FAIL][116] ([fdo#108145] / [i915#265])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][117] -> [FAIL][118] ([fdo#108145] / [i915#265])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_cursor@pipe-d-overlay-size-64:
- shard-glk: NOTRUN -> [SKIP][119] ([fdo#109271]) +35 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_plane_cursor@pipe-d-overlay-size-64.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2733])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
- shard-glk: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2733])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#658]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#658]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
- shard-glk: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#658])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@page_flip:
- shard-apl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#658])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-apl3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][126] -> [SKIP][127] ([fdo#109441])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][128] ([i915#132] / [i915#3467])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2437])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@kms_writeback@writeback-pixel-formats.html
* igt@prime_nv_test@i915_nv_sharing:
- shard-tglb: NOTRUN -> [SKIP][130] ([fdo#109291]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@prime_nv_test@i915_nv_sharing.html
* igt@prime_vgem@fence-read-hang:
- shard-tglb: NOTRUN -> [SKIP][131] ([fdo#109295])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb1/igt@prime_vgem@fence-read-hang.html
* igt@sysfs_clients@fair-3:
- shard-glk: NOTRUN -> [SKIP][132] ([fdo#109271] / [i915#2994])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk4/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@sema-10:
- shard-skl: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#2994])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@sysfs_clients@sema-10.html
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][134] ([fdo#109271] / [i915#2994]) +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl2/igt@sysfs_clients@sema-50.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [PASS][135] -> [FAIL][136] ([i915#1731]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl4/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl6/igt@sysfs_heartbeat_interval@mixed@rcs0.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][137] ([i915#2842]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-iclb: [FAIL][139] ([i915#2842]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-iclb7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-iclb8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][141] ([fdo#109271]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][143] ([i915#2521]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@edp-1-pipe-a:
- shard-skl: [DMESG-WARN][145] ([i915#1982]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl6/igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@edp-1-pipe-a.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@edp-1-pipe-a.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][147] ([i915#118]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk2/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_color@pipe-c-invalid-ctm-matrix-sizes:
- {shard-rkl}: [SKIP][149] ([i915#4070]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-rkl-2/igt@kms_color@pipe-c-invalid-ctm-matrix-sizes.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-rkl-4/igt@kms_color@pipe-c-invalid-ctm-matrix-sizes.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
- {shard-rkl}: [SKIP][151] ([fdo#112022]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-rkl-4/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [INCOMPLETE][153] ([i915#2411] / [i915#456]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][155] ([i915#300]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][157] ([i915#2346]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][159] ([i915#2122]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10932/shard-glk1/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/shard-glk8/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][161] ([i915#79]) -> [PASS][162] +1 similar issue
[1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21689/index.html
[-- Attachment #2: Type: text/html, Size: 33624 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
2021-11-27 1:17 ` [Intel-gfx] " Andi Shyti
@ 2021-12-02 13:53 ` Maciej Patelczyk
-1 siblings, 0 replies; 8+ messages in thread
From: Maciej Patelczyk @ 2021-12-02 13:53 UTC (permalink / raw)
To: Andi Shyti, Intel GFX, DRI Devel; +Cc: Andi Shyti, Andi Shyti, Maciej Patelczyk
Andi Shyti <andi.shyti@linux.intel.com> writes:
> Change functions that always return '0' to be void type.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
> drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
> 5 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index f103664b71d4..53b90b4f73d7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
> }
> }
>
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> {
> /* Flush any previous reset before applying for a new one */
> wait_event(gt->reset.queue,
> @@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
>
> intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
> "Manually reset engine mask to %llx", val);
> - return 0;
> }
>
> /*
> @@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
>
> static int __intel_gt_debugfs_reset_store(void *data, u64 val)
> {
> - return intel_gt_debugfs_reset_store(data, val);
> + intel_gt_debugfs_reset_store(data, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> index e307ceb99031..a4baf8e7f068 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
>
> #endif /* INTEL_GT_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 404dfa7673c6..7a30157aa9d3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -20,38 +20,38 @@
> #include "intel_uncore.h"
> #include "vlv_sideband.h"
>
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> {
> atomic_inc(>->user_wakeref);
> intel_gt_pm_get(gt);
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_get(gt->uncore);
> -
> - return 0;
> }
>
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> {
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_put(gt->uncore);
> intel_gt_pm_put(gt);
> atomic_dec(>->user_wakeref);
> -
> - return 0;
> }
>
> static int forcewake_user_open(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(gt);
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
> +
> + return 0;
> }
>
> static int forcewake_user_release(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(gt);
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
> +
> + return 0;
> }
>
> static const struct file_operations forcewake_user_fops = {
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> index a8457887ec65..0ace8c2da0ac 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> @@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
> void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
>
> #endif /* INTEL_GT_PM_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fe638b5da7c0..88ef63f05ead 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
>
> - return intel_gt_debugfs_reset_store(&i915->gt, val);
> + intel_gt_debugfs_reset_store(&i915->gt, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
> @@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> +
> + return 0;
> }
>
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> +
> + return 0;
> }
>
> static const struct file_operations i915_forcewake_fops = {
> --
> 2.34.0
Reviewed-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
@ 2021-12-02 13:53 ` Maciej Patelczyk
0 siblings, 0 replies; 8+ messages in thread
From: Maciej Patelczyk @ 2021-12-02 13:53 UTC (permalink / raw)
To: Andi Shyti, Intel GFX, DRI Devel; +Cc: Maciej Patelczyk
Andi Shyti <andi.shyti@linux.intel.com> writes:
> Change functions that always return '0' to be void type.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
> drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
> 5 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index f103664b71d4..53b90b4f73d7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
> }
> }
>
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> {
> /* Flush any previous reset before applying for a new one */
> wait_event(gt->reset.queue,
> @@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
>
> intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
> "Manually reset engine mask to %llx", val);
> - return 0;
> }
>
> /*
> @@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
>
> static int __intel_gt_debugfs_reset_store(void *data, u64 val)
> {
> - return intel_gt_debugfs_reset_store(data, val);
> + intel_gt_debugfs_reset_store(data, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> index e307ceb99031..a4baf8e7f068 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
>
> #endif /* INTEL_GT_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 404dfa7673c6..7a30157aa9d3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -20,38 +20,38 @@
> #include "intel_uncore.h"
> #include "vlv_sideband.h"
>
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> {
> atomic_inc(>->user_wakeref);
> intel_gt_pm_get(gt);
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_get(gt->uncore);
> -
> - return 0;
> }
>
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> {
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_put(gt->uncore);
> intel_gt_pm_put(gt);
> atomic_dec(>->user_wakeref);
> -
> - return 0;
> }
>
> static int forcewake_user_open(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(gt);
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
> +
> + return 0;
> }
>
> static int forcewake_user_release(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(gt);
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
> +
> + return 0;
> }
>
> static const struct file_operations forcewake_user_fops = {
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> index a8457887ec65..0ace8c2da0ac 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> @@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
> void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
>
> #endif /* INTEL_GT_PM_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fe638b5da7c0..88ef63f05ead 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
>
> - return intel_gt_debugfs_reset_store(&i915->gt, val);
> + intel_gt_debugfs_reset_store(&i915->gt, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
> @@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> +
> + return 0;
> }
>
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> +
> + return 0;
> }
>
> static const struct file_operations i915_forcewake_fops = {
> --
> 2.34.0
Reviewed-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
2021-11-27 1:17 ` [Intel-gfx] " Andi Shyti
@ 2022-01-18 2:30 ` Andi Shyti
-1 siblings, 0 replies; 8+ messages in thread
From: Andi Shyti @ 2022-01-18 2:30 UTC (permalink / raw)
To: Andi Shyti, Lucas Martins De Marchi
Cc: Maciej Patelczyk, Intel GFX, Andi Shyti, DRI Devel
Ping... Lucas, do you mind merging this trivial refactoring?
Thanks,
Andi
On Sat, Nov 27, 2021 at 03:17:15AM +0200, Andi Shyti wrote:
> Change functions that always return '0' to be void type.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
> drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
> 5 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index f103664b71d4..53b90b4f73d7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
> }
> }
>
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> {
> /* Flush any previous reset before applying for a new one */
> wait_event(gt->reset.queue,
> @@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
>
> intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
> "Manually reset engine mask to %llx", val);
> - return 0;
> }
>
> /*
> @@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
>
> static int __intel_gt_debugfs_reset_store(void *data, u64 val)
> {
> - return intel_gt_debugfs_reset_store(data, val);
> + intel_gt_debugfs_reset_store(data, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> index e307ceb99031..a4baf8e7f068 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
>
> #endif /* INTEL_GT_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 404dfa7673c6..7a30157aa9d3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -20,38 +20,38 @@
> #include "intel_uncore.h"
> #include "vlv_sideband.h"
>
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> {
> atomic_inc(>->user_wakeref);
> intel_gt_pm_get(gt);
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_get(gt->uncore);
> -
> - return 0;
> }
>
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> {
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_put(gt->uncore);
> intel_gt_pm_put(gt);
> atomic_dec(>->user_wakeref);
> -
> - return 0;
> }
>
> static int forcewake_user_open(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(gt);
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
> +
> + return 0;
> }
>
> static int forcewake_user_release(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(gt);
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
> +
> + return 0;
> }
>
> static const struct file_operations forcewake_user_fops = {
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> index a8457887ec65..0ace8c2da0ac 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> @@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
> void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
>
> #endif /* INTEL_GT_PM_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fe638b5da7c0..88ef63f05ead 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
>
> - return intel_gt_debugfs_reset_store(&i915->gt, val);
> + intel_gt_debugfs_reset_store(&i915->gt, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
> @@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> +
> + return 0;
> }
>
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> +
> + return 0;
> }
>
> static const struct file_operations i915_forcewake_fops = {
> --
> 2.34.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return
@ 2022-01-18 2:30 ` Andi Shyti
0 siblings, 0 replies; 8+ messages in thread
From: Andi Shyti @ 2022-01-18 2:30 UTC (permalink / raw)
To: Andi Shyti, Lucas Martins De Marchi
Cc: Maciej Patelczyk, Intel GFX, DRI Devel
Ping... Lucas, do you mind merging this trivial refactoring?
Thanks,
Andi
On Sat, Nov 27, 2021 at 03:17:15AM +0200, Andi Shyti wrote:
> Change functions that always return '0' to be void type.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 7 ++++---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.h | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 16 ++++++++--------
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h | 4 ++--
> drivers/gpu/drm/i915/i915_debugfs.c | 12 +++++++++---
> 5 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index f103664b71d4..53b90b4f73d7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -29,7 +29,7 @@ int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val)
> }
> }
>
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
> {
> /* Flush any previous reset before applying for a new one */
> wait_event(gt->reset.queue,
> @@ -37,7 +37,6 @@ int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val)
>
> intel_gt_handle_error(gt, val, I915_ERROR_CAPTURE,
> "Manually reset engine mask to %llx", val);
> - return 0;
> }
>
> /*
> @@ -51,7 +50,9 @@ static int __intel_gt_debugfs_reset_show(void *data, u64 *val)
>
> static int __intel_gt_debugfs_reset_store(void *data, u64 val)
> {
> - return intel_gt_debugfs_reset_store(data, val);
> + intel_gt_debugfs_reset_store(data, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(reset_fops, __intel_gt_debugfs_reset_show,
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> index e307ceb99031..a4baf8e7f068 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -37,6 +37,6 @@ void intel_gt_debugfs_register_files(struct dentry *root,
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> int intel_gt_debugfs_reset_show(struct intel_gt *gt, u64 *val);
> -int intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
> +void intel_gt_debugfs_reset_store(struct intel_gt *gt, u64 val);
>
> #endif /* INTEL_GT_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 404dfa7673c6..7a30157aa9d3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -20,38 +20,38 @@
> #include "intel_uncore.h"
> #include "vlv_sideband.h"
>
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt)
> {
> atomic_inc(>->user_wakeref);
> intel_gt_pm_get(gt);
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_get(gt->uncore);
> -
> - return 0;
> }
>
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt)
> {
> if (GRAPHICS_VER(gt->i915) >= 6)
> intel_uncore_forcewake_user_put(gt->uncore);
> intel_gt_pm_put(gt);
> atomic_dec(>->user_wakeref);
> -
> - return 0;
> }
>
> static int forcewake_user_open(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(gt);
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
> +
> + return 0;
> }
>
> static int forcewake_user_release(struct inode *inode, struct file *file)
> {
> struct intel_gt *gt = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(gt);
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
> +
> + return 0;
> }
>
> static const struct file_operations forcewake_user_fops = {
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> index a8457887ec65..0ace8c2da0ac 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.h
> @@ -14,7 +14,7 @@ void intel_gt_pm_debugfs_register(struct intel_gt *gt, struct dentry *root);
> void intel_gt_pm_frequency_dump(struct intel_gt *gt, struct drm_printer *m);
>
> /* functions that need to be accessed by the upper level non-gt interfaces */
> -int intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> -int intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_open(struct intel_gt *gt);
> +void intel_gt_pm_debugfs_forcewake_user_release(struct intel_gt *gt);
>
> #endif /* INTEL_GT_PM_DEBUGFS_H */
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fe638b5da7c0..88ef63f05ead 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -565,7 +565,9 @@ static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
>
> - return intel_gt_debugfs_reset_store(&i915->gt, val);
> + intel_gt_debugfs_reset_store(&i915->gt, val);
> +
> + return 0;
> }
>
> DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
> @@ -711,14 +713,18 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_open(&i915->gt);
> +
> + return 0;
> }
>
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
>
> - return intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> + intel_gt_pm_debugfs_forcewake_user_release(&i915->gt);
> +
> + return 0;
> }
>
> static const struct file_operations i915_forcewake_fops = {
> --
> 2.34.0
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-01-18 2:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-27 1:17 [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return Andi Shyti
2021-11-27 1:17 ` [Intel-gfx] " Andi Shyti
2021-11-27 2:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-27 4:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-02 13:53 ` [PATCH] " Maciej Patelczyk
2021-12-02 13:53 ` [Intel-gfx] " Maciej Patelczyk
2022-01-18 2:30 ` Andi Shyti
2022-01-18 2:30 ` [Intel-gfx] " Andi Shyti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.