All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Allow rfddump and rfdformat to work on a test mtdram
@ 2021-11-27 15:35 Sean Young
  2022-03-16  9:40 ` Sean Young
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2021-11-27 15:35 UTC (permalink / raw)
  To: linux-mtd; +Cc: David Oberhollenzer, Richard Weinberger

rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow
use of MTD_RAM for testing purposes"), which is in kernel v5.15.

Signed-off-by: Sean Young <sean@mess.org>
---
 nor-utils/rfddump.c   | 2 +-
 nor-utils/rfdformat.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nor-utils/rfddump.c b/nor-utils/rfddump.c
index 01ab4c2..c85c067 100644
--- a/nor-utils/rfddump.c
+++ b/nor-utils/rfddump.c
@@ -200,7 +200,7 @@ int main(int argc, char *argv[])
 			return 1;
 		}
 
-		if (mtd_info.type != MTD_NORFLASH) {
+		if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 			fprintf(stderr, "%s: wrong type\n", rfd.mtd_filename);
 			close(fd);
 			return 2;
diff --git a/nor-utils/rfdformat.c b/nor-utils/rfdformat.c
index 0a3d9fb..160c081 100644
--- a/nor-utils/rfdformat.c
+++ b/nor-utils/rfdformat.c
@@ -108,7 +108,7 @@ int main(int argc, char *argv[])
 		return 1;
 	}
 
-	if (mtd_info.type != MTD_NORFLASH) {
+	if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
 		fprintf(stderr, "%s: not NOR flash\n", mtd_filename);
 		close(fd);
 		return 2;
-- 
2.33.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] Allow rfddump and rfdformat to work on a test mtdram
  2021-11-27 15:35 [PATCH] Allow rfddump and rfdformat to work on a test mtdram Sean Young
@ 2022-03-16  9:40 ` Sean Young
  2022-03-16 10:49   ` Richard Weinberger
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2022-03-16  9:40 UTC (permalink / raw)
  To: linux-mtd; +Cc: David Oberhollenzer, Richard Weinberger

On Sat, Nov 27, 2021 at 03:35:50PM +0000, Sean Young wrote:
> rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow
> use of MTD_RAM for testing purposes"), which is in kernel v5.15.

Why has this patch been marked "not applicable", also without any discussion?

https://patchwork.ozlabs.org/project/linux-mtd/patch/20211127153550.GA23039@gofer.mess.org/

So the kernel side changes are accepted and merged upstream, but the
necessary user space changes are "not applicable". Is there a plan to revert
the kernel side commits?


Sean

> 
> Signed-off-by: Sean Young <sean@mess.org>
> ---
>  nor-utils/rfddump.c   | 2 +-
>  nor-utils/rfdformat.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/nor-utils/rfddump.c b/nor-utils/rfddump.c
> index 01ab4c2..c85c067 100644
> --- a/nor-utils/rfddump.c
> +++ b/nor-utils/rfddump.c
> @@ -200,7 +200,7 @@ int main(int argc, char *argv[])
>  			return 1;
>  		}
>  
> -		if (mtd_info.type != MTD_NORFLASH) {
> +		if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
>  			fprintf(stderr, "%s: wrong type\n", rfd.mtd_filename);
>  			close(fd);
>  			return 2;
> diff --git a/nor-utils/rfdformat.c b/nor-utils/rfdformat.c
> index 0a3d9fb..160c081 100644
> --- a/nor-utils/rfdformat.c
> +++ b/nor-utils/rfdformat.c
> @@ -108,7 +108,7 @@ int main(int argc, char *argv[])
>  		return 1;
>  	}
>  
> -	if (mtd_info.type != MTD_NORFLASH) {
> +	if (mtd_info.type != MTD_NORFLASH && mtd_info.type != MTD_RAM) {
>  		fprintf(stderr, "%s: not NOR flash\n", mtd_filename);
>  		close(fd);
>  		return 2;
> -- 
> 2.33.1
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] Allow rfddump and rfdformat to work on a test mtdram
  2022-03-16  9:40 ` Sean Young
@ 2022-03-16 10:49   ` Richard Weinberger
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2022-03-16 10:49 UTC (permalink / raw)
  To: Sean Young; +Cc: linux-mtd, david oberhollenzer

----- Ursprüngliche Mail -----
> Von: "Sean Young" <sean@mess.org>
> An: "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: "david oberhollenzer" <david.oberhollenzer@sigma-star.at>, "richard" <richard@nod.at>
> Gesendet: Mittwoch, 16. März 2022 10:40:20
> Betreff: Re: [PATCH] Allow rfddump and rfdformat to work on a test mtdram

> On Sat, Nov 27, 2021 at 03:35:50PM +0000, Sean Young wrote:
>> rfd can be used with mtdram since commit e03a81213a9c ("mtd: rfd_ftl: allow
>> use of MTD_RAM for testing purposes"), which is in kernel v5.15.
> 
> Why has this patch been marked "not applicable", also without any discussion?
> 
> https://patchwork.ozlabs.org/project/linux-mtd/patch/20211127153550.GA23039@gofer.mess.org/
> 
> So the kernel side changes are accepted and merged upstream, but the
> necessary user space changes are "not applicable". Is there a plan to revert
> the kernel side commits?

I don't think "not applicable" was set on purpose.
David?

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-16 10:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-27 15:35 [PATCH] Allow rfddump and rfdformat to work on a test mtdram Sean Young
2022-03-16  9:40 ` Sean Young
2022-03-16 10:49   ` Richard Weinberger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.