* drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
@ 2021-11-28 23:43 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-28 23:43 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 21669 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Cai Huoqing <caihuoqing@baidu.com>
CC: "Marc Kleine-Budde" <mkl@pengutronix.de>
Hi Cai,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d06c942efea40e1701ade200477a7449008d9f24
commit: ac4224087312d7212bd3411f1e393f4b7cb1ff15 can: rcar: Kconfig: Add helper dependency on COMPILE_TEST
date: 3 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 3 months ago
config: openrisc-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211129/202111290746.NTFgroUw-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
drivers/net/can/rcar/rcar_canfd.c:1878 rcar_canfd_probe() error: uninitialized symbol 'g_irq'.
drivers/net/can/rcar/rcar_canfd.c:1887 rcar_canfd_probe() error: uninitialized symbol 'g_recc_irq'.
drivers/net/can/rcar/rcar_canfd.c:1897 rcar_canfd_probe() error: uninitialized symbol 'g_err_irq'.
vim +/ch_irq +1869 drivers/net/can/rcar/rcar_canfd.c
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1753
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1754 static int rcar_canfd_probe(struct platform_device *pdev)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1755 {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1756 void __iomem *addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1757 u32 sts, ch, fcan_freq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1758 struct rcar_canfd_global *gpriv;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1759 struct device_node *of_child;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1760 unsigned long channels_mask = 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1761 int err, ch_irq, g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1762 int g_err_irq, g_recc_irq;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1763 bool fdmode = true; /* CAN FD only mode - default */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1764 enum rcanfd_chip_id chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1765
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1766 chip_id = (uintptr_t)of_device_get_match_data(&pdev->dev);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1767
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1768 if (of_property_read_bool(pdev->dev.of_node, "renesas,no-can-fd"))
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1769 fdmode = false; /* Classical CAN only mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1770
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1771 of_child = of_get_child_by_name(pdev->dev.of_node, "channel0");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1772 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1773 channels_mask |= BIT(0); /* Channel 0 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1774
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1775 of_child = of_get_child_by_name(pdev->dev.of_node, "channel1");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1776 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1777 channels_mask |= BIT(1); /* Channel 1 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1778
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1779 if (chip_id == RENESAS_RCAR_GEN3) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1780 ch_irq = platform_get_irq_byname_optional(pdev, "ch_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1781 if (ch_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1782 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1783 ch_irq = platform_get_irq(pdev, 0);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1784 if (ch_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1785 return ch_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1786 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1787
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1788 g_irq = platform_get_irq_byname_optional(pdev, "g_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1789 if (g_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1790 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1791 g_irq = platform_get_irq(pdev, 1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1792 if (g_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1793 return g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1794 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1795 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1796 g_err_irq = platform_get_irq_byname(pdev, "g_err");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1797 if (g_err_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1798 return g_err_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1799
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1800 g_recc_irq = platform_get_irq_byname(pdev, "g_recc");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1801 if (g_recc_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1802 return g_recc_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1803 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1804
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1805 /* Global controller context */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1806 gpriv = devm_kzalloc(&pdev->dev, sizeof(*gpriv), GFP_KERNEL);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1807 if (!gpriv) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1808 err = -ENOMEM;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1809 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1810 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1811 gpriv->pdev = pdev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1812 gpriv->channels_mask = channels_mask;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1813 gpriv->fdmode = fdmode;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1814 gpriv->chip_id = chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1815
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1816 if (gpriv->chip_id == RENESAS_RZG2L) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1817 gpriv->rstc1 = devm_reset_control_get_exclusive(&pdev->dev, "rstp_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1818 if (IS_ERR(gpriv->rstc1))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1819 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc1),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1820 "failed to get rstp_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1821
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1822 gpriv->rstc2 = devm_reset_control_get_exclusive(&pdev->dev, "rstc_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1823 if (IS_ERR(gpriv->rstc2))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1824 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc2),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1825 "failed to get rstc_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1826 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1827
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1828 /* Peripheral clock */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1829 gpriv->clkp = devm_clk_get(&pdev->dev, "fck");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1830 if (IS_ERR(gpriv->clkp)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1831 err = PTR_ERR(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1832 dev_err(&pdev->dev, "cannot get peripheral clock, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1833 err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1834 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1835 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1836
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1837 /* fCAN clock: Pick External clock. If not available fallback to
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1838 * CANFD clock
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1839 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1840 gpriv->can_clk = devm_clk_get(&pdev->dev, "can_clk");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1841 if (IS_ERR(gpriv->can_clk) || (clk_get_rate(gpriv->can_clk) == 0)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1842 gpriv->can_clk = devm_clk_get(&pdev->dev, "canfd");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1843 if (IS_ERR(gpriv->can_clk)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1844 err = PTR_ERR(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1845 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1846 "cannot get canfd clock, error %d\n", err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1847 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1848 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1849 gpriv->fcan = RCANFD_CANFDCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1850
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1851 } else {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1852 gpriv->fcan = RCANFD_EXTCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1853 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1854 fcan_freq = clk_get_rate(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1855
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1856 if (gpriv->fcan == RCANFD_CANFDCLK && gpriv->chip_id == RENESAS_RCAR_GEN3)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1857 /* CANFD clock is further divided by (1/2) within the IP */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1858 fcan_freq /= 2;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1859
ac9921ded292bf YueHaibing 2019-10-15 1860 addr = devm_platform_ioremap_resource(pdev, 0);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1861 if (IS_ERR(addr)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1862 err = PTR_ERR(addr);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1863 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1864 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1865 gpriv->base = addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1866
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1867 /* Request IRQ that's common for both channels */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1868 if (gpriv->chip_id == RENESAS_RCAR_GEN3) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1869 err = devm_request_irq(&pdev->dev, ch_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1870 rcar_canfd_channel_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1871 "canfd.ch_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1872 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1873 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1874 ch_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1875 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1876 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1877
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1878 err = devm_request_irq(&pdev->dev, g_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1879 rcar_canfd_global_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1880 "canfd.g_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1881 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1882 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1883 g_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1884 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1885 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1886 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1887 err = devm_request_irq(&pdev->dev, g_recc_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1888 rcar_canfd_global_receive_fifo_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1889 "canfd.g_recc", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1890
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1891 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1892 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1893 g_recc_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1894 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1895 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1896
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1897 err = devm_request_irq(&pdev->dev, g_err_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1898 rcar_canfd_global_err_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1899 "canfd.g_err", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1900 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1901 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1902 g_err_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1903 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1904 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1905 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1906
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1907 err = reset_control_reset(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1908 if (err)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1909 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1910 err = reset_control_reset(gpriv->rstc2);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1911 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1912 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1913 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1914 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1915
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1916 /* Enable peripheral clock for register access */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1917 err = clk_prepare_enable(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1918 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1919 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1920 "failed to enable peripheral clock, error %d\n", err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1921 goto fail_reset;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1922 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1923
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1924 err = rcar_canfd_reset_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1925 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1926 dev_err(&pdev->dev, "reset controller failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1927 goto fail_clk;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1928 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1929
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1930 /* Controller in Global reset & Channel reset mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1931 rcar_canfd_configure_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1932
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1933 /* Configure per channel attributes */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1934 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1935 /* Configure Channel's Rx fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1936 rcar_canfd_configure_rx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1937
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1938 /* Configure Channel's Tx (Common) fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1939 rcar_canfd_configure_tx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1940
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1941 /* Configure receive rules */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1942 rcar_canfd_configure_afl_rules(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1943 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1944
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1945 /* Configure common interrupts */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1946 rcar_canfd_enable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1947
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1948 /* Start Global operation mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1949 rcar_canfd_update_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GMDC_MASK,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1950 RCANFD_GCTR_GMDC_GOPM);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1951
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1952 /* Verify mode change */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1953 err = readl_poll_timeout((gpriv->base + RCANFD_GSTS), sts,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1954 !(sts & RCANFD_GSTS_GNOPM), 2, 500000);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1955 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1956 dev_err(&pdev->dev, "global operational mode failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1957 goto fail_mode;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1958 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1959
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1960 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1961 err = rcar_canfd_channel_probe(gpriv, ch, fcan_freq);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1962 if (err)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1963 goto fail_channel;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1964 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1965
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1966 platform_set_drvdata(pdev, gpriv);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1967 dev_info(&pdev->dev, "global operational state (clk %d, fdmode %d)\n",
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1968 gpriv->fcan, gpriv->fdmode);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1969 return 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1970
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1971 fail_channel:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1972 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1973 rcar_canfd_channel_remove(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1974 fail_mode:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1975 rcar_canfd_disable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1976 fail_clk:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1977 clk_disable_unprepare(gpriv->clkp);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1978 fail_reset:
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1979 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1980 reset_control_assert(gpriv->rstc2);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1981 fail_dev:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1982 return err;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1983 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1984
:::::: The code at line 1869 was first introduced by commit
:::::: dd3bd23eb438919aeeb73a7116642731ef8f73a8 can: rcar_canfd: Add Renesas R-Car CAN FD driver
:::::: TO: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
:::::: CC: Marc Kleine-Budde <mkl@pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
@ 2021-11-10 22:12 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-10 22:12 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 21597 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Cai Huoqing <caihuoqing@baidu.com>
CC: "Marc Kleine-Budde" <mkl@pengutronix.de>
Hi Cai,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 881007522c8fcc3785c75432dbb149ca1b78e106
commit: ac4224087312d7212bd3411f1e393f4b7cb1ff15 can: rcar: Kconfig: Add helper dependency on COMPILE_TEST
date: 3 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 3 months ago
config: mips-randconfig-m031-20211012 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
drivers/net/can/rcar/rcar_canfd.c:1878 rcar_canfd_probe() error: uninitialized symbol 'g_irq'.
drivers/net/can/rcar/rcar_canfd.c:1887 rcar_canfd_probe() error: uninitialized symbol 'g_recc_irq'.
drivers/net/can/rcar/rcar_canfd.c:1897 rcar_canfd_probe() error: uninitialized symbol 'g_err_irq'.
vim +/ch_irq +1869 drivers/net/can/rcar/rcar_canfd.c
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1753
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1754 static int rcar_canfd_probe(struct platform_device *pdev)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1755 {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1756 void __iomem *addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1757 u32 sts, ch, fcan_freq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1758 struct rcar_canfd_global *gpriv;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1759 struct device_node *of_child;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1760 unsigned long channels_mask = 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1761 int err, ch_irq, g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1762 int g_err_irq, g_recc_irq;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1763 bool fdmode = true; /* CAN FD only mode - default */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1764 enum rcanfd_chip_id chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1765
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1766 chip_id = (uintptr_t)of_device_get_match_data(&pdev->dev);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1767
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1768 if (of_property_read_bool(pdev->dev.of_node, "renesas,no-can-fd"))
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1769 fdmode = false; /* Classical CAN only mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1770
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1771 of_child = of_get_child_by_name(pdev->dev.of_node, "channel0");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1772 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1773 channels_mask |= BIT(0); /* Channel 0 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1774
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1775 of_child = of_get_child_by_name(pdev->dev.of_node, "channel1");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1776 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1777 channels_mask |= BIT(1); /* Channel 1 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1778
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1779 if (chip_id == RENESAS_RCAR_GEN3) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1780 ch_irq = platform_get_irq_byname_optional(pdev, "ch_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1781 if (ch_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1782 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1783 ch_irq = platform_get_irq(pdev, 0);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1784 if (ch_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1785 return ch_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1786 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1787
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1788 g_irq = platform_get_irq_byname_optional(pdev, "g_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1789 if (g_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1790 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1791 g_irq = platform_get_irq(pdev, 1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1792 if (g_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1793 return g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1794 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1795 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1796 g_err_irq = platform_get_irq_byname(pdev, "g_err");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1797 if (g_err_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1798 return g_err_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1799
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1800 g_recc_irq = platform_get_irq_byname(pdev, "g_recc");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1801 if (g_recc_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1802 return g_recc_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1803 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1804
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1805 /* Global controller context */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1806 gpriv = devm_kzalloc(&pdev->dev, sizeof(*gpriv), GFP_KERNEL);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1807 if (!gpriv) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1808 err = -ENOMEM;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1809 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1810 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1811 gpriv->pdev = pdev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1812 gpriv->channels_mask = channels_mask;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1813 gpriv->fdmode = fdmode;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1814 gpriv->chip_id = chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1815
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1816 if (gpriv->chip_id == RENESAS_RZG2L) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1817 gpriv->rstc1 = devm_reset_control_get_exclusive(&pdev->dev, "rstp_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1818 if (IS_ERR(gpriv->rstc1))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1819 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc1),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1820 "failed to get rstp_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1821
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1822 gpriv->rstc2 = devm_reset_control_get_exclusive(&pdev->dev, "rstc_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1823 if (IS_ERR(gpriv->rstc2))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1824 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc2),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1825 "failed to get rstc_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1826 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1827
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1828 /* Peripheral clock */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1829 gpriv->clkp = devm_clk_get(&pdev->dev, "fck");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1830 if (IS_ERR(gpriv->clkp)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1831 err = PTR_ERR(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1832 dev_err(&pdev->dev, "cannot get peripheral clock, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1833 err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1834 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1835 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1836
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1837 /* fCAN clock: Pick External clock. If not available fallback to
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1838 * CANFD clock
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1839 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1840 gpriv->can_clk = devm_clk_get(&pdev->dev, "can_clk");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1841 if (IS_ERR(gpriv->can_clk) || (clk_get_rate(gpriv->can_clk) == 0)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1842 gpriv->can_clk = devm_clk_get(&pdev->dev, "canfd");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1843 if (IS_ERR(gpriv->can_clk)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1844 err = PTR_ERR(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1845 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1846 "cannot get canfd clock, error %d\n", err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1847 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1848 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1849 gpriv->fcan = RCANFD_CANFDCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1850
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1851 } else {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1852 gpriv->fcan = RCANFD_EXTCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1853 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1854 fcan_freq = clk_get_rate(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1855
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1856 if (gpriv->fcan == RCANFD_CANFDCLK && gpriv->chip_id == RENESAS_RCAR_GEN3)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1857 /* CANFD clock is further divided by (1/2) within the IP */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1858 fcan_freq /= 2;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1859
ac9921ded292bf YueHaibing 2019-10-15 1860 addr = devm_platform_ioremap_resource(pdev, 0);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1861 if (IS_ERR(addr)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1862 err = PTR_ERR(addr);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1863 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1864 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1865 gpriv->base = addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1866
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1867 /* Request IRQ that's common for both channels */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1868 if (gpriv->chip_id == RENESAS_RCAR_GEN3) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1869 err = devm_request_irq(&pdev->dev, ch_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1870 rcar_canfd_channel_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1871 "canfd.ch_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1872 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1873 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1874 ch_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1875 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1876 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1877
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1878 err = devm_request_irq(&pdev->dev, g_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1879 rcar_canfd_global_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1880 "canfd.g_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1881 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1882 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1883 g_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1884 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1885 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1886 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1887 err = devm_request_irq(&pdev->dev, g_recc_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1888 rcar_canfd_global_receive_fifo_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1889 "canfd.g_recc", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1890
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1891 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1892 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1893 g_recc_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1894 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1895 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1896
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1897 err = devm_request_irq(&pdev->dev, g_err_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1898 rcar_canfd_global_err_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1899 "canfd.g_err", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1900 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1901 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1902 g_err_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1903 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1904 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1905 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1906
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1907 err = reset_control_reset(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1908 if (err)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1909 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1910 err = reset_control_reset(gpriv->rstc2);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1911 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1912 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1913 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1914 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1915
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1916 /* Enable peripheral clock for register access */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1917 err = clk_prepare_enable(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1918 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1919 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1920 "failed to enable peripheral clock, error %d\n", err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1921 goto fail_reset;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1922 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1923
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1924 err = rcar_canfd_reset_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1925 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1926 dev_err(&pdev->dev, "reset controller failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1927 goto fail_clk;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1928 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1929
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1930 /* Controller in Global reset & Channel reset mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1931 rcar_canfd_configure_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1932
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1933 /* Configure per channel attributes */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1934 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1935 /* Configure Channel's Rx fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1936 rcar_canfd_configure_rx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1937
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1938 /* Configure Channel's Tx (Common) fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1939 rcar_canfd_configure_tx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1940
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1941 /* Configure receive rules */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1942 rcar_canfd_configure_afl_rules(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1943 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1944
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1945 /* Configure common interrupts */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1946 rcar_canfd_enable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1947
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1948 /* Start Global operation mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1949 rcar_canfd_update_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GMDC_MASK,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1950 RCANFD_GCTR_GMDC_GOPM);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1951
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1952 /* Verify mode change */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1953 err = readl_poll_timeout((gpriv->base + RCANFD_GSTS), sts,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1954 !(sts & RCANFD_GSTS_GNOPM), 2, 500000);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1955 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1956 dev_err(&pdev->dev, "global operational mode failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1957 goto fail_mode;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1958 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1959
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1960 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1961 err = rcar_canfd_channel_probe(gpriv, ch, fcan_freq);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1962 if (err)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1963 goto fail_channel;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1964 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1965
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1966 platform_set_drvdata(pdev, gpriv);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1967 dev_info(&pdev->dev, "global operational state (clk %d, fdmode %d)\n",
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1968 gpriv->fcan, gpriv->fdmode);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1969 return 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1970
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1971 fail_channel:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1972 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1973 rcar_canfd_channel_remove(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1974 fail_mode:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1975 rcar_canfd_disable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1976 fail_clk:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1977 clk_disable_unprepare(gpriv->clkp);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1978 fail_reset:
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1979 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1980 reset_control_assert(gpriv->rstc2);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1981 fail_dev:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1982 return err;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1983 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1984
:::::: The code at line 1869 was first introduced by commit
:::::: dd3bd23eb438919aeeb73a7116642731ef8f73a8 can: rcar_canfd: Add Renesas R-Car CAN FD driver
:::::: TO: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
:::::: CC: Marc Kleine-Budde <mkl@pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32244 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
@ 2021-11-08 23:59 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-08 23:59 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 21539 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Cai Huoqing <caihuoqing@baidu.com>
CC: "Marc Kleine-Budde" <mkl@pengutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
commit: ac4224087312d7212bd3411f1e393f4b7cb1ff15 can: rcar: Kconfig: Add helper dependency on COMPILE_TEST
date: 3 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 3 months ago
config: s390-randconfig-m031-20211028 (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq'.
drivers/net/can/rcar/rcar_canfd.c:1878 rcar_canfd_probe() error: uninitialized symbol 'g_irq'.
drivers/net/can/rcar/rcar_canfd.c:1887 rcar_canfd_probe() error: uninitialized symbol 'g_recc_irq'.
drivers/net/can/rcar/rcar_canfd.c:1897 rcar_canfd_probe() error: uninitialized symbol 'g_err_irq'.
vim +/ch_irq +1869 drivers/net/can/rcar/rcar_canfd.c
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1753
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1754 static int rcar_canfd_probe(struct platform_device *pdev)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1755 {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1756 void __iomem *addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1757 u32 sts, ch, fcan_freq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1758 struct rcar_canfd_global *gpriv;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1759 struct device_node *of_child;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1760 unsigned long channels_mask = 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1761 int err, ch_irq, g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1762 int g_err_irq, g_recc_irq;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1763 bool fdmode = true; /* CAN FD only mode - default */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1764 enum rcanfd_chip_id chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1765
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1766 chip_id = (uintptr_t)of_device_get_match_data(&pdev->dev);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1767
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1768 if (of_property_read_bool(pdev->dev.of_node, "renesas,no-can-fd"))
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1769 fdmode = false; /* Classical CAN only mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1770
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1771 of_child = of_get_child_by_name(pdev->dev.of_node, "channel0");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1772 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1773 channels_mask |= BIT(0); /* Channel 0 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1774
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1775 of_child = of_get_child_by_name(pdev->dev.of_node, "channel1");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1776 if (of_child && of_device_is_available(of_child))
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1777 channels_mask |= BIT(1); /* Channel 1 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1778
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1779 if (chip_id == RENESAS_RCAR_GEN3) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1780 ch_irq = platform_get_irq_byname_optional(pdev, "ch_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1781 if (ch_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1782 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1783 ch_irq = platform_get_irq(pdev, 0);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1784 if (ch_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1785 return ch_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1786 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1787
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1788 g_irq = platform_get_irq_byname_optional(pdev, "g_int");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1789 if (g_irq < 0) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1790 /* For backward compatibility get irq by index */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1791 g_irq = platform_get_irq(pdev, 1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1792 if (g_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1793 return g_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1794 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1795 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1796 g_err_irq = platform_get_irq_byname(pdev, "g_err");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1797 if (g_err_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1798 return g_err_irq;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1799
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1800 g_recc_irq = platform_get_irq_byname(pdev, "g_recc");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1801 if (g_recc_irq < 0)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1802 return g_recc_irq;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1803 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1804
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1805 /* Global controller context */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1806 gpriv = devm_kzalloc(&pdev->dev, sizeof(*gpriv), GFP_KERNEL);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1807 if (!gpriv) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1808 err = -ENOMEM;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1809 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1810 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1811 gpriv->pdev = pdev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1812 gpriv->channels_mask = channels_mask;
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1813 gpriv->fdmode = fdmode;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1814 gpriv->chip_id = chip_id;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1815
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1816 if (gpriv->chip_id == RENESAS_RZG2L) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1817 gpriv->rstc1 = devm_reset_control_get_exclusive(&pdev->dev, "rstp_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1818 if (IS_ERR(gpriv->rstc1))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1819 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc1),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1820 "failed to get rstp_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1821
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1822 gpriv->rstc2 = devm_reset_control_get_exclusive(&pdev->dev, "rstc_n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1823 if (IS_ERR(gpriv->rstc2))
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1824 return dev_err_probe(&pdev->dev, PTR_ERR(gpriv->rstc2),
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1825 "failed to get rstc_n\n");
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1826 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1827
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1828 /* Peripheral clock */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1829 gpriv->clkp = devm_clk_get(&pdev->dev, "fck");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1830 if (IS_ERR(gpriv->clkp)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1831 err = PTR_ERR(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1832 dev_err(&pdev->dev, "cannot get peripheral clock, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1833 err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1834 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1835 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1836
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1837 /* fCAN clock: Pick External clock. If not available fallback to
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1838 * CANFD clock
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1839 */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1840 gpriv->can_clk = devm_clk_get(&pdev->dev, "can_clk");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1841 if (IS_ERR(gpriv->can_clk) || (clk_get_rate(gpriv->can_clk) == 0)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1842 gpriv->can_clk = devm_clk_get(&pdev->dev, "canfd");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1843 if (IS_ERR(gpriv->can_clk)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1844 err = PTR_ERR(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1845 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1846 "cannot get canfd clock, error %d\n", err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1847 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1848 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1849 gpriv->fcan = RCANFD_CANFDCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1850
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1851 } else {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1852 gpriv->fcan = RCANFD_EXTCLK;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1853 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1854 fcan_freq = clk_get_rate(gpriv->can_clk);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1855
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1856 if (gpriv->fcan == RCANFD_CANFDCLK && gpriv->chip_id == RENESAS_RCAR_GEN3)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1857 /* CANFD clock is further divided by (1/2) within the IP */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1858 fcan_freq /= 2;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1859
ac9921ded292bf YueHaibing 2019-10-15 1860 addr = devm_platform_ioremap_resource(pdev, 0);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1861 if (IS_ERR(addr)) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1862 err = PTR_ERR(addr);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1863 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1864 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1865 gpriv->base = addr;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1866
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1867 /* Request IRQ that's common for both channels */
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1868 if (gpriv->chip_id == RENESAS_RCAR_GEN3) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1869 err = devm_request_irq(&pdev->dev, ch_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1870 rcar_canfd_channel_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1871 "canfd.ch_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1872 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1873 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1874 ch_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1875 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1876 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1877
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 @1878 err = devm_request_irq(&pdev->dev, g_irq,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1879 rcar_canfd_global_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1880 "canfd.g_int", gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1881 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1882 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1883 g_irq, err);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1884 goto fail_dev;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1885 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1886 } else {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1887 err = devm_request_irq(&pdev->dev, g_recc_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1888 rcar_canfd_global_receive_fifo_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1889 "canfd.g_recc", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1890
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1891 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1892 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1893 g_recc_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1894 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1895 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1896
76e9353a80e9e9 Lad Prabhakar 2021-07-27 @1897 err = devm_request_irq(&pdev->dev, g_err_irq,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1898 rcar_canfd_global_err_interrupt, 0,
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1899 "canfd.g_err", gpriv);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1900 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1901 dev_err(&pdev->dev, "devm_request_irq(%d) failed, error %d\n",
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1902 g_err_irq, err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1903 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1904 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1905 }
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1906
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1907 err = reset_control_reset(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1908 if (err)
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1909 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1910 err = reset_control_reset(gpriv->rstc2);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1911 if (err) {
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1912 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1913 goto fail_dev;
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1914 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1915
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1916 /* Enable peripheral clock for register access */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1917 err = clk_prepare_enable(gpriv->clkp);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1918 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1919 dev_err(&pdev->dev,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1920 "failed to enable peripheral clock, error %d\n", err);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1921 goto fail_reset;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1922 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1923
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1924 err = rcar_canfd_reset_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1925 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1926 dev_err(&pdev->dev, "reset controller failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1927 goto fail_clk;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1928 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1929
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1930 /* Controller in Global reset & Channel reset mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1931 rcar_canfd_configure_controller(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1932
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1933 /* Configure per channel attributes */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1934 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1935 /* Configure Channel's Rx fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1936 rcar_canfd_configure_rx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1937
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1938 /* Configure Channel's Tx (Common) fifo */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1939 rcar_canfd_configure_tx(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1940
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1941 /* Configure receive rules */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1942 rcar_canfd_configure_afl_rules(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1943 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1944
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1945 /* Configure common interrupts */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1946 rcar_canfd_enable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1947
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1948 /* Start Global operation mode */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1949 rcar_canfd_update_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GMDC_MASK,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1950 RCANFD_GCTR_GMDC_GOPM);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1951
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1952 /* Verify mode change */
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1953 err = readl_poll_timeout((gpriv->base + RCANFD_GSTS), sts,
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1954 !(sts & RCANFD_GSTS_GNOPM), 2, 500000);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1955 if (err) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1956 dev_err(&pdev->dev, "global operational mode failed\n");
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1957 goto fail_mode;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1958 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1959
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1960 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS) {
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1961 err = rcar_canfd_channel_probe(gpriv, ch, fcan_freq);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1962 if (err)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1963 goto fail_channel;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1964 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1965
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1966 platform_set_drvdata(pdev, gpriv);
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1967 dev_info(&pdev->dev, "global operational state (clk %d, fdmode %d)\n",
6f4c2eea353809 Ramesh Shanmugasundaram 2016-06-22 1968 gpriv->fcan, gpriv->fdmode);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1969 return 0;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1970
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1971 fail_channel:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1972 for_each_set_bit(ch, &gpriv->channels_mask, RCANFD_NUM_CHANNELS)
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1973 rcar_canfd_channel_remove(gpriv, ch);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1974 fail_mode:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1975 rcar_canfd_disable_global_interrupts(gpriv);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1976 fail_clk:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1977 clk_disable_unprepare(gpriv->clkp);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1978 fail_reset:
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1979 reset_control_assert(gpriv->rstc1);
76e9353a80e9e9 Lad Prabhakar 2021-07-27 1980 reset_control_assert(gpriv->rstc2);
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1981 fail_dev:
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1982 return err;
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1983 }
dd3bd23eb43891 Ramesh Shanmugasundaram 2016-06-17 1984
:::::: The code at line 1869 was first introduced by commit
:::::: dd3bd23eb438919aeeb73a7116642731ef8f73a8 can: rcar_canfd: Add Renesas R-Car CAN FD driver
:::::: TO: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
:::::: CC: Marc Kleine-Budde <mkl@pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31006 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-28 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28 23:43 drivers/net/can/rcar/rcar_canfd.c:1869 rcar_canfd_probe() error: uninitialized symbol 'ch_irq' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-11-10 22:12 kernel test robot
2021-11-08 23:59 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.