All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six
@ 2021-11-29 16:50 Gwenhael Goavec-Merou
  2021-11-29 16:50 ` [Buildroot] [PATCH/next 2/2] package/gnuradio: fix host python name Gwenhael Goavec-Merou
  2021-12-04 20:24 ` [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Gwenhael Goavec-Merou @ 2021-11-29 16:50 UTC (permalink / raw)
  To: buildroot; +Cc: Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

host-python-six needs host-python (aka python2) but since
commit e9df5b0fc3f6e8bb36deedefb392bbc968116ee7 python-mako is
python3 only. python-six is build using python2 and python-mako with
python3 and gnuradio build fails with:

-- Python checking for python >= 2.7
-- Python checking for python >= 2.7 - found
--
-- Python checking for mako >= 0.4.2
-- Python checking for mako >= 0.4.2 - not found

This patch force the use of host-python3-six to be coherent

Fixes:
- http://autobuild.buildroot.net/results/2685fb00883e6936e24ca1f17b693e6e1c13c9fa

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/gnuradio/gnuradio.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 2272a1162a..5616039559 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -22,7 +22,7 @@ endif
 GNURADIO_DEPENDENCIES = \
 	host-python3 \
 	host-python-mako \
-	host-python-six \
+	host-python3-six \
 	host-swig \
 	boost \
 	log4cpp \
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH/next 2/2] package/gnuradio: fix host python name
  2021-11-29 16:50 [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Gwenhael Goavec-Merou
@ 2021-11-29 16:50 ` Gwenhael Goavec-Merou
  2021-12-04 20:24 ` [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Gwenhael Goavec-Merou @ 2021-11-29 16:50 UTC (permalink / raw)
  To: buildroot; +Cc: Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

$(HOST_DIR)/bin/python symlink is only created when BR2_PACKAGE_PYTHON3 is
set.
When only host-python3 is used this symlink is not present and build fails
with:

-- User set python executable buildroot/output/host/bin/python
-- Found PythonInterp: buildroot/output/host/bin/python (Required is at least version "2.7.6")
CMake Error at cmake/Modules/GrPython.cmake:40 (if):
  if given arguments:

    "VERSION_EQUAL" "3"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:368 (include)


-- Configuring incomplete, errors occurred!

This patch set explicitly PYTHON_EXECUTABLE to $(HOST_DIR)/bin/python3

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/gnuradio/gnuradio.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 5616039559..658357398d 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -29,7 +29,7 @@ GNURADIO_DEPENDENCIES = \
 	gmp
 
 GNURADIO_CONF_OPTS = \
-	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python \
+	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
 	-DENABLE_DEFAULT=OFF \
 	-DENABLE_VOLK=ON \
 	-DENABLE_GNURADIO_RUNTIME=ON \
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six
  2021-11-29 16:50 [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Gwenhael Goavec-Merou
  2021-11-29 16:50 ` [Buildroot] [PATCH/next 2/2] package/gnuradio: fix host python name Gwenhael Goavec-Merou
@ 2021-12-04 20:24 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-12-04 20:24 UTC (permalink / raw)
  To: Gwenhael Goavec-Merou; +Cc: Gwenhael Goavec-Merou, buildroot

On Mon, 29 Nov 2021 17:50:00 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> host-python-six needs host-python (aka python2) but since
> commit e9df5b0fc3f6e8bb36deedefb392bbc968116ee7 python-mako is
> python3 only. python-six is build using python2 and python-mako with
> python3 and gnuradio build fails with:
> 
> -- Python checking for python >= 2.7
> -- Python checking for python >= 2.7 - found
> --
> -- Python checking for mako >= 0.4.2
> -- Python checking for mako >= 0.4.2 - not found
> 
> This patch force the use of host-python3-six to be coherent
> 
> Fixes:
> - http://autobuild.buildroot.net/results/2685fb00883e6936e24ca1f17b693e6e1c13c9fa
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  package/gnuradio/gnuradio.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied to next. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-04 20:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 16:50 [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Gwenhael Goavec-Merou
2021-11-29 16:50 ` [Buildroot] [PATCH/next 2/2] package/gnuradio: fix host python name Gwenhael Goavec-Merou
2021-12-04 20:24 ` [Buildroot] [PATCH/next 1/2] package/gnuradio: force python3-six Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.