From: Pratyush Yadav <p.yadav@ti.com> To: Rob Herring <robh+dt@kernel.org> Cc: Mark Brown <broonie@kernel.org>, Nishanth Menon <nm@ti.com>, Michael Walle <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Tudor Ambarus <tudor.ambarus@microchip.com>, Vignesh Raghavendra <vigneshr@ti.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org> Subject: Re: [PATCH v3 0/3] Add bindings for peripheral-specific SPI controller properties Date: Mon, 29 Nov 2021 23:39:35 +0530 [thread overview] Message-ID: <20211129180935.nmymboy336hllly7@ti.com> (raw) In-Reply-To: <20211109181911.2251-1-p.yadav@ti.com> Hi Rob, On 09/11/21 11:49PM, Pratyush Yadav wrote: > Hi, > > This series adds bindings for peripheral-specific SPI controller properties. > See patch 1 for more info on the motivations behind this. > > This is the best approach that I came up with with my limited knowledge > of JSON schema. It has some limitations that are mentioned in patch 1. I > don't know of any better ways to model this. Suggestions are welcome! Do you plan to take this series through your tree or should I poke Mark about it? > > Changes in v3: > - s/slave/peripheral/g > - Drop the | on description. > - Drop the compatible property. > > Changes in v2: > - Move other subnode properties listed in spi-controller.yaml to > spi-slave-props.yaml > - Move the Cadence controller-specific properties out of > spi-slave-props.yaml. They will be added in a separate file. > - Add a reference to spi-slave-props.yaml in spi-controller.yaml. > - Update description. > > Pratyush Yadav (3): > spi: dt-bindings: add schema listing peripheral-specific properties > spi: dt-bindings: cdns,qspi-nor: Move peripheral-specific properties > out > dt-bindings: mtd: spi-nor: Add a reference to > spi-peripheral-props.yaml > > .../bindings/mtd/jedec,spi-nor.yaml | 3 +- > .../spi/cdns,qspi-nor-peripheral-props.yaml | 42 +++++++++ > .../bindings/spi/cdns,qspi-nor.yaml | 33 ------- > .../bindings/spi/spi-controller.yaml | 69 +------------- > .../bindings/spi/spi-peripheral-props.yaml | 89 +++++++++++++++++++ > 5 files changed, 135 insertions(+), 101 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml > create mode 100644 Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > > -- > 2.33.1.835.ge9e5ba39a7 > -- Regards, Pratyush Yadav Texas Instruments Inc. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com> To: Rob Herring <robh+dt@kernel.org> Cc: Mark Brown <broonie@kernel.org>, Nishanth Menon <nm@ti.com>, Michael Walle <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Tudor Ambarus <tudor.ambarus@microchip.com>, Vignesh Raghavendra <vigneshr@ti.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org> Subject: Re: [PATCH v3 0/3] Add bindings for peripheral-specific SPI controller properties Date: Mon, 29 Nov 2021 23:39:35 +0530 [thread overview] Message-ID: <20211129180935.nmymboy336hllly7@ti.com> (raw) In-Reply-To: <20211109181911.2251-1-p.yadav@ti.com> Hi Rob, On 09/11/21 11:49PM, Pratyush Yadav wrote: > Hi, > > This series adds bindings for peripheral-specific SPI controller properties. > See patch 1 for more info on the motivations behind this. > > This is the best approach that I came up with with my limited knowledge > of JSON schema. It has some limitations that are mentioned in patch 1. I > don't know of any better ways to model this. Suggestions are welcome! Do you plan to take this series through your tree or should I poke Mark about it? > > Changes in v3: > - s/slave/peripheral/g > - Drop the | on description. > - Drop the compatible property. > > Changes in v2: > - Move other subnode properties listed in spi-controller.yaml to > spi-slave-props.yaml > - Move the Cadence controller-specific properties out of > spi-slave-props.yaml. They will be added in a separate file. > - Add a reference to spi-slave-props.yaml in spi-controller.yaml. > - Update description. > > Pratyush Yadav (3): > spi: dt-bindings: add schema listing peripheral-specific properties > spi: dt-bindings: cdns,qspi-nor: Move peripheral-specific properties > out > dt-bindings: mtd: spi-nor: Add a reference to > spi-peripheral-props.yaml > > .../bindings/mtd/jedec,spi-nor.yaml | 3 +- > .../spi/cdns,qspi-nor-peripheral-props.yaml | 42 +++++++++ > .../bindings/spi/cdns,qspi-nor.yaml | 33 ------- > .../bindings/spi/spi-controller.yaml | 69 +------------- > .../bindings/spi/spi-peripheral-props.yaml | 89 +++++++++++++++++++ > 5 files changed, 135 insertions(+), 101 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml > create mode 100644 Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > > -- > 2.33.1.835.ge9e5ba39a7 > -- Regards, Pratyush Yadav Texas Instruments Inc.
next prev parent reply other threads:[~2021-11-29 18:10 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-09 18:19 [PATCH v3 0/3] Add bindings for peripheral-specific SPI controller properties Pratyush Yadav 2021-11-09 18:19 ` Pratyush Yadav 2021-11-09 18:19 ` [PATCH v3 1/3] spi: dt-bindings: add schema listing peripheral-specific properties Pratyush Yadav 2021-11-09 18:19 ` Pratyush Yadav 2021-11-18 22:23 ` Rob Herring 2021-11-18 22:23 ` Rob Herring 2021-11-09 18:19 ` [PATCH v3 2/3] spi: dt-bindings: cdns,qspi-nor: Move peripheral-specific properties out Pratyush Yadav 2021-11-09 18:19 ` [PATCH v3 2/3] spi: dt-bindings: cdns, qspi-nor: " Pratyush Yadav 2021-11-18 22:23 ` [PATCH v3 2/3] spi: dt-bindings: cdns,qspi-nor: " Rob Herring 2021-11-18 22:23 ` Rob Herring 2021-11-09 18:19 ` [PATCH v3 3/3] dt-bindings: mtd: spi-nor: Add a reference to spi-peripheral-props.yaml Pratyush Yadav 2021-11-09 18:19 ` Pratyush Yadav 2021-11-18 22:23 ` Rob Herring 2021-11-18 22:23 ` Rob Herring 2021-11-29 18:09 ` Pratyush Yadav [this message] 2021-11-29 18:09 ` [PATCH v3 0/3] Add bindings for peripheral-specific SPI controller properties Pratyush Yadav 2021-11-29 18:15 ` Mark Brown 2021-11-29 18:15 ` Mark Brown 2021-11-30 9:36 ` Pratyush Yadav 2021-11-30 9:36 ` Pratyush Yadav 2021-12-01 18:32 ` Mark Brown 2021-12-01 18:32 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211129180935.nmymboy336hllly7@ti.com \ --to=p.yadav@ti.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=nm@ti.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.