From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com Subject: [PATCH v7 02/16] firmware: arm_scmi: Set polling timeout to max_rx_timeout_ms Date: Mon, 29 Nov 2021 19:11:42 +0000 [thread overview] Message-ID: <20211129191156.29322-3-cristian.marussi@arm.com> (raw) In-Reply-To: <20211129191156.29322-1-cristian.marussi@arm.com> Use transport specific transmission timeout (max_rx_timeout_ms) also for polling transactions. Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 3cf161f3bcc7..568562121f64 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -724,8 +724,6 @@ static void xfer_put(const struct scmi_protocol_handle *ph, __scmi_xfer_put(&info->tx_minfo, xfer); } -#define SCMI_MAX_POLL_TO_NS (100 * NSEC_PER_USEC) - static bool scmi_xfer_done_no_timeout(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer, ktime_t stop) { @@ -799,7 +797,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, } if (xfer->hdr.poll_completion) { - ktime_t stop = ktime_add_ns(ktime_get(), SCMI_MAX_POLL_TO_NS); + ktime_t stop = ktime_add_ms(ktime_get(), + info->desc->max_rx_timeout_ms); spin_until_cond(scmi_xfer_done_no_timeout(cinfo, xfer, stop)); if (ktime_before(ktime_get(), stop)) { -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com Subject: [PATCH v7 02/16] firmware: arm_scmi: Set polling timeout to max_rx_timeout_ms Date: Mon, 29 Nov 2021 19:11:42 +0000 [thread overview] Message-ID: <20211129191156.29322-3-cristian.marussi@arm.com> (raw) In-Reply-To: <20211129191156.29322-1-cristian.marussi@arm.com> Use transport specific transmission timeout (max_rx_timeout_ms) also for polling transactions. Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 3cf161f3bcc7..568562121f64 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -724,8 +724,6 @@ static void xfer_put(const struct scmi_protocol_handle *ph, __scmi_xfer_put(&info->tx_minfo, xfer); } -#define SCMI_MAX_POLL_TO_NS (100 * NSEC_PER_USEC) - static bool scmi_xfer_done_no_timeout(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer, ktime_t stop) { @@ -799,7 +797,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, } if (xfer->hdr.poll_completion) { - ktime_t stop = ktime_add_ns(ktime_get(), SCMI_MAX_POLL_TO_NS); + ktime_t stop = ktime_add_ms(ktime_get(), + info->desc->max_rx_timeout_ms); spin_until_cond(scmi_xfer_done_no_timeout(cinfo, xfer, stop)); if (ktime_before(ktime_get(), stop)) { -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-29 19:14 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-29 19:11 [PATCH v7 00/16] Introduce atomic support for SCMI transports Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 01/16] firmware: arm_scmi: Perform earlier cinfo lookup call in do_xfer Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi [this message] 2021-11-29 19:11 ` [PATCH v7 02/16] firmware: arm_scmi: Set polling timeout to max_rx_timeout_ms Cristian Marussi 2021-12-03 20:13 ` Florian Fainelli 2021-12-03 20:13 ` Florian Fainelli 2021-12-13 11:06 ` Sudeep Holla 2021-12-13 11:06 ` Sudeep Holla 2021-11-29 19:11 ` [PATCH v7 03/16] firmware: arm_scmi: Refactor message response path Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 04/16] include: trace: Add new scmi_xfer_response_wait event Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-03 20:16 ` Florian Fainelli 2021-12-03 20:16 ` Florian Fainelli 2021-11-29 19:11 ` [PATCH v7 05/16] firmware: arm_scmi: Use new trace event scmi_xfer_response_wait Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-03 20:16 ` Florian Fainelli 2021-12-03 20:16 ` Florian Fainelli 2021-11-29 19:11 ` [PATCH v7 06/16] firmware: arm_scmi: Add configurable polling mode for transports Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-13 11:25 ` Sudeep Holla 2021-12-13 11:25 ` Sudeep Holla 2021-12-14 10:49 ` Cristian Marussi 2021-12-14 10:49 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 07/16] firmware: arm_scmi: Make smc transport use common completions Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 08/16] firmware: arm_scmi: Add sync_cmds_atomic_replies transport flag Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-13 11:54 ` Sudeep Holla 2021-12-13 11:54 ` Sudeep Holla 2021-12-14 10:52 ` Cristian Marussi 2021-12-14 10:52 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 09/16] firmware: arm_scmi: Make smc support atomic sync commands replies Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 10/16] firmware: arm_scmi: Make optee " Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 11/16] firmware: arm_scmi: Add support for atomic transports Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 12/16] firmware: arm_scmi: Add atomic mode support to smc transport Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-13 11:42 ` Sudeep Holla 2021-12-13 11:42 ` Sudeep Holla 2021-12-14 10:54 ` Cristian Marussi 2021-12-14 10:54 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 13/16] firmware: arm_scmi: Add new parameter to mark_txdone Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-03 20:17 ` Florian Fainelli 2021-12-03 20:17 ` Florian Fainelli 2021-11-29 19:11 ` [PATCH v7 14/16] firmware: arm_scmi: Add atomic mode support to virtio transport Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-10 12:12 ` Peter Hilber 2021-12-10 12:12 ` Peter Hilber 2021-12-20 21:30 ` Cristian Marussi 2021-12-20 21:30 ` Cristian Marussi 2022-01-18 14:20 ` Peter Hilber 2022-01-18 14:20 ` Peter Hilber 2021-12-13 11:34 ` Sudeep Holla 2021-12-13 11:34 ` Sudeep Holla 2021-12-14 10:56 ` Cristian Marussi 2021-12-14 10:56 ` Cristian Marussi 2021-11-29 19:11 ` [PATCH v7 15/16] firmware: arm_scmi: Add atomic support to clock protocol Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-03 20:16 ` Florian Fainelli 2021-12-03 20:16 ` Florian Fainelli 2021-11-29 19:11 ` [PATCH v7 16/16] clk: scmi: Support atomic clock enable/disable API Cristian Marussi 2021-11-29 19:11 ` Cristian Marussi 2021-12-03 2:06 ` Stephen Boyd 2021-12-03 2:06 ` Stephen Boyd 2021-12-03 20:17 ` Florian Fainelli 2021-12-03 20:17 ` Florian Fainelli 2021-12-10 10:52 ` Vincent Guittot 2021-12-10 10:52 ` Vincent Guittot 2021-12-10 13:30 ` Cristian Marussi 2021-12-10 13:30 ` Cristian Marussi 2021-12-10 14:27 ` Vincent Guittot 2021-12-10 14:27 ` Vincent Guittot 2021-12-10 19:36 ` Cristian Marussi 2021-12-10 19:36 ` Cristian Marussi 2021-12-13 17:52 ` [PATCH v7 00/16] (subset) Introduce atomic support for SCMI transports Sudeep Holla 2021-12-13 17:52 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211129191156.29322-3-cristian.marussi@arm.com \ --to=cristian.marussi@arm.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=james.quinlan@broadcom.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=souvik.chakravarty@arm.com \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.