From: Mike Christie <michael.christie@oracle.com> To: geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com, hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, christian.brauner@ubuntu.com, axboe@kernel.dk, linux-kernel@vger.kernel.org Cc: Christoph Hellwig <hch@lst.de> Subject: [PATCH V6 04/10] fork: Add USER_WORKER flag to ignore signals Date: Mon, 29 Nov 2021 13:47:01 -0600 [thread overview] Message-ID: <20211129194707.5863-5-michael.christie@oracle.com> (raw) In-Reply-To: <20211129194707.5863-1-michael.christie@oracle.com> From: Christian Brauner <christian.brauner@ubuntu.com> Since this is mirroring kthread's sig ignore api introduced in commit 10ab825bdef8 ("change kernel threads to ignore signals instead of blocking them") this patch adds an option flag, USER_WORKER_SIG_IGN, handled in copy_process() after copy_sighand() and copy_signals() to ease the transition from kthreads to this new api. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Mike Christie <michael.christie@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- include/linux/sched/task.h | 1 + kernel/fork.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index e094502b2eea..f8a658700075 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -21,6 +21,7 @@ struct css_set; #define USER_WORKER BIT(0) #define USER_WORKER_IO BIT(1) #define USER_WORKER_NO_FILES BIT(2) +#define USER_WORKER_SIG_IGN BIT(3) struct kernel_clone_args { u64 flags; diff --git a/kernel/fork.c b/kernel/fork.c index a47bec00f37c..c9152596a285 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2211,6 +2211,9 @@ static __latent_entropy struct task_struct *copy_process( if (retval) goto bad_fork_cleanup_io; + if (args->worker_flags & USER_WORKER_SIG_IGN) + ignore_signals(p); + stackleak_task_init(p); if (pid != &init_struct_pid) { -- 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com> To: geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com, hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, christian.brauner@ubuntu.com, axboe@kernel.dk, linux-kernel@vger.kernel.org Cc: Mike Christie <michael.christie@oracle.com>, Christoph Hellwig <hch@lst.de> Subject: [PATCH V6 04/10] fork: Add USER_WORKER flag to ignore signals Date: Mon, 29 Nov 2021 13:47:01 -0600 [thread overview] Message-ID: <20211129194707.5863-5-michael.christie@oracle.com> (raw) In-Reply-To: <20211129194707.5863-1-michael.christie@oracle.com> From: Christian Brauner <christian.brauner@ubuntu.com> Since this is mirroring kthread's sig ignore api introduced in commit 10ab825bdef8 ("change kernel threads to ignore signals instead of blocking them") this patch adds an option flag, USER_WORKER_SIG_IGN, handled in copy_process() after copy_sighand() and copy_signals() to ease the transition from kthreads to this new api. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Mike Christie <michael.christie@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- include/linux/sched/task.h | 1 + kernel/fork.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index e094502b2eea..f8a658700075 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -21,6 +21,7 @@ struct css_set; #define USER_WORKER BIT(0) #define USER_WORKER_IO BIT(1) #define USER_WORKER_NO_FILES BIT(2) +#define USER_WORKER_SIG_IGN BIT(3) struct kernel_clone_args { u64 flags; diff --git a/kernel/fork.c b/kernel/fork.c index a47bec00f37c..c9152596a285 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2211,6 +2211,9 @@ static __latent_entropy struct task_struct *copy_process( if (retval) goto bad_fork_cleanup_io; + if (args->worker_flags & USER_WORKER_SIG_IGN) + ignore_signals(p); + stackleak_task_init(p); if (pid != &init_struct_pid) { -- 2.25.1
next prev parent reply other threads:[~2021-11-29 19:47 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-29 19:46 [PATCH V6 01/10] Use copy_process in vhost layer Mike Christie 2021-11-29 19:46 ` Mike Christie 2021-11-29 19:46 ` [PATCH V6 01/10] fork: Make IO worker options flag based Mike Christie 2021-11-29 19:46 ` Mike Christie 2021-11-29 19:46 ` [PATCH V6 02/10] fork/vm: Move common PF_IO_WORKER behavior to new flag Mike Christie 2021-11-29 19:46 ` Mike Christie 2021-11-29 19:47 ` [PATCH V6 03/10] fork: add USER_WORKER flag to not dup/clone files Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-11-29 19:47 ` Mike Christie [this message] 2021-11-29 19:47 ` [PATCH V6 04/10] fork: Add USER_WORKER flag to ignore signals Mike Christie 2021-11-29 19:47 ` [PATCH V6 05/10] signal: Perfom autoreap for PF_USER_WORKER Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-12-17 18:42 ` Eric W. Biederman 2021-12-17 18:42 ` Eric W. Biederman 2021-11-29 19:47 ` [PATCH V6 06/10] fork: add helpers to clone a process for kernel use Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-12-17 18:53 ` Eric W. Biederman 2021-12-17 18:53 ` Eric W. Biederman 2021-11-29 19:47 ` [PATCH V6 07/10] io_uring: switch to user_worker Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-11-29 19:47 ` [PATCH V6 08/10] fork: remove create_io_thread Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-11-29 19:47 ` [PATCH V6 09/10] vhost: move worker thread fields to new struct Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-11-29 19:47 ` [PATCH V6 10/10] vhost: use user_worker to check RLIMITs Mike Christie 2021-11-29 19:47 ` Mike Christie 2021-12-17 19:01 ` Eric W. Biederman 2021-12-17 19:01 ` Eric W. Biederman 2021-12-08 20:34 ` [PATCH V6 01/10] Use copy_process in vhost layer Michael S. Tsirkin 2021-12-08 20:34 ` Michael S. Tsirkin 2021-12-08 22:13 ` michael.christie 2021-12-08 22:13 ` michael.christie 2021-12-09 9:32 ` Christian Brauner 2021-12-17 19:26 ` Eric W. Biederman 2021-12-17 19:26 ` Eric W. Biederman 2021-12-17 22:08 ` michael.christie 2021-12-17 22:08 ` michael.christie 2021-12-22 0:20 ` Eric W. Biederman 2021-12-22 0:20 ` Eric W. Biederman 2021-12-22 17:32 ` Mike Christie 2021-12-22 17:32 ` Mike Christie 2021-12-22 18:24 ` Eric W. Biederman 2021-12-22 18:24 ` Eric W. Biederman 2021-12-22 20:25 ` Michael S. Tsirkin 2021-12-22 20:25 ` Michael S. Tsirkin 2022-01-17 16:41 ` Mike Christie 2022-01-17 16:41 ` Mike Christie 2022-01-17 17:31 ` Eric W. Biederman 2022-01-17 17:31 ` Eric W. Biederman 2022-01-18 18:51 ` Mike Christie 2022-01-18 18:51 ` Mike Christie 2022-01-18 19:00 ` Mike Christie 2022-01-18 19:00 ` Mike Christie 2022-01-18 19:12 ` Eric W. Biederman 2022-01-18 19:12 ` Eric W. Biederman 2022-02-02 21:02 ` Mike Christie 2022-02-02 21:02 ` Mike Christie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211129194707.5863-5-michael.christie@oracle.com \ --to=michael.christie@oracle.com \ --cc=axboe@kernel.dk \ --cc=christian.brauner@ubuntu.com \ --cc=geert@linux-m68k.org \ --cc=hch@infradead.org \ --cc=hch@lst.de \ --cc=hdanton@sina.com \ --cc=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=vverma@digitalocean.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.