* [PATCH] dpaa2-eth: destroy workqueue at the end of remove function
@ 2021-11-30 4:05 Dongliang Mu
2021-11-30 12:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dongliang Mu @ 2021-11-30 4:05 UTC (permalink / raw)
To: Ioana Ciornei, David S. Miller, Jakub Kicinski, Yangbo Lu
Cc: Dongliang Mu, netdev, linux-kernel
The commit c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step
timestamping") forgets to destroy workqueue at the end of remove
function.
Fix this by adding destroy_workqueue before fsl_mc_portal_free and
free_netdev.
Fixes: c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step timestamping")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index 6451c8383639..8e643567abce 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -4550,6 +4550,8 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)
fsl_mc_portal_free(priv->mc_io);
+ destroy_workqueue(priv->dpaa2_ptp_wq);
+
dev_dbg(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);
free_netdev(net_dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dpaa2-eth: destroy workqueue at the end of remove function
2021-11-30 4:05 [PATCH] dpaa2-eth: destroy workqueue at the end of remove function Dongliang Mu
@ 2021-11-30 12:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-30 12:30 UTC (permalink / raw)
To: Dongliang Mu; +Cc: ioana.ciornei, davem, kuba, yangbo.lu, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 30 Nov 2021 12:05:54 +0800 you wrote:
> The commit c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step
> timestamping") forgets to destroy workqueue at the end of remove
> function.
>
> Fix this by adding destroy_workqueue before fsl_mc_portal_free and
> free_netdev.
>
> [...]
Here is the summary with links:
- dpaa2-eth: destroy workqueue at the end of remove function
https://git.kernel.org/netdev/net/c/f4a8adbfe484
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-30 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 4:05 [PATCH] dpaa2-eth: destroy workqueue at the end of remove function Dongliang Mu
2021-11-30 12:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.