All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: hns3: make symbol 'hclge_mac_speed_map_to_fw' static
@ 2021-11-30 11:34 Wei Yongjun
  2021-11-30 12:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-11-30 11:34 UTC (permalink / raw)
  To: weiyongjun1, Yisen Zhuang, Salil Mehta, David S. Miller,
	Jakub Kicinski, Huazhong Tan, Guangbin Huang, Jian Shen,
	Yufeng Mo, Jiaran Zhang, liaoguojia
  Cc: netdev, kernel-janitors, Hulk Robot

The sparse tool complains as follows:

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:2656:28: warning:
 symbol 'hclge_mac_speed_map_to_fw' was not declared. Should it be static?

This symbol is not used outside of hclge_main.c, so marks it static.

Fixes: e46da6a3d4d3 ("net: hns3: refine function hclge_cfg_mac_speed_dup_hw()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 7de4c56ef014..1815fcf168b0 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -2653,7 +2653,7 @@ static u8 hclge_check_speed_dup(u8 duplex, int speed)
 	return duplex;
 }
 
-struct hclge_mac_speed_map hclge_mac_speed_map_to_fw[] = {
+static struct hclge_mac_speed_map hclge_mac_speed_map_to_fw[] = {
 	{HCLGE_MAC_SPEED_10M, HCLGE_FW_MAC_SPEED_10M},
 	{HCLGE_MAC_SPEED_100M, HCLGE_FW_MAC_SPEED_100M},
 	{HCLGE_MAC_SPEED_1G, HCLGE_FW_MAC_SPEED_1G},


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: hns3: make symbol 'hclge_mac_speed_map_to_fw' static
  2021-11-30 11:34 [PATCH net-next] net: hns3: make symbol 'hclge_mac_speed_map_to_fw' static Wei Yongjun
@ 2021-11-30 12:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-30 12:30 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: yisen.zhuang, salil.mehta, davem, kuba, tanhuazhong,
	huangguangbin2, shenjian15, moyufeng, zhangjiaran, liaoguojia,
	netdev, kernel-janitors, hulkci

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 30 Nov 2021 11:34:37 +0000 you wrote:
> The sparse tool complains as follows:
> 
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:2656:28: warning:
>  symbol 'hclge_mac_speed_map_to_fw' was not declared. Should it be static?
> 
> This symbol is not used outside of hclge_main.c, so marks it static.
> 
> [...]

Here is the summary with links:
  - [net-next] net: hns3: make symbol 'hclge_mac_speed_map_to_fw' static
    https://git.kernel.org/netdev/net-next/c/c0190879323f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-30 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 11:34 [PATCH net-next] net: hns3: make symbol 'hclge_mac_speed_map_to_fw' static Wei Yongjun
2021-11-30 12:30 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.