All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marc Zyngier <maz@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	"Pali Rohár" <pali@kernel.org>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"Mark Kettenis" <mark.kettenis@xs4all.nl>,
	"Luca Ceresoli" <luca@lucaceresoli.net>,
	kernel-team@android.com
Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes
Date: Tue, 30 Nov 2021 11:56:32 +0000	[thread overview]
Message-ID: <20211130115632.GA3355@lpieralisi> (raw)
In-Reply-To: <20211123180636.80558-1-maz@kernel.org>

On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> Apologies for the rapid fire (I tend to be much more conservative when
> resending series), but given that this series has a direct impact on
> other projects (such as u-boot), I'm trying to converge as quickly as
> possible.
> 
> This series aims at fixing a number of issues for the recently merged
> Apple PCIe driver, all revolving around the mishandling of #PERST:
> 
> - we didn't properly drive #PERST, and we didn't follow the specified
>   timings
>   
> - the DT had the wrong polarity, which has impacts on the driver
>   itself
> 
> Hopefully, this should address all the issues reported so far.
> 
> * From v2:
>   - Fixed DT
>   - Fixed #PERST polarity in the driver
>   - Collected Pali's ack on patch #1
> 
> [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> 
> Marc Zyngier (3):
>   PCI: apple: Follow the PCIe specifications when resetting the port
>   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
>   PCI: apple: Fix #PERST polarity
> 
>  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
>  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
>  2 files changed, 15 insertions(+), 4 deletions(-)

Hi Bjorn,

this series is v5.16-rcX material for PCI fixes, can you pick patches 1,3
up please ?

Thank you very much.

Lorenzo

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marc Zyngier <maz@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	"Pali Rohár" <pali@kernel.org>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"Mark Kettenis" <mark.kettenis@xs4all.nl>,
	"Luca Ceresoli" <luca@lucaceresoli.net>,
	kernel-team@android.com
Subject: Re: [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes
Date: Tue, 30 Nov 2021 11:56:32 +0000	[thread overview]
Message-ID: <20211130115632.GA3355@lpieralisi> (raw)
In-Reply-To: <20211123180636.80558-1-maz@kernel.org>

On Tue, Nov 23, 2021 at 06:06:33PM +0000, Marc Zyngier wrote:
> Apologies for the rapid fire (I tend to be much more conservative when
> resending series), but given that this series has a direct impact on
> other projects (such as u-boot), I'm trying to converge as quickly as
> possible.
> 
> This series aims at fixing a number of issues for the recently merged
> Apple PCIe driver, all revolving around the mishandling of #PERST:
> 
> - we didn't properly drive #PERST, and we didn't follow the specified
>   timings
>   
> - the DT had the wrong polarity, which has impacts on the driver
>   itself
> 
> Hopefully, this should address all the issues reported so far.
> 
> * From v2:
>   - Fixed DT
>   - Fixed #PERST polarity in the driver
>   - Collected Pali's ack on patch #1
> 
> [1] https://lore.kernel.org/r/20211122104156.518063-1-maz@kernel.org
> 
> Marc Zyngier (3):
>   PCI: apple: Follow the PCIe specifications when resetting the port
>   arm64: dts: apple: t8103: Fix PCIe #PERST polarity
>   PCI: apple: Fix #PERST polarity
> 
>  arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
>  drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
>  2 files changed, 15 insertions(+), 4 deletions(-)

Hi Bjorn,

this series is v5.16-rcX material for PCI fixes, can you pick patches 1,3
up please ?

Thank you very much.

Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-30 11:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 18:06 [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes Marc Zyngier
2021-11-23 18:06 ` Marc Zyngier
2021-11-23 18:06 ` [PATCH v3 1/3] PCI: apple: Follow the PCIe specifications when resetting the port Marc Zyngier
2021-11-23 18:06   ` Marc Zyngier
2021-11-24  9:22   ` Luca Ceresoli
2021-11-24  9:22     ` Luca Ceresoli
2021-11-24 12:56   ` Robin Murphy
2021-11-24 12:56     ` Robin Murphy
2021-12-07 16:22   ` Bjorn Helgaas
2021-12-07 16:22     ` Bjorn Helgaas
2021-11-23 18:06 ` [PATCH v3 2/3] arm64: dts: apple: t8103: Fix PCIe #PERST polarity Marc Zyngier
2021-11-23 18:06   ` Marc Zyngier
2021-11-23 18:16   ` Mark Kettenis
2021-11-23 18:16     ` Mark Kettenis
2021-11-24  9:17   ` Luca Ceresoli
2021-11-24  9:17     ` Luca Ceresoli
2021-12-01 14:46     ` Arnd Bergmann
2021-12-01 14:46       ` Arnd Bergmann
2021-11-23 18:06 ` [PATCH v3 3/3] PCI: apple: Fix " Marc Zyngier
2021-11-23 18:06   ` Marc Zyngier
2021-11-23 21:36   ` Luca Ceresoli
2021-11-23 21:36     ` Luca Ceresoli
2021-11-24  9:02     ` Marc Zyngier
2021-11-24  9:02       ` Marc Zyngier
2021-11-24  9:16       ` Luca Ceresoli
2021-11-24  9:16         ` Luca Ceresoli
2021-11-30 11:56 ` Lorenzo Pieralisi [this message]
2021-11-30 11:56   ` [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes Lorenzo Pieralisi
2021-11-30 11:59   ` Marc Zyngier
2021-11-30 11:59     ` Marc Zyngier
2021-11-30 12:12     ` Lorenzo Pieralisi
2021-11-30 12:12       ` Lorenzo Pieralisi
2021-11-30 12:45       ` Marc Zyngier
2021-11-30 12:45         ` Marc Zyngier
2021-12-01 14:48         ` Arnd Bergmann
2021-12-01 14:48           ` Arnd Bergmann
2021-12-07 10:16   ` Lorenzo Pieralisi
2021-12-07 10:16     ` Lorenzo Pieralisi
2021-12-07 20:30     ` Bjorn Helgaas
2021-12-07 20:30       ` Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2021-11-23 17:54 Marc Zyngier
2021-11-23 17:54 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130115632.GA3355@lpieralisi \
    --to=lorenzo.pieralisi@arm.com \
    --cc=alyssa@rosenzweig.io \
    --cc=bhelgaas@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=mark.kettenis@xs4all.nl \
    --cc=maz@kernel.org \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.