linux-next: build warning after merge of the fscache tree

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (arm64 defconfig)
produced this warning:

fs/9p/vfs_addr.c: In function 'v9fs_release_page':
fs/9p/vfs_addr.c:140:16: warning: unused variable 'inode' [-Wunused-variable]
  140 |  struct inode *inode = folio_inode(folio);
      |                ^~~~~

Introduced by commit

  12b841dc2cfd ("9p: Copy local writes to the cache when writing to the server")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Hi all,

On Tue, 30 Nov 2021 15:27:53 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the fscache tree, today's linux-next build (arm64 defconfig)
> produced this warning:
> 
> fs/9p/vfs_addr.c: In function 'v9fs_release_page':
> fs/9p/vfs_addr.c:140:16: warning: unused variable 'inode' [-Wunused-variable]
>   140 |  struct inode *inode = folio_inode(folio);
>       |                ^~~~~
> 
> Introduced by commit
> 
>   12b841dc2cfd ("9p: Copy local writes to the cache when writing to the server")

Still getting this ... It will cause build failures for any config with
CONFIG_9P_FSCACHE not set and CONFIG_WERROR set

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (htmdocs)
produced this warning:

Error: Cannot open file fs/netfs/read_helper.c

Introduced by commit

  ad9e5adb388f ("netfs: Rename rename read_helper.c to io.c")

Documentation/filesystems/netfs_library.rst needs updating.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/fscache.h:221: warning: Excess function parameter 'coherency_len' description in 'fscache_relinquish_volume'

Introduced by commit

  9a1e50028157 ("fscache: Implement volume registration")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/caching/backend-api.rst:417: WARNING: undefined label: documentation/filesystems/netfs_library.rst

Introduced by commit

  b3c088faf78b ("fscache: Rewrite documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi all,

On Tue, 30 Nov 2021 16:23:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the fscache tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/filesystems/caching/backend-api.rst:417: WARNING: undefined label: documentation/filesystems/netfs_library.rst
> 
> Introduced by commit
> 
>   b3c088faf78b ("fscache: Rewrite documentation")

Also

Documentation/filesystems/netfs_library.rst:518: WARNING: Inline emphasis start-string without end-string.
Documentation/filesystems/netfs_library.rst:518: WARNING: Inline emphasis start-string without end-string.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Documentation/filesystems/caching/backend-api.rst:417: WARNING: undefined label: documentation/filesystems/netfs_library.rst

That would be this line:

	See :ref:`Documentation/filesystems/netfs_library.rst` for a description.

I'm not sure what's supposed to be the right way to create an inter-doc
reference.  It does work, though - maybe the warning just needs to be removed?

David

Re: linux-next: build warning after merge of the fscache tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Documentation/filesystems/netfs_library.rst:518: WARNING: Inline emphasis start-string without end-string.
> Documentation/filesystems/netfs_library.rst:518: WARNING: Inline emphasis start-string without end-string.

Ah...  I worked out what that's about.  It's not actually on the line
specified, but rather later in the same paragraph:

   the write.  *_start and *_len indicate the region to be written; the region

with the two asterisks.  I guess wrapping them like:

   the write.  ``*_start`` and ``*_len`` indicate the region to be written; the

might be the right thing to do.

David

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/caching/backend-api.rst:402: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  9c74b32d892e ("fscache: Update the documentation to reflect I/O API changes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi all,

On Tue, 5 Oct 2021 20:46:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the fscache tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/filesystems/caching/backend-api.rst:402: WARNING: Inline emphasis start-string without end-string.
> 
> Introduced by commit
> 
>   9c74b32d892e ("fscache: Update the documentation to reflect I/O API changes")

I am still seeing this warning.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > Documentation/filesystems/caching/backend-api.rst:402: WARNING: Inline emphasis start-string without end-string.

I'm not sure what that even means.

David

Re: linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Hi David,

On Thu, 21 Oct 2021 15:32:54 +0100 David Howells <dhowells@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > > Documentation/filesystems/caching/backend-api.rst:402: WARNING: Inline emphasis start-string without end-string.  
> 
> I'm not sure what that even means.

I assume it is referring to the "*cres" with on ending "*" ... I am not
sure how to quote the "*".  Maybe just with \ ... or ``*cres`` ?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/netfs_library.rst: WARNING: document isn't included in any toctree

Introduced by commit

  cefbac2d6fc5 ("netfs: Documentation for helper library")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/afs/file.c: In function 'afs_req_issue_op':
fs/afs/file.c:291:6: warning: unused variable 'ret' [-Wunused-variable]
  291 |  int ret;
      |      ^~~

Introduced by commit

  799fbdf96cd5 ("afs: Use new fscache read helper API")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the fscache tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the fscache tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/afs/file.c: In function 'afs_req_issue_op':
> fs/afs/file.c:291:6: warning: unused variable 'ret' [-Wunused-variable]
>   291 |  int ret;
>       |      ^~~
> 
> Introduced by commit
> 
>   799fbdf96cd5 ("afs: Use new fscache read helper API")

I've updated my branch to remove the variable.

David