From: Janne Grunau <j@jannau.net>
To: Sven Peter <sven@svenpeter.dev>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] watchdog: Add Apple SoC watchdog driver
Date: Tue, 30 Nov 2021 21:55:28 +0100 [thread overview]
Message-ID: <20211130205528.GC28130@jannau.net> (raw)
In-Reply-To: <20211130161809.64591-2-sven@svenpeter.dev>
Hej,
On 2021-11-30 17:18:09 +0100, Sven Peter wrote:
> Add support for the watchdog timer found in Apple SoCs. This driver is
> also required to reboot these machines.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
> v1 -> v2:
> - set the default timeout to 30s and call watchdog_init_timeout
> to allow the device tree to override it
> - set WDOG_HW_RUNNING if the watchdog is enabled at boot
> - check that the clock rate is not zero
> - use unsigned long instead of u32 for clk_rate
> - use devm_add_action_or_reset instead of manually calling
> clk_disable_unprepare
> - explain the magic number in apple_wdt_restart
>
> MAINTAINERS | 1 +
> drivers/watchdog/Kconfig | 12 ++
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/apple_wdt.c | 226 +++++++++++++++++++++++++++++++++++
> 4 files changed, 240 insertions(+)
> create mode 100644 drivers/watchdog/apple_wdt.c
Tested on M1 and M1 Max. Feel free to add
Tested-by: Janne Grunau <j@jannau.net>
best
Janne
WARNING: multiple messages have this Message-ID (diff)
From: Janne Grunau <j@jannau.net>
To: Sven Peter <sven@svenpeter.dev>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] watchdog: Add Apple SoC watchdog driver
Date: Tue, 30 Nov 2021 21:55:28 +0100 [thread overview]
Message-ID: <20211130205528.GC28130@jannau.net> (raw)
In-Reply-To: <20211130161809.64591-2-sven@svenpeter.dev>
Hej,
On 2021-11-30 17:18:09 +0100, Sven Peter wrote:
> Add support for the watchdog timer found in Apple SoCs. This driver is
> also required to reboot these machines.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
> v1 -> v2:
> - set the default timeout to 30s and call watchdog_init_timeout
> to allow the device tree to override it
> - set WDOG_HW_RUNNING if the watchdog is enabled at boot
> - check that the clock rate is not zero
> - use unsigned long instead of u32 for clk_rate
> - use devm_add_action_or_reset instead of manually calling
> clk_disable_unprepare
> - explain the magic number in apple_wdt_restart
>
> MAINTAINERS | 1 +
> drivers/watchdog/Kconfig | 12 ++
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/apple_wdt.c | 226 +++++++++++++++++++++++++++++++++++
> 4 files changed, 240 insertions(+)
> create mode 100644 drivers/watchdog/apple_wdt.c
Tested on M1 and M1 Max. Feel free to add
Tested-by: Janne Grunau <j@jannau.net>
best
Janne
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 20:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:18 [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Sven Peter
2021-11-30 16:18 ` Sven Peter
2021-11-30 16:18 ` [PATCH v2 2/2] watchdog: Add Apple SoC watchdog driver Sven Peter
2021-11-30 16:18 ` Sven Peter
2021-11-30 20:55 ` Janne Grunau [this message]
2021-11-30 20:55 ` Janne Grunau
2021-12-02 6:44 ` Hector Martin "marcan"
2021-12-02 6:44 ` Hector Martin "marcan"
2021-12-02 14:36 ` Guenter Roeck
2021-12-02 14:36 ` Guenter Roeck
2021-12-03 13:50 ` Hector Martin
2021-12-03 13:50 ` Hector Martin
2021-12-03 15:08 ` Guenter Roeck
2021-12-03 15:08 ` Guenter Roeck
2021-12-02 12:38 ` Hector Martin
2021-12-02 12:38 ` Hector Martin
2021-12-02 14:43 ` Guenter Roeck
2021-12-02 14:43 ` Guenter Roeck
2021-12-02 14:43 ` [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog Guenter Roeck
2021-12-02 14:43 ` Guenter Roeck
2021-12-07 4:35 ` Hector Martin
2021-12-07 4:35 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130205528.GC28130@jannau.net \
--to=j@jannau.net \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.