* [PATCH] Revert "cobalt/assert: pipeline: add TODO() marker"
@ 2021-12-01 1:13 Hongzhan Chen
2021-12-01 6:02 ` Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Hongzhan Chen @ 2021-12-01 1:13 UTC (permalink / raw)
To: xenomai
This reverts commit 5c9cbcfce83083d9ea280f3b9143525cacfecfc8.
We revert this because we fixed all related TODOs.
Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
diff --git a/include/cobalt/kernel/assert.h b/include/cobalt/kernel/assert.h
index abe044100..98218ce6c 100644
--- a/include/cobalt/kernel/assert.h
+++ b/include/cobalt/kernel/assert.h
@@ -55,8 +55,6 @@
do { } while (0)
#endif
-#define TODO() BUILD_BUG_ON(IS_ENABLED(CONFIG_XENO_TODO))
-
#define primary_mode_only() XENO_BUG_ON(CONTEXT, is_secondary_domain())
#define secondary_mode_only() XENO_BUG_ON(CONTEXT, !is_secondary_domain())
#define interrupt_only() XENO_BUG_ON(CONTEXT, !xnsched_interrupt_p())
diff --git a/kernel/cobalt/Kconfig b/kernel/cobalt/Kconfig
index 88953ff24..3233de1b1 100644
--- a/kernel/cobalt/Kconfig
+++ b/kernel/cobalt/Kconfig
@@ -487,9 +487,3 @@ config XENO_OPT_WATCHDOG_TIMEOUT
Watchdog timeout value (in seconds).
endif # XENO_OPT_DEBUG
-
-config XENO_TODO
- bool "Reveal TODO places"
- help
- This option causes a build time assertion to trigger
- when the TODO() marker is found in the compiled code.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "cobalt/assert: pipeline: add TODO() marker"
2021-12-01 1:13 [PATCH] Revert "cobalt/assert: pipeline: add TODO() marker" Hongzhan Chen
@ 2021-12-01 6:02 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2021-12-01 6:02 UTC (permalink / raw)
To: Hongzhan Chen, xenomai
On 01.12.21 02:13, Hongzhan Chen via Xenomai wrote:
> This reverts commit 5c9cbcfce83083d9ea280f3b9143525cacfecfc8.
>
> We revert this because we fixed all related TODOs.
>
> Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
>
> diff --git a/include/cobalt/kernel/assert.h b/include/cobalt/kernel/assert.h
> index abe044100..98218ce6c 100644
> --- a/include/cobalt/kernel/assert.h
> +++ b/include/cobalt/kernel/assert.h
> @@ -55,8 +55,6 @@
> do { } while (0)
> #endif
>
> -#define TODO() BUILD_BUG_ON(IS_ENABLED(CONFIG_XENO_TODO))
> -
> #define primary_mode_only() XENO_BUG_ON(CONTEXT, is_secondary_domain())
> #define secondary_mode_only() XENO_BUG_ON(CONTEXT, !is_secondary_domain())
> #define interrupt_only() XENO_BUG_ON(CONTEXT, !xnsched_interrupt_p())
> diff --git a/kernel/cobalt/Kconfig b/kernel/cobalt/Kconfig
> index 88953ff24..3233de1b1 100644
> --- a/kernel/cobalt/Kconfig
> +++ b/kernel/cobalt/Kconfig
> @@ -487,9 +487,3 @@ config XENO_OPT_WATCHDOG_TIMEOUT
> Watchdog timeout value (in seconds).
>
> endif # XENO_OPT_DEBUG
> -
> -config XENO_TODO
> - bool "Reveal TODO places"
> - help
> - This option causes a build time assertion to trigger
> - when the TODO() marker is found in the compiled code.
>
thanks, applied
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-01 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 1:13 [PATCH] Revert "cobalt/assert: pipeline: add TODO() marker" Hongzhan Chen
2021-12-01 6:02 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.