[PATCH] rtw89: don't kick off TX DMA if failed to write skb

[PATCH] rtw89: don't kick off TX DMA if failed to write skb

[Ping-Ke Shih]

This is found by Smatch static checker warning:
	drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
	error: uninitialized symbol 'qsel'.

The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to
failed to write. The way to fix it is to avoid kicking off TX DMA, so add
'return' to the failure case.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/mac80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/net/wireless/realtek/rtw89/mac80211.c
index 16dc6fb7dbb0b..e9d61e55e2d92 100644
--- a/drivers/net/wireless/realtek/rtw89/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw89/mac80211.c
@@ -27,6 +27,7 @@ static void rtw89_ops_tx(struct ieee80211_hw *hw,
 	if (ret) {
 		rtw89_err(rtwdev, "failed to transmit skb: %d\n", ret);
 		ieee80211_free_txskb(hw, skb);
+		return;
 	}
 	rtw89_core_tx_kick_off(rtwdev, qsel);
 }
-- 
2.25.1

Re: [PATCH] rtw89: don't kick off TX DMA if failed to write skb

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> This is found by Smatch static checker warning:
> 	drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
> 	error: uninitialized symbol 'qsel'.
> 
> The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to
> failed to write. The way to fix it is to avoid kicking off TX DMA, so add
> 'return' to the failure case.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

a58fdb7c843a rtw89: don't kick off TX DMA if failed to write skb

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211201093816.13806-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches