* [PATCH -next] um: virt-pci: fix wrong use of sizeof in um_pci_cfgspace_read()
@ 2021-12-01 9:52 ` Yang Yingliang
0 siblings, 0 replies; 2+ messages in thread
From: Yang Yingliang @ 2021-12-01 9:52 UTC (permalink / raw)
To: linux-kernel, linux-um; +Cc: jdike, richard, johannes.berg
It should be size of the buf->data array, not data pointer.
Fixes: 4a22c4cebd61 ("um: virt-pci: don't do DMA from stack")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/um/drivers/virt-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index c08066633023..705275c5176c 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
buf = get_cpu_var(um_pci_msg_bufs);
data = buf->data;
- memset(data, 0xff, sizeof(data));
+ memset(data, 0xff, sizeof(buf->data));
switch (size) {
case 1:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] um: virt-pci: fix wrong use of sizeof in um_pci_cfgspace_read()
@ 2021-12-01 9:52 ` Yang Yingliang
0 siblings, 0 replies; 2+ messages in thread
From: Yang Yingliang @ 2021-12-01 9:52 UTC (permalink / raw)
To: linux-kernel, linux-um; +Cc: jdike, richard, johannes.berg
It should be size of the buf->data array, not data pointer.
Fixes: 4a22c4cebd61 ("um: virt-pci: don't do DMA from stack")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/um/drivers/virt-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
index c08066633023..705275c5176c 100644
--- a/arch/um/drivers/virt-pci.c
+++ b/arch/um/drivers/virt-pci.c
@@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,
buf = get_cpu_var(um_pci_msg_bufs);
data = buf->data;
- memset(data, 0xff, sizeof(data));
+ memset(data, 0xff, sizeof(buf->data));
switch (size) {
case 1:
--
2.25.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-01 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 9:52 [PATCH -next] um: virt-pci: fix wrong use of sizeof in um_pci_cfgspace_read() Yang Yingliang
2021-12-01 9:52 ` Yang Yingliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.