All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Cooper <alcooperx@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Al Cooper" <alcooperx@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	linux-phy@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Vinod Koul" <vkoul@kernel.org>
Subject: [PATCH 3/3] phy: broadcom: Kconfig: Fix PHY_BRCM_USB config option
Date: Wed,  1 Dec 2021 13:06:53 -0500	[thread overview]
Message-ID: <20211201180653.35097-4-alcooperx@gmail.com> (raw)
In-Reply-To: <20211201180653.35097-1-alcooperx@gmail.com>

The previous commit 4b402fa8e0b7 ("phy: phy-brcm-usb: support PHY on
the BCM4908") added a second "default" line for ARCH_BCM_4908 above
the original "default" line for ARCH_BRCMSTB. When two "default"
lines are used, only the first is used and this change stopped
the PHY_BRCM_USB option for being enabled for ARCH_BRCMSTB.
The fix is to use one "default line with "||".

Fixes: 4b402fa8e0b7 ("phy: phy-brcm-usb: support PHY on the BCM4908")
Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
 drivers/phy/broadcom/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index f81e23742079..849c4204f550 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -97,8 +97,7 @@ config PHY_BRCM_USB
 	depends on OF
 	select GENERIC_PHY
 	select SOC_BRCMSTB if ARCH_BRCMSTB
-	default ARCH_BCM4908
-	default ARCH_BRCMSTB
+	default ARCH_BCM4908 || ARCH_BRCMSTB
 	help
 	  Enable this to support the Broadcom STB USB PHY.
 	  This driver is required by the USB XHCI, EHCI and OHCI
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Al Cooper <alcooperx@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Al Cooper" <alcooperx@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	linux-phy@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Vinod Koul" <vkoul@kernel.org>
Subject: [PATCH 3/3] phy: broadcom: Kconfig: Fix PHY_BRCM_USB config option
Date: Wed,  1 Dec 2021 13:06:53 -0500	[thread overview]
Message-ID: <20211201180653.35097-4-alcooperx@gmail.com> (raw)
In-Reply-To: <20211201180653.35097-1-alcooperx@gmail.com>

The previous commit 4b402fa8e0b7 ("phy: phy-brcm-usb: support PHY on
the BCM4908") added a second "default" line for ARCH_BCM_4908 above
the original "default" line for ARCH_BRCMSTB. When two "default"
lines are used, only the first is used and this change stopped
the PHY_BRCM_USB option for being enabled for ARCH_BRCMSTB.
The fix is to use one "default line with "||".

Fixes: 4b402fa8e0b7 ("phy: phy-brcm-usb: support PHY on the BCM4908")
Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
 drivers/phy/broadcom/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index f81e23742079..849c4204f550 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -97,8 +97,7 @@ config PHY_BRCM_USB
 	depends on OF
 	select GENERIC_PHY
 	select SOC_BRCMSTB if ARCH_BRCMSTB
-	default ARCH_BCM4908
-	default ARCH_BRCMSTB
+	default ARCH_BCM4908 || ARCH_BRCMSTB
 	help
 	  Enable this to support the Broadcom STB USB PHY.
 	  This driver is required by the USB XHCI, EHCI and OHCI
-- 
2.17.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2021-12-01 18:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 18:06 [PATCH 0/3] phy: phy-brcm-usb: Fixes for phy-brcm-usb driver Al Cooper
2021-12-01 18:06 ` Al Cooper
2021-12-01 18:06 ` [PATCH 1/3] phy: usb: Leave some clocks running during suspend Al Cooper
2021-12-01 18:06   ` Al Cooper
2021-12-01 20:39   ` Florian Fainelli
2021-12-01 20:39     ` Florian Fainelli
2021-12-02  4:35   ` Vinod Koul
2021-12-02  4:35     ` Vinod Koul
2022-01-06 21:01     ` Alan Cooper
2022-01-06 21:01       ` Alan Cooper
2021-12-01 18:06 ` [PATCH 2/3] usb: Add "wake on" functionality for newer Synopsis XHCI controllers Al Cooper
2021-12-01 18:06   ` Al Cooper
2021-12-01 20:40   ` Florian Fainelli
2021-12-01 20:40     ` Florian Fainelli
2021-12-01 18:06 ` Al Cooper [this message]
2021-12-01 18:06   ` [PATCH 3/3] phy: broadcom: Kconfig: Fix PHY_BRCM_USB config option Al Cooper
2021-12-01 20:40   ` Florian Fainelli
2021-12-01 20:40     ` Florian Fainelli
2021-12-01 21:08   ` Rafał Miłecki
2021-12-01 21:08     ` Rafał Miłecki
2022-01-19 23:26 ` [PATCH 0/3] phy: phy-brcm-usb: Fixes for phy-brcm-usb driver Florian Fainelli
2022-01-19 23:26   ` Florian Fainelli
2022-01-23 11:45   ` Vinod Koul
2022-01-23 11:45     ` Vinod Koul
2022-01-28  1:01     ` Florian Fainelli
2022-01-28  1:01       ` Florian Fainelli
2022-02-02  4:57       ` Vinod Koul
2022-02-02  4:57         ` Vinod Koul
2022-02-02 16:24         ` Florian Fainelli
2022-02-02 16:24           ` Florian Fainelli
2022-02-03  0:12           ` Vinod Koul
2022-02-03  0:12             ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211201180653.35097-4-alcooperx@gmail.com \
    --to=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=rafal@milecki.pl \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.