* [PATCH rcu 0/8] Torture-script updates for v5.17
@ 2021-12-02 0:46 Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 1/8] rcutorture: Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios Paul E. McKenney
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel
Hello!
This series contains torture-scripting updates:
1. Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios.
2. Catch kvm.sh help text up with actual options.
3. Make kvm-find-errors.sh report link-time undefined symbols.
4. Retry download once before giving up.
5. Cause TREE02 and TREE10 scenarios to do more callback flooding.
6. Test RCU Tasks lock-contention detection.
7. Fix incorrectly redirected "exit" in kvm-remote.sh.
8. Properly redirect kvm-remote.sh "echo" commands.
Thanx, Paul
------------------------------------------------------------------------
b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh | 4 +--
b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh | 11 +++++++--
b/tools/testing/selftests/rcutorture/bin/kvm.sh | 9 +++++--
b/tools/testing/selftests/rcutorture/bin/parse-build.sh | 3 +-
b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-T | 1
b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-U | 1
b/tools/testing/selftests/rcutorture/configs/rcu/TINY01 | 1
b/tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 1
b/tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot | 1
b/tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot | 1
b/tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot | 1
b/tools/testing/selftests/rcutorture/configs/rcuscale/TINY | 1
tools/testing/selftests/rcutorture/bin/kvm-remote.sh | 12 +++++-----
13 files changed, 33 insertions(+), 14 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH rcu 1/8] rcutorture: Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 2/8] torture: Catch kvm.sh help text up with actual options Paul E. McKenney
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
With CONFIG_PREEMPT_DYNAMIC=y, the kernel builds with CONFIG_PREEMPTION=y
because preemption can be enabled at runtime. This prevents any tests
of Tiny RCU or Tiny SRCU from running correctly. This commit therefore
explicitly sets CONFIG_PREEMPT_DYNAMIC=n for those scenarios.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/configs/rcu/SRCU-T | 1 +
tools/testing/selftests/rcutorture/configs/rcu/SRCU-U | 1 +
tools/testing/selftests/rcutorture/configs/rcu/TINY01 | 1 +
tools/testing/selftests/rcutorture/configs/rcu/TINY02 | 1 +
tools/testing/selftests/rcutorture/configs/rcuscale/TINY | 1 +
5 files changed, 5 insertions(+)
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-T b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-T
index d6557c38dfe47..c70cf0405f248 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-T
+++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-T
@@ -2,6 +2,7 @@ CONFIG_SMP=n
CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_VOLUNTARY=n
CONFIG_PREEMPT=n
+CONFIG_PREEMPT_DYNAMIC=n
#CHECK#CONFIG_TINY_SRCU=y
CONFIG_RCU_TRACE=n
CONFIG_DEBUG_LOCK_ALLOC=y
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-U b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-U
index 6bc24e99862f9..bc9eeabaa1b18 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-U
+++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-U
@@ -2,6 +2,7 @@ CONFIG_SMP=n
CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_VOLUNTARY=n
CONFIG_PREEMPT=n
+CONFIG_PREEMPT_DYNAMIC=n
#CHECK#CONFIG_TINY_SRCU=y
CONFIG_RCU_TRACE=n
CONFIG_DEBUG_LOCK_ALLOC=n
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TINY01 b/tools/testing/selftests/rcutorture/configs/rcu/TINY01
index 6db705e554874..0953c52fcfd76 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/TINY01
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TINY01
@@ -2,6 +2,7 @@ CONFIG_SMP=n
CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_VOLUNTARY=n
CONFIG_PREEMPT=n
+CONFIG_PREEMPT_DYNAMIC=n
#CHECK#CONFIG_TINY_RCU=y
CONFIG_HZ_PERIODIC=n
CONFIG_NO_HZ_IDLE=y
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TINY02 b/tools/testing/selftests/rcutorture/configs/rcu/TINY02
index d8674264318d6..30439f6fc20e6 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/TINY02
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TINY02
@@ -2,6 +2,7 @@ CONFIG_SMP=n
CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_VOLUNTARY=n
CONFIG_PREEMPT=n
+CONFIG_PREEMPT_DYNAMIC=n
#CHECK#CONFIG_TINY_RCU=y
CONFIG_HZ_PERIODIC=y
CONFIG_NO_HZ_IDLE=n
diff --git a/tools/testing/selftests/rcutorture/configs/rcuscale/TINY b/tools/testing/selftests/rcutorture/configs/rcuscale/TINY
index fb05ef5279b43..64e9490c1f797 100644
--- a/tools/testing/selftests/rcutorture/configs/rcuscale/TINY
+++ b/tools/testing/selftests/rcutorture/configs/rcuscale/TINY
@@ -2,6 +2,7 @@ CONFIG_SMP=n
CONFIG_PREEMPT_NONE=y
CONFIG_PREEMPT_VOLUNTARY=n
CONFIG_PREEMPT=n
+CONFIG_PREEMPT_DYNAMIC=n
#CHECK#CONFIG_TINY_RCU=y
CONFIG_HZ_PERIODIC=n
CONFIG_NO_HZ_IDLE=y
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 2/8] torture: Catch kvm.sh help text up with actual options
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 1/8] rcutorture: Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 3/8] torture: Make kvm-find-errors.sh report link-time undefined symbols Paul E. McKenney
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
This commit brings the kvm.sh script's help text up to date with recently
(and some not-so-recently) added parameters.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh
index 6cf9ec6a3d1c0..6de0c183db5b9 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm.sh
@@ -74,7 +74,9 @@ usage () {
echo " --help"
echo " --interactive"
echo " --jitter N [ maxsleep (us) [ maxspin (us) ] ]"
+ echo " --kasan"
echo " --kconfig Kconfig-options"
+ echo " --kcsan"
echo " --kmake-arg kernel-make-arguments"
echo " --mac nn:nn:nn:nn:nn:nn"
echo " --memory megabytes|nnnG"
@@ -83,6 +85,7 @@ usage () {
echo " --qemu-cmd qemu-system-..."
echo " --remote"
echo " --results absolute-pathname"
+ echo " --shutdown-grace seconds"
echo " --torture lock|rcu|rcuscale|refscale|scf"
echo " --trust-make"
exit 1
@@ -175,14 +178,14 @@ do
jitter="$2"
shift
;;
+ --kasan)
+ TORTURE_KCONFIG_KASAN_ARG="CONFIG_DEBUG_INFO=y CONFIG_KASAN=y"; export TORTURE_KCONFIG_KASAN_ARG
+ ;;
--kconfig|--kconfigs)
checkarg --kconfig "(Kconfig options)" $# "$2" '^CONFIG_[A-Z0-9_]\+=\([ynm]\|[0-9]\+\)\( CONFIG_[A-Z0-9_]\+=\([ynm]\|[0-9]\+\)\)*$' '^error$'
TORTURE_KCONFIG_ARG="`echo "$TORTURE_KCONFIG_ARG $2" | sed -e 's/^ *//' -e 's/ *$//'`"
shift
;;
- --kasan)
- TORTURE_KCONFIG_KASAN_ARG="CONFIG_DEBUG_INFO=y CONFIG_KASAN=y"; export TORTURE_KCONFIG_KASAN_ARG
- ;;
--kcsan)
TORTURE_KCONFIG_KCSAN_ARG="CONFIG_DEBUG_INFO=y CONFIG_KCSAN=y CONFIG_KCSAN_STRICT=y CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000 CONFIG_KCSAN_VERBOSE=y CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y"; export TORTURE_KCONFIG_KCSAN_ARG
;;
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 3/8] torture: Make kvm-find-errors.sh report link-time undefined symbols
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 1/8] rcutorture: Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 2/8] torture: Catch kvm.sh help text up with actual options Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 4/8] torture: Retry download once before giving up Paul E. McKenney
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
This commit makes kvm-find-errors.sh check for and report undefined
symbols that are detected at link time.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh | 4 ++--
tools/testing/selftests/rcutorture/bin/parse-build.sh | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
index daf64b5070387..2e9e9e2eedb69 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
@@ -30,9 +30,9 @@ editor=${EDITOR-vi}
files=
for i in ${rundir}/*/Make.out
do
- if egrep -q "error:|warning:" < $i
+ if egrep -q "error:|warning:|^ld: .*undefined reference to" < $i
then
- egrep "error:|warning:" < $i > $i.diags
+ egrep "error:|warning:|^ld: .*undefined reference to" < $i > $i.diags
files="$files $i.diags $i"
fi
done
diff --git a/tools/testing/selftests/rcutorture/bin/parse-build.sh b/tools/testing/selftests/rcutorture/bin/parse-build.sh
index 9313e5065ae92..2dbfca3589b17 100755
--- a/tools/testing/selftests/rcutorture/bin/parse-build.sh
+++ b/tools/testing/selftests/rcutorture/bin/parse-build.sh
@@ -39,7 +39,8 @@ fi
grep warning: < $F > $T/warnings
grep "include/linux/*rcu*\.h:" $T/warnings > $T/hwarnings
grep "kernel/rcu/[^/]*:" $T/warnings > $T/cwarnings
-cat $T/hwarnings $T/cwarnings > $T/rcuwarnings
+grep "^ld: .*undefined reference to" $T/warnings | head -1 > $T/ldwarnings
+cat $T/hwarnings $T/cwarnings $T/ldwarnings > $T/rcuwarnings
if test -s $T/rcuwarnings
then
print_warning $title build errors:
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 4/8] torture: Retry download once before giving up
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
` (2 preceding siblings ...)
2021-12-02 0:46 ` [PATCH rcu 3/8] torture: Make kvm-find-errors.sh report link-time undefined symbols Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 5/8] rcutorture: Cause TREE02 and TREE10 scenarios to do more callback flooding Paul E. McKenney
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
Currently, a transient network error can kill a run if it happens while
downloading the tarball to one of the target systems. This commit
therefore does a 60-second wait and then a retry. If further experience
indicates, a more elaborate mechanism might be used later.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm-remote.sh | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
index c7d42ef80c534..67ebc56111e3f 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
@@ -157,8 +157,15 @@ do
ret=$?
if test "$ret" -ne 0
then
- echo Unable to download $T/binres.tgz to system $i, giving up. | tee -a "$oldrun/remote-log"
- exit 10 | tee -a "$oldrun/remote-log"
+ echo Unable to download $T/binres.tgz to system $i, waiting and then retrying. | tee -a "$oldrun/remote-log"
+ sleep 60
+ cat $T/binres.tgz | ssh $i "cd /tmp; tar -xzf -"
+ ret=$?
+ if test "$ret" -ne 0
+ then
+ echo Unable to download $T/binres.tgz to system $i, giving up. | tee -a "$oldrun/remote-log"
+ exit 10
+ fi
fi
done
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 5/8] rcutorture: Cause TREE02 and TREE10 scenarios to do more callback flooding
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
` (3 preceding siblings ...)
2021-12-02 0:46 ` [PATCH rcu 4/8] torture: Retry download once before giving up Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 6/8] rcutorture: Test RCU Tasks lock-contention detection Paul E. McKenney
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney,
Neeraj Upadhyay
This commit enables two callback-flood kthreads for the TREE02 scenario
and 28 for the TREE10 scenario.
Cc: Neeraj Upadhyay <neeraj.iitr10@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot | 1 +
tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot | 1 +
2 files changed, 2 insertions(+)
create mode 100644 tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot
create mode 100644 tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot
new file mode 100644
index 0000000000000..dd914fa8f690b
--- /dev/null
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE02.boot
@@ -0,0 +1 @@
+rcutorture.fwd_progress=2
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot
new file mode 100644
index 0000000000000..dd914fa8f690b
--- /dev/null
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE10.boot
@@ -0,0 +1 @@
+rcutorture.fwd_progress=2
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 6/8] rcutorture: Test RCU Tasks lock-contention detection
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
` (4 preceding siblings ...)
2021-12-02 0:46 ` [PATCH rcu 5/8] rcutorture: Cause TREE02 and TREE10 scenarios to do more callback flooding Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 7/8] torture: Fix incorrectly redirected "exit" in kvm-remote.sh Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 8/8] torture: Properly redirect kvm-remote.sh "echo" commands Paul E. McKenney
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney,
Neeraj Upadhyay
This commit adjusts the TRACE02 scenario to use a pair of callback-flood
kthreads. This in turn forces lock contention on the single RCU Tasks
Trace callback queue, which forces use of all CPUs' queues, thus testing
this transition. (No, there is not yet any way to transition back.
Cc: Neeraj Upadhyay <neeraj.iitr10@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot b/tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot
index 9675ad632dcc2..c70b5db6c2ae0 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TRACE02.boot
@@ -1 +1,2 @@
rcutorture.torture_type=tasks-tracing
+rcutorture.fwd_progress=2
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 7/8] torture: Fix incorrectly redirected "exit" in kvm-remote.sh
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
` (5 preceding siblings ...)
2021-12-02 0:46 ` [PATCH rcu 6/8] rcutorture: Test RCU Tasks lock-contention detection Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 8/8] torture: Properly redirect kvm-remote.sh "echo" commands Paul E. McKenney
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
The "exit 4" in kvm-remote.sh is pointlessly redirected, so this commit
removes the redirection.
Fixes: 0092eae4cb4e ("torture: Add kvm-remote.sh script for distributed rcutorture test runs")
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm-remote.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
index 67ebc56111e3f..7ab79b0d5ad19 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
@@ -144,7 +144,7 @@ do
if test "$ret" -ne 0
then
echo System $i unreachable, giving up. | tee -a "$oldrun/remote-log"
- exit 4 | tee -a "$oldrun/remote-log"
+ exit 4
fi
done
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH rcu 8/8] torture: Properly redirect kvm-remote.sh "echo" commands
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
` (6 preceding siblings ...)
2021-12-02 0:46 ` [PATCH rcu 7/8] torture: Fix incorrectly redirected "exit" in kvm-remote.sh Paul E. McKenney
@ 2021-12-02 0:46 ` Paul E. McKenney
7 siblings, 0 replies; 9+ messages in thread
From: Paul E. McKenney @ 2021-12-02 0:46 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, mingo, jiangshanlai, akpm,
mathieu.desnoyers, josh, tglx, peterz, rostedt, dhowells,
edumazet, fweisbec, oleg, joel, Paul E. McKenney
The echo commands following initialization of the "oldrun" variable need
to be "tee"d to $oldrun/remote-log. This commit fixes several stragglers.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm-remote.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
index 7ab79b0d5ad19..e09b1bc787084 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-remote.sh
@@ -184,16 +184,16 @@ checkremotefile () {
ret=$?
if test "$ret" -eq 255
then
- echo " ---" ssh failure to $1 checking for file $2, retry after $sleeptime seconds. `date`
+ echo " ---" ssh failure to $1 checking for file $2, retry after $sleeptime seconds. `date` | tee -a "$oldrun/remote-log"
elif test "$ret" -eq 0
then
return 0
elif test "$ret" -eq 1
then
- echo " ---" File \"$2\" not found: ssh $1 test -f \"$2\"
+ echo " ---" File \"$2\" not found: ssh $1 test -f \"$2\" | tee -a "$oldrun/remote-log"
return 1
else
- echo " ---" Exit code $ret: ssh $1 test -f \"$2\", retry after $sleeptime seconds. `date`
+ echo " ---" Exit code $ret: ssh $1 test -f \"$2\", retry after $sleeptime seconds. `date` | tee -a "$oldrun/remote-log"
return $ret
fi
sleep $sleeptime
@@ -252,7 +252,7 @@ do
sleep 30
fi
done
-echo All batches started. `date`
+echo All batches started. `date` | tee -a "$oldrun/remote-log"
# Wait for all remaining scenarios to complete and collect results.
for i in $systems
@@ -261,7 +261,7 @@ do
do
sleep 30
done
- echo " ---" Collecting results from $i `date`
+ echo " ---" Collecting results from $i `date` | tee -a "$oldrun/remote-log"
( cd "$oldrun"; ssh $i "cd $rundir; tar -czf - kvm-remote-*.sh.out */console.log */kvm-test-1-run*.sh.out */qemu[_-]pid */qemu-retval */qemu-affinity; rm -rf $T > /dev/null 2>&1" | tar -xzf - )
done
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-12-02 0:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 0:46 [PATCH rcu 0/8] Torture-script updates for v5.17 Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 1/8] rcutorture: Add CONFIG_PREEMPT_DYNAMIC=n to tiny scenarios Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 2/8] torture: Catch kvm.sh help text up with actual options Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 3/8] torture: Make kvm-find-errors.sh report link-time undefined symbols Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 4/8] torture: Retry download once before giving up Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 5/8] rcutorture: Cause TREE02 and TREE10 scenarios to do more callback flooding Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 6/8] rcutorture: Test RCU Tasks lock-contention detection Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 7/8] torture: Fix incorrectly redirected "exit" in kvm-remote.sh Paul E. McKenney
2021-12-02 0:46 ` [PATCH rcu 8/8] torture: Properly redirect kvm-remote.sh "echo" commands Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.