All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	jgross@suse.com, sstabellini@kernel.org,
	boris.ostrovsky@oracle.com, joro@8bytes.org, will@kernel.org,
	davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
	m.szyprowski@samsung.com, robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com, thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, brijesh.singh@amd.com,
	konrad.wilk@oracle.com, hch@lst.de, parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
Date: Thu, 2 Dec 2021 14:43:36 +0000	[thread overview]
Message-ID: <20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20211201160257.1003912-4-ltykernel@gmail.com>

On Wed, Dec 01, 2021 at 11:02:54AM -0500, Tianyu Lan wrote:
[...]
> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
> index 46df59aeaa06..30fd0600b008 100644
> --- a/arch/x86/xen/pci-swiotlb-xen.c
> +++ b/arch/x86/xen/pci-swiotlb-xen.c
> @@ -4,6 +4,7 @@
>  
>  #include <linux/dma-map-ops.h>
>  #include <linux/pci.h>
> +#include <linux/hyperv.h>
>  #include <xen/swiotlb-xen.h>
>  
>  #include <asm/xen/hypervisor.h>
> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
>  EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
>  
>  IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> -		  NULL,
> +		  hyperv_swiotlb_detect,

It is not immediately obvious why this is needed just by reading the
code. Please consider copying some of the text in the commit message to
a comment here.

Thanks,
Wei.

WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu@kernel.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: linux-hyperv@vger.kernel.org, brijesh.singh@amd.com,
	dave.hansen@linux.intel.com, dave.hansen@intel.com,
	hpa@zytor.com, kys@microsoft.com, will@kernel.org,
	boris.ostrovsky@oracle.com, linux-arch@vger.kernel.org,
	michael.h.kelley@microsoft.com, wei.liu@kernel.org,
	sstabellini@kernel.org, sthemmin@microsoft.com,
	linux-scsi@vger.kernel.org, x86@kernel.org, decui@microsoft.com,
	hch@lst.de, hch@infradead.org, mingo@redhat.com, kuba@kernel.org,
	haiyangz@microsoft.com, parri.andrea@gmail.com,
	thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, arnd@arndb.de,
	konrad.wilk@oracle.com, jejb@linux.ibm.com, bp@alien8.de,
	xen-devel@lists.xenproject.org, tglx@linutronix.de,
	jgross@suse.com, martin.petersen@oracle.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, vkuznets@redhat.com,
	robin.murphy@arm.com, davem@davemloft.net
Subject: Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
Date: Thu, 2 Dec 2021 14:43:36 +0000	[thread overview]
Message-ID: <20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20211201160257.1003912-4-ltykernel@gmail.com>

On Wed, Dec 01, 2021 at 11:02:54AM -0500, Tianyu Lan wrote:
[...]
> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
> index 46df59aeaa06..30fd0600b008 100644
> --- a/arch/x86/xen/pci-swiotlb-xen.c
> +++ b/arch/x86/xen/pci-swiotlb-xen.c
> @@ -4,6 +4,7 @@
>  
>  #include <linux/dma-map-ops.h>
>  #include <linux/pci.h>
> +#include <linux/hyperv.h>
>  #include <xen/swiotlb-xen.h>
>  
>  #include <asm/xen/hypervisor.h>
> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
>  EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
>  
>  IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> -		  NULL,
> +		  hyperv_swiotlb_detect,

It is not immediately obvious why this is needed just by reading the
code. Please consider copying some of the text in the commit message to
a comment here.

Thanks,
Wei.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-12-02 14:43 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 16:02 [PATCH V3 0/5] x86/Hyper-V: Add Hyper-V Isolation VM support(Second part) Tianyu Lan
2021-12-01 16:02 ` Tianyu Lan
2021-12-01 16:02 ` [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-12-01 16:02   ` Tianyu Lan
2021-12-02 14:42   ` Tom Lendacky
2021-12-02 14:42     ` Tom Lendacky via iommu
2021-12-03 11:20     ` Tianyu Lan
2021-12-03 11:20       ` Tianyu Lan
2021-12-03 19:11       ` Tom Lendacky
2021-12-03 19:11         ` Tom Lendacky via iommu
2021-12-03 20:06         ` Tom Lendacky
2021-12-03 20:06           ` Tom Lendacky via iommu
2021-12-04  7:21           ` Tianyu Lan
2021-12-04  7:21             ` Tianyu Lan
2021-12-01 16:02 ` [PATCH V3 2/5] x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has() Tianyu Lan
2021-12-01 16:02   ` Tianyu Lan
2021-12-02 14:39   ` Wei Liu
2021-12-02 14:39     ` Wei Liu
2021-12-03 11:23     ` Tianyu Lan
2021-12-03 11:23       ` Tianyu Lan
2021-12-01 16:02 ` [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-12-01 16:02   ` Tianyu Lan
2021-12-02 14:43   ` Wei Liu [this message]
2021-12-02 14:43     ` Wei Liu
2021-12-03 11:25     ` Tianyu Lan
2021-12-03 11:25       ` Tianyu Lan
2021-12-03 19:17   ` Michael Kelley (LINUX)
2021-12-03 19:17     ` Michael Kelley (LINUX) via iommu
2021-12-04  7:26     ` Tianyu Lan
2021-12-04  7:26       ` Tianyu Lan
2021-12-01 16:02 ` [PATCH V3 4/5] scsi: storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-12-01 16:02   ` Tianyu Lan
2021-12-01 16:02 ` [PATCH V3 5/5] hv_netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-12-01 16:02   ` Tianyu Lan
2021-12-03 18:59   ` Michael Kelley (LINUX)
2021-12-03 18:59     ` Michael Kelley (LINUX) via iommu
2021-12-04  7:42     ` Tianyu Lan
2021-12-04  7:42       ` Tianyu Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=arnd@arndb.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jejb@linux.ibm.com \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ltykernel@gmail.com \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.petersen@oracle.com \
    --cc=michael.h.kelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.